Update readme: updated links

MT5Connector/MT5Connector.cpp

@@ -208,6 +208,16 @@ _DLLAPI int _stdcall sendMqlRatesArrayResponse(int expertHandle, CMqlRates value
     }, err, 0);
 }
 
+_DLLAPI bool _stdcall sendErrorResponse(int expertHandle, int code, wchar_t* message, wchar_t* err)
+{
+    return Execute<bool>([&expertHandle, &code, message]() {
+        MtResponseString^ res = gcnew MtResponseString(gcnew String(message));
+        res->ErrorCode = code;
+        MtAdapter::GetInstance()->SendResponse(expertHandle, res);
+        return true;
+    }, err, false);
+}
+
 //----------- get values -------------------------------
 
 _DLLAPI int _stdcall getCommandType(int expertHandle, int* res, wchar_t* err)

MTApiService/Properties/AssemblyInfo.cs

@@ -32,5 +32,5 @@ using System.Runtime.InteropServices;
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.0.31.0")]
-[assembly: AssemblyFileVersion("1.0.31.0")]
+[assembly: AssemblyVersion("1.0.32.0")]
+[assembly: AssemblyFileVersion("1.0.32.0")]

MtApi/Properties/AssemblyInfo.cs

@@ -32,5 +32,5 @@ using System.Runtime.InteropServices;
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.0.40.0")]
-[assembly: AssemblyFileVersion("1.0.40.0")]
+[assembly: AssemblyVersion("1.0.41.0")]
+[assembly: AssemblyFileVersion("1.0.41.0")]

MtApi5/MtApi5.csproj

@@ -78,6 +78,7 @@
     <Compile Include="Events\Mt5EventTypes.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="Mt5Quote.cs" />
+    <Compile Include="Requests\BuyRequest.cs" />
     <Compile Include="Requests\ChartTimePriceToXyRequest.cs" />
     <Compile Include="Requests\ChartTimePriceToXyResult.cs" />
     <Compile Include="Requests\ChartXyToTimePriceRequest.cs" />
@@ -88,6 +89,7 @@
     <Compile Include="Requests\MarketBookGetRequest.cs" />
     <Compile Include="Requests\OrderCheckRequest.cs" />
     <Compile Include="Requests\OrderCheckResult.cs" />
+    <Compile Include="Requests\OrderSendAsyncRequest.cs" />
     <Compile Include="Requests\OrderSendRequest.cs" />
     <Compile Include="Requests\PositionCloseRequest.cs" />
     <Compile Include="Requests\PositionCloseResult.cs" />
@@ -96,6 +98,7 @@
     <Compile Include="Requests\RequestType.cs" />
     <Compile Include="Requests\OrderSendResult.cs" />
     <Compile Include="Requests\Response.cs" />
+    <Compile Include="Requests\SellRequest.cs" />
     <Compile Include="Requests\SymbolInfoStringRequest.cs" />
     <Compile Include="Requests\SymbolInfoStringResult.cs" />
     <Compile Include="Requests\SymbolInfoTickRequest.cs" />

MtApi5/MtApi5Client.cs

@@ -134,6 +134,38 @@ namespace MtApi5
             return response != null && response.RetVal;
         }
 
+        ///<summary>
+        ///Function is used for conducting asynchronous trade operations without waiting for the trade server's response to a sent request.
+        ///</summary>
+        ///<param name="request">Reference to a object of MqlTradeRequest type describing the trade activity of the client.</param>
+        ///<param name="result">Reference to a object of MqlTradeResult type describing the result of trade operation in case of a successful completion (if true is returned).</param>
+        /// <returns>
+        /// Returns true if the request is sent to a trade server. In case the request is not sent, it returns false. 
+        /// In case the request is sent, in the result variable the response code contains TRADE_RETCODE_PLACED value (code 10008) – "order placed". 
+        /// Successful execution means only the fact of sending, but does not give any guarantee that the request has reached the trade server and has been accepted for processing. 
+        /// When processing the received request, a trade server sends a reply to a client terminal notifying of change in the current state of positions, 
+        /// orders and deals, which leads to the generation of the Trade event.
+        /// </returns>
+        public bool OrderSendAsync(MqlTradeRequest request, out MqlTradeResult result)
+        {
+            Log.Debug($"OrderSend: request = {request}");
+
+            if (request == null)
+            {
+                Log.Warn("OrderSend: request is not defined!");
+                result = null;
+                return false;
+            }
+
+            var response = SendRequest<OrderSendResult>(new OrderSendAsyncRequest
+            {
+                TradeRequest = request
+            });
+
+            result = response?.TradeResult;
+            return response != null && response.RetVal;
+        }
+
         ///<summary>
         ///The function calculates the margin required for the specified order type, on the current account
         ///, in the current market environment not taking into account current pending orders and open positions
@@ -683,6 +715,64 @@ namespace MtApi5
 
             return SendCommand<bool>(Mt5CommandType.PositionClosePartial_byTicket, commandParameters);
         }
+
+        /// <summary>
+        /// Opens a long position with specified parameters with current market Ask price
+        /// </summary>
+        /// <param name="result">output result</param>
+        /// <param name="volume">Requested position volume.</param>
+        /// <param name="symbol">Position symbol. If it is not specified, the current symbol will be used.</param>
+        /// <param name="price">Execution price.</param>
+        /// <param name="sl">Stop Loss price.</param>
+        /// <param name="tp">Take Profit price.</param>
+        /// <param name="comment">Comment.</param>
+        /// <returns>true - successful check of the structures, otherwise - false.</returns>
+        public bool Buy(out MqlTradeResult result, double volume, string symbol = null, double price = 0.0, double sl = 0.0, double tp = 0.0, string comment = null)
+        {
+            Log.Debug($"Buy: volume = {volume}, symbol = {symbol}, sl = {sl}, tp = {tp}, comment = {comment}");
+
+            var response = SendRequest<OrderSendResult>(new BuyRequest
+            {
+                Volume = volume,
+                Symbol = symbol,
+                Price = price,
+                Sl = sl,
+                Tp = tp,
+                Comment = comment
+            });
+
+            result = response?.TradeResult;
+            return response != null && response.RetVal;
+        }
+
+        /// <summary>
+        /// Opens a short position with specified parameters with current market Bid price
+        /// </summary>
+        /// <param name="result">output result</param>
+        /// <param name="volume">Requested position volume.</param>
+        /// <param name="symbol">Position symbol. If it is not specified, the current symbol will be used.</param>
+        /// <param name="price">Execution price.</param>
+        /// <param name="sl">Stop Loss price.</param>
+        /// <param name="tp">Take Profit price.</param>
+        /// <param name="comment">Comment.</param>
+        /// <returns>true - successful check of the structures, otherwise - false.</returns>
+        public bool Sell(out MqlTradeResult result, double volume, string symbol = null, double price = 0.0, double sl = 0.0, double tp = 0.0, string comment = null)
+        {
+            Log.Debug($"Sell: volume = {volume}, symbol = {symbol}, sl = {sl}, tp = {tp}, comment = {comment}");
+
+            var response = SendRequest<OrderSendResult>(new SellRequest
+            {
+                Volume = volume,
+                Symbol = symbol,
+                Price = price,
+                Sl = sl,
+                Tp = tp,
+                Comment = comment
+            });
+
+            result = response?.TradeResult;
+            return response != null && response.RetVal;
+        }
         #endregion
 
         #region Account Information functions

MtApi5/Properties/AssemblyInfo.cs

@@ -32,5 +32,5 @@ using System.Runtime.InteropServices;
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.0.21")]
-[assembly: AssemblyFileVersion("1.0.21")]
+[assembly: AssemblyVersion("1.0.23")]
+[assembly: AssemblyFileVersion("1.0.23")]

MtApi5/Requests/BuyRequest.cs

@@ -0,0 +1,14 @@
+namespace MtApi5.Requests
+{
+    internal class BuyRequest : RequestBase
+    {
+        public override RequestType RequestType => RequestType.Buy;
+
+        public double Volume { get; set; }
+        public string Symbol { get; set; }
+        public double Price { get; set; }
+        public double Sl { get; set; }
+        public double Tp { get; set; }
+        public string Comment { get; set; }
+    }
+}

MtApi5/Requests/OrderSendAsyncRequest.cs

@@ -0,0 +1,9 @@
+namespace MtApi5.Requests
+{
+    internal class OrderSendAsyncRequest : RequestBase
+    {
+        public override RequestType RequestType => RequestType.OrderSendAsync;
+
+        public MqlTradeRequest TradeRequest { get; set; }
+    }
+}

MtApi5/Requests/RequestType.cs

@@ -16,6 +16,9 @@ namespace MtApi5.Requests
         ChartTimePriceToXY  = 9,
         ChartXYToTimePrice  = 10,
         PositionClose       = 11,
-        SymbolInfoTick      = 12
+        SymbolInfoTick      = 12,
+        Buy                 = 13,
+        Sell                = 14,
+        OrderSendAsync      = 15
     }
 }

MtApi5/Requests/SellRequest.cs

@@ -0,0 +1,14 @@
+namespace MtApi5.Requests
+{
+    internal class SellRequest : RequestBase
+    {
+        public override RequestType RequestType => RequestType.Sell;
+
+        public double Volume { get; set; }
+        public string Symbol { get; set; }
+        public double Price { get; set; }
+        public double Sl { get; set; }
+        public double Tp { get; set; }
+        public string Comment { get; set; }
+    }
+}

README.md

@@ -20,4 +20,8 @@ MQL files have been build to ex4 and stored into folders "mq4" for MetaTrader an
 Changing the source code of MQL expert requires recompilation with MetaEditor. Resulting in the need to copy files "hash.mqh" and "json.mqh" to the MetaEditor include folder.
 
 # Home Website
-Please visit http://mtapi4.net
+
+# Telegram Channel
+https://t.me/mtapi4
+
+https://t.me/joinchat/GfnfUxvelQCLvvIvLO16-w

TestClients/MtApi5TestClient/MainWindow.xaml

@@ -497,6 +497,7 @@
                             <RowDefinition Height="Auto"/>
                             <RowDefinition Height="Auto"/>
                             <RowDefinition Height="Auto"/>
+                            <RowDefinition Height="Auto"/>
                         </Grid.RowDefinitions>
                         <Button Grid.Row="0" Command="{Binding PositionOpenCommand}" Content="PositionOpen" Margin="2" HorizontalAlignment="Left"/>
                         <StackPanel Grid.Row="1" Orientation="Horizontal" Margin="4">
@@ -505,6 +506,10 @@
                             <Button Command="{Binding PositionCloseCommand}" Content="PositionClose" Margin="2"/>
                         </StackPanel>
                         <Button Grid.Row="2" Command="{Binding PositionCloseAllCommand}" Content="PositionCloseAll" Margin="2" HorizontalAlignment="Left"/>
+                        <StackPanel Grid.Row="3" Orientation="Horizontal" Margin="4">
+                            <Button Command="{Binding BuyCommand}" Content="Buy" Width="60" Margin="2" HorizontalAlignment="Left"/>
+                            <Button Command="{Binding SellCommand}" Content="Sell" Width="60" Margin="2" HorizontalAlignment="Left"/>
+                        </StackPanel>
                     </Grid>
                 </TabItem>
 

TestClients/MtApi5TestClient/ViewModel.cs

@@ -73,6 +73,8 @@ namespace MtApi5TestClient
         public DelegateCommand PositionOpenCommand { get; private set; }
         public DelegateCommand PositionCloseCommand { get; private set; }
         public DelegateCommand PositionCloseAllCommand { get; private set; }
+        public DelegateCommand BuyCommand { get; private set; }
+        public DelegateCommand SellCommand { get; private set; }
 
         public DelegateCommand GetLastErrorCommand { get; private set; }
         public DelegateCommand ResetLastErrorCommand { get; private set; }
@@ -386,6 +388,8 @@ namespace MtApi5TestClient
             PositionOpenCommand = new DelegateCommand(ExecutePositionOpen);
             PositionCloseCommand = new DelegateCommand(ExecutePositionClose);
             PositionCloseAllCommand = new DelegateCommand(ExecutePositionCloseAll);
+            BuyCommand = new DelegateCommand(ExecuteBuy);
+            SellCommand = new DelegateCommand(ExecuteSell);
 
             PrintCommand = new DelegateCommand(ExecutePrint);
             AlertCommand = new DelegateCommand(ExecuteAlert);
@@ -1211,6 +1215,26 @@ namespace MtApi5TestClient
             AddLog($"PositionCloseAll: count = {retVal}");
         }
 
+        private async void ExecuteBuy(object obj)
+        {
+            const string symbol = "EURUSD";
+            const double volume = 0.1;
+            MqlTradeResult tradeResult = null;
+
+            var retVal = await Execute(() => _mtApiClient.Buy(out tradeResult, volume, symbol));
+            AddLog($"Buy: symbol EURUSD retVal = {retVal}, result = {tradeResult}");
+        }
+
+        private async void ExecuteSell(object obj)
+        {
+            const string symbol = "EURUSD";
+            const double volume = 0.1;
+            MqlTradeResult tradeResult = null;
+
+            var retVal = await Execute(() => _mtApiClient.Sell(out tradeResult, volume, symbol));
+            AddLog($"Sell: symbol EURUSD retVal = {retVal}, result = {tradeResult}");
+        }
+
         private async void ExecutePrint(object obj)
         {
             var message = MessageText;

mq5/MtApi5.mq5

@@ -1,7 +1,7 @@
 #property copyright "Vyacheslav Demidyuk"
 #property link      ""
 
-#property version   "1.6"
+#property version   "1.9"
 #property description "MtApi (MT5) connection expert"
 
 #include <json.mqh>
@@ -172,6 +172,7 @@ void OnBookEvent(const string& symbol)
 
 int preinit()
 {
+   StringInit(_error,1000,0);
    StringInit(_response_error,1000,0);
 
    return (0);
@@ -6955,6 +6956,15 @@ string OnRequest(string json)
             case 12: //SymbolInfoTick
                response = ExecuteRequest_SymbolInfoTick(jo);
                break;
+            case 13: //Buy
+               response = ExecuteRequest_Buy(jo);
+               break;
+            case 14: //Sell
+               response = ExecuteRequest_Sell(jo);
+               break;
+            case 15: //OrderSendAsync
+               response = ExecuteRequest_OrderSendAsync(jo);
+               break;
             default:
                PrintFormat("%s [WARNING]: Unknown request type %d", __FUNCTION__, requestType);
                response = CreateErrorResponse(-1, "Unknown request type");
@@ -7164,6 +7174,30 @@ string ExecuteRequest_OrderSend(JSONObject *jo)
    return CreateSuccessResponse("Value", result_value_jo);
 }
 
+string ExecuteRequest_OrderSendAsync(JSONObject *jo)
+{
+   CHECK_JSON_VALUE(jo, "TradeRequest", CreateErrorResponse(-1, "Undefinded mandatory parameter TradeRequest"));
+   JSONObject* trade_request_jo = jo.getObject("TradeRequest");
+      
+   MqlTradeRequest trade_request = {0};
+   bool converted = JsonToMqlTradeRequest(trade_request_jo, trade_request);
+   if (converted == false)
+      return CreateErrorResponse(-1, "Failed to parse parameter TradeRequest");
+   
+   MqlTradeResult trade_result = {0};   
+   bool ok = OrderSendAsync(trade_request, trade_result);
+   
+   JSONObject* result_value_jo = new JSONObject();
+   result_value_jo.put("RetVal", new JSONBool(ok));
+   result_value_jo.put("TradeResult", MqlTradeResultToJson(trade_result));
+   
+#ifdef __DEBUG_LOG__   
+   PrintFormat("%s: return value = %s", __FUNCTION__, ok ? "true" : "false");
+#endif    
+      
+   return CreateSuccessResponse("Value", result_value_jo);
+}
+
 string ExecuteRequest_PositionOpen(JSONObject *jo)
 {   
    //Symbol
@@ -7486,6 +7520,98 @@ string ExecuteRequest_SymbolInfoTick(JSONObject *jo)
    return CreateSuccessResponse("Value", MqlTickToJson(tick));      
 }
 
+string ExecuteRequest_Buy(JSONObject *jo)
+{
+   //Symbol
+   string symbol=Symbol();
+   if (jo.getValue("Symbol") != NULL)
+      symbol = jo.getString("Symbol");   
+     
+   //Volume
+   CHECK_JSON_VALUE(jo, "Volume", CreateErrorResponse(-1, "Undefinded mandatory parameter Volume"));
+   double volume = jo.getDouble("Volume");
+
+   //Price
+   CHECK_JSON_VALUE(jo, "Price", CreateErrorResponse(-1, "Undefinded mandatory parameter Price"));
+   double price = jo.getDouble("Price");
+
+   //Sl
+   CHECK_JSON_VALUE(jo, "Sl", CreateErrorResponse(-1, "Undefinded mandatory parameter Sl"));
+   double sl = jo.getDouble("Sl");
+   
+   //Tp
+   CHECK_JSON_VALUE(jo, "Tp", CreateErrorResponse(-1, "Undefinded mandatory parameter Tp"));
+   double tp = jo.getDouble("Tp");
+   
+   //Comment
+   string comment="";
+   if (jo.getValue("Comment") != NULL)
+      comment = jo.getString("Comment");
+
+#ifdef __DEBUG_LOG__
+   PrintFormat("%s: symbol = %s, volume = %f, price = %f, sl = %f, tp = %f, comment = %s", 
+      __FUNCTION__, symbol, volume, price, sl, tp, comment);
+#endif
+
+   CTrade trade;
+   bool ok = trade.Buy(volume, symbol, price, sl, tp, comment);
+
+   MqlTradeResult trade_result={0};
+   trade.Result(trade_result);
+
+   JSONObject* result_value_jo = new JSONObject();
+   result_value_jo.put("RetVal", new JSONBool(ok));
+   result_value_jo.put("TradeResult", MqlTradeResultToJson(trade_result));
+
+   return CreateSuccessResponse("Value", result_value_jo);   
+}
+
+string ExecuteRequest_Sell(JSONObject *jo)
+{
+   //Symbol
+   string symbol=Symbol();
+   if (jo.getValue("Symbol") != NULL)
+      symbol = jo.getString("Symbol");   
+     
+   //Volume
+   CHECK_JSON_VALUE(jo, "Volume", CreateErrorResponse(-1, "Undefinded mandatory parameter Volume"));
+   double volume = jo.getDouble("Volume");
+
+   //Price
+   CHECK_JSON_VALUE(jo, "Price", CreateErrorResponse(-1, "Undefinded mandatory parameter Price"));
+   double price = jo.getDouble("Price");
+
+   //Sl
+   CHECK_JSON_VALUE(jo, "Sl", CreateErrorResponse(-1, "Undefinded mandatory parameter Sl"));
+   double sl = jo.getDouble("Sl");
+   
+   //Tp
+   CHECK_JSON_VALUE(jo, "Tp", CreateErrorResponse(-1, "Undefinded mandatory parameter Tp"));
+   double tp = jo.getDouble("Tp");
+   
+   //Comment
+   string comment="";
+   if (jo.getValue("Comment") != NULL)
+      comment = jo.getString("Comment");
+
+#ifdef __DEBUG_LOG__
+   PrintFormat("%s: symbol = %s, volume = %f, price = %f, sl = %f, tp = %f, comment = %s", 
+      __FUNCTION__, symbol, volume, price, sl, tp, comment);
+#endif
+
+   CTrade trade;
+   bool ok = trade.Sell(volume, symbol, price, sl, tp, comment);
+
+   MqlTradeResult trade_result={0};
+   trade.Result(trade_result);
+
+   JSONObject* result_value_jo = new JSONObject();
+   result_value_jo.put("RetVal", new JSONBool(ok));
+   result_value_jo.put("TradeResult", MqlTradeResultToJson(trade_result));
+
+   return CreateSuccessResponse("Value", result_value_jo); 
+}
+
 //------------ Events -------------------------------------------------------
 
 enum MtEventTypes