mirror of
https://github.com/softwaredevelop/mql5.git
synced 2026-07-27 20:47:44 +00:00
refactor: Optimized for incremental calculation
This commit is contained in:
Toh4iem9
@@ -1,6 +1,6 @@
|
||||
//+------------------------------------------------------------------+
|
||||
//| AMA_Calculator.mqh |
|
||||
//| Calculation engine for Standard and Heikin Ashi AMA. |
|
||||
//| VERSION 2.10: Optimized for incremental calculation. |
|
||||
//| Copyright 2025, xxxxxxxx |
|
||||
//+------------------------------------------------------------------+
|
||||
#property copyright "Copyright 2025, xxxxxxxx"
|
||||
@@ -8,9 +8,7 @@
|
||||
#include <MyIncludes\HeikinAshi_Tools.mqh>
|
||||
|
||||
//+==================================================================+
|
||||
//| |
|
||||
//| CLASS 1: CAMACalculator (Base Class) |
|
||||
//| |
|
||||
//+==================================================================+
|
||||
class CAMACalculator
|
||||
{
|
||||
@@ -19,24 +17,25 @@ protected:
|
||||
int m_fast_period;
|
||||
int m_slow_period;
|
||||
|
||||
//--- Internal buffer for the selected source price
|
||||
//--- Persistent Buffer for Incremental Calculation
|
||||
double m_price[];
|
||||
|
||||
//--- Virtual method for preparing the price series.
|
||||
virtual bool PreparePriceSeries(int rates_total, const double &open[], const double &high[], const double &low[], const double &close[], ENUM_APPLIED_PRICE price_type);
|
||||
//--- Updated: Accepts start_index
|
||||
virtual bool PreparePriceSeries(int rates_total, int start_index, ENUM_APPLIED_PRICE price_type, const double &open[], const double &high[], const double &low[], const double &close[]);
|
||||
|
||||
public:
|
||||
CAMACalculator(void) {};
|
||||
virtual ~CAMACalculator(void) {};
|
||||
|
||||
//--- Public methods
|
||||
bool Init(int ama_p, int fast_p, int slow_p);
|
||||
int GetPeriod(void) const { return m_ama_period; }
|
||||
void Calculate(int rates_total, const double &open[], const double &high[], const double &low[], const double &close[], ENUM_APPLIED_PRICE price_type, double &ama_buffer[]);
|
||||
|
||||
//--- Updated: Accepts prev_calculated
|
||||
void Calculate(int rates_total, int prev_calculated, ENUM_APPLIED_PRICE price_type, const double &open[], const double &high[], const double &low[], const double &close[], double &ama_buffer[]);
|
||||
};
|
||||
|
||||
//+------------------------------------------------------------------+
|
||||
//| CAMACalculator: Initialization |
|
||||
//| Init |
|
||||
//+------------------------------------------------------------------+
|
||||
bool CAMACalculator::Init(int ama_p, int fast_p, int slow_p)
|
||||
{
|
||||
@@ -47,149 +46,167 @@ bool CAMACalculator::Init(int ama_p, int fast_p, int slow_p)
|
||||
}
|
||||
|
||||
//+------------------------------------------------------------------+
|
||||
//| CAMACalculator: Main Calculation Method (Shared Logic) |
|
||||
//| Main Calculation (Optimized) |
|
||||
//+------------------------------------------------------------------+
|
||||
void CAMACalculator::Calculate(int rates_total, const double &open[], const double &high[], const double &low[], const double &close[], ENUM_APPLIED_PRICE price_type, double &ama_buffer[])
|
||||
void CAMACalculator::Calculate(int rates_total, int prev_calculated, ENUM_APPLIED_PRICE price_type, const double &open[], const double &high[], const double &low[], const double &close[], double &ama_buffer[])
|
||||
{
|
||||
if(rates_total <= m_ama_period)
|
||||
return;
|
||||
|
||||
//--- STEP 1: Prepare the source price array (delegated to virtual method)
|
||||
if(!PreparePriceSeries(rates_total, open, high, low, close, price_type))
|
||||
//--- 1. Determine Start Index
|
||||
int start_index;
|
||||
if(prev_calculated == 0)
|
||||
start_index = 0;
|
||||
else
|
||||
start_index = prev_calculated - 1;
|
||||
|
||||
//--- 2. Resize Buffer
|
||||
if(ArraySize(m_price) != rates_total)
|
||||
ArrayResize(m_price, rates_total);
|
||||
|
||||
//--- 3. Prepare Price (Optimized)
|
||||
if(!PreparePriceSeries(rates_total, start_index, price_type, open, high, low, close))
|
||||
return;
|
||||
|
||||
//--- STEP 2: Core AMA calculation using the prepared m_price[] array
|
||||
//--- 4. Calculate AMA (Incremental Loop)
|
||||
double fast_sc = 2.0 / (m_fast_period + 1.0);
|
||||
double slow_sc = 2.0 / (m_slow_period + 1.0);
|
||||
|
||||
for(int i = 1; i < rates_total; i++)
|
||||
int loop_start = MathMax(m_ama_period, start_index);
|
||||
|
||||
for(int i = loop_start; i < rates_total; i++)
|
||||
{
|
||||
// --- Initialization Step ---
|
||||
if(i == m_ama_period)
|
||||
{
|
||||
// The first AMA value is simply the current price
|
||||
ama_buffer[i] = m_price[i];
|
||||
continue;
|
||||
}
|
||||
|
||||
if(i > m_ama_period)
|
||||
// --- Calculate Efficiency Ratio (ER) ---
|
||||
// We need m_price[i - m_ama_period], which is safe due to persistent buffer
|
||||
double direction = MathAbs(m_price[i] - m_price[i - m_ama_period]);
|
||||
double volatility = 0;
|
||||
|
||||
for(int j = 0; j < m_ama_period; j++)
|
||||
{
|
||||
// --- Calculate Efficiency Ratio (ER) ---
|
||||
double direction = MathAbs(m_price[i] - m_price[i - m_ama_period]);
|
||||
double volatility = 0;
|
||||
for(int j = 0; j < m_ama_period; j++)
|
||||
{
|
||||
volatility += MathAbs(m_price[i - j] - m_price[i - j - 1]);
|
||||
}
|
||||
double er = (volatility > 0) ? direction / volatility : 0;
|
||||
|
||||
// --- Calculate Scaled Smoothing Constant (SSC) ---
|
||||
double ssc = er * (fast_sc - slow_sc) + slow_sc;
|
||||
double ssc_sq = ssc * ssc;
|
||||
|
||||
// --- Calculate Final AMA ---
|
||||
ama_buffer[i] = ama_buffer[i-1] + ssc_sq * (m_price[i] - ama_buffer[i-1]);
|
||||
volatility += MathAbs(m_price[i - j] - m_price[i - j - 1]);
|
||||
}
|
||||
|
||||
double er = (volatility > 0) ? direction / volatility : 0;
|
||||
|
||||
// --- Calculate Scaled Smoothing Constant (SSC) ---
|
||||
double ssc = er * (fast_sc - slow_sc) + slow_sc;
|
||||
double ssc_sq = ssc * ssc;
|
||||
|
||||
// --- Calculate Final AMA ---
|
||||
// Recursive calculation uses ama_buffer[i-1] which is persistent
|
||||
ama_buffer[i] = ama_buffer[i-1] + ssc_sq * (m_price[i] - ama_buffer[i-1]);
|
||||
}
|
||||
}
|
||||
|
||||
//+------------------------------------------------------------------+
|
||||
//| CAMACalculator: Prepares the standard source price series. |
|
||||
//| Prepare Price (Standard - Optimized) |
|
||||
//+------------------------------------------------------------------+
|
||||
bool CAMACalculator::PreparePriceSeries(int rates_total, const double &open[], const double &high[], const double &low[], const double &close[], ENUM_APPLIED_PRICE price_type)
|
||||
bool CAMACalculator::PreparePriceSeries(int rates_total, int start_index, ENUM_APPLIED_PRICE price_type, const double &open[], const double &high[], const double &low[], const double &close[])
|
||||
{
|
||||
ArrayResize(m_price, rates_total);
|
||||
|
||||
switch(price_type)
|
||||
// Optimized copy loop
|
||||
for(int i = start_index; i < rates_total; i++)
|
||||
{
|
||||
case PRICE_OPEN:
|
||||
ArrayCopy(m_price, open, 0, 0, rates_total);
|
||||
break;
|
||||
case PRICE_HIGH:
|
||||
ArrayCopy(m_price, high, 0, 0, rates_total);
|
||||
break;
|
||||
case PRICE_LOW:
|
||||
ArrayCopy(m_price, low, 0, 0, rates_total);
|
||||
break;
|
||||
case PRICE_MEDIAN:
|
||||
for(int i = 0; i < rates_total; i++)
|
||||
m_price[i] = (high[i] + low[i]) / 2.0;
|
||||
break;
|
||||
case PRICE_TYPICAL:
|
||||
for(int i = 0; i < rates_total; i++)
|
||||
m_price[i] = (high[i] + low[i] + close[i]) / 3.0;
|
||||
break;
|
||||
case PRICE_WEIGHTED:
|
||||
for(int i = 0; i < rates_total; i++)
|
||||
m_price[i] = (high[i] + low[i] + 2 * close[i]) / 4.0;
|
||||
break;
|
||||
default: // PRICE_CLOSE
|
||||
ArrayCopy(m_price, close, 0, 0, rates_total);
|
||||
break;
|
||||
switch(price_type)
|
||||
{
|
||||
case PRICE_CLOSE:
|
||||
m_price[i] = close[i];
|
||||
break;
|
||||
case PRICE_OPEN:
|
||||
m_price[i] = open[i];
|
||||
break;
|
||||
case PRICE_HIGH:
|
||||
m_price[i] = high[i];
|
||||
break;
|
||||
case PRICE_LOW:
|
||||
m_price[i] = low[i];
|
||||
break;
|
||||
case PRICE_MEDIAN:
|
||||
m_price[i] = (high[i]+low[i])/2.0;
|
||||
break;
|
||||
case PRICE_TYPICAL:
|
||||
m_price[i] = (high[i]+low[i]+close[i])/3.0;
|
||||
break;
|
||||
case PRICE_WEIGHTED:
|
||||
m_price[i] = (high[i]+low[i]+2*close[i])/4.0;
|
||||
break;
|
||||
default:
|
||||
m_price[i] = close[i];
|
||||
break;
|
||||
}
|
||||
}
|
||||
return true;
|
||||
}
|
||||
|
||||
//+==================================================================+
|
||||
//| |
|
||||
//| CLASS 2: CAMACalculator_HA (Heikin Ashi) |
|
||||
//| |
|
||||
//+==================================================================+
|
||||
class CAMACalculator_HA : public CAMACalculator
|
||||
{
|
||||
private:
|
||||
CHeikinAshi_Calculator m_ha_calculator; // Instance of the HA calculator tool
|
||||
CHeikinAshi_Calculator m_ha_calculator;
|
||||
// Internal HA buffers
|
||||
double m_ha_open[], m_ha_high[], m_ha_low[], m_ha_close[];
|
||||
|
||||
protected:
|
||||
//--- Overridden method to prepare Heikin Ashi price series
|
||||
virtual bool PreparePriceSeries(int rates_total, const double &open[], const double &high[], const double &low[], const double &close[], ENUM_APPLIED_PRICE price_type) override;
|
||||
virtual bool PreparePriceSeries(int rates_total, int start_index, ENUM_APPLIED_PRICE price_type, const double &open[], const double &high[], const double &low[], const double &close[]) override;
|
||||
};
|
||||
|
||||
//+------------------------------------------------------------------+
|
||||
//| CAMACalculator_HA: Prepares the Heikin Ashi source price series. |
|
||||
//| Prepare Price (Heikin Ashi - Optimized) |
|
||||
//+------------------------------------------------------------------+
|
||||
bool CAMACalculator_HA::PreparePriceSeries(int rates_total, const double &open[], const double &high[], const double &low[], const double &close[], ENUM_APPLIED_PRICE price_type)
|
||||
bool CAMACalculator_HA::PreparePriceSeries(int rates_total, int start_index, ENUM_APPLIED_PRICE price_type, const double &open[], const double &high[], const double &low[], const double &close[])
|
||||
{
|
||||
//--- Intermediate buffers for HA candles
|
||||
double ha_open[], ha_high[], ha_low[], ha_close[];
|
||||
ArrayResize(ha_open, rates_total);
|
||||
ArrayResize(ha_high, rates_total);
|
||||
ArrayResize(ha_low, rates_total);
|
||||
ArrayResize(ha_close, rates_total);
|
||||
|
||||
//--- Calculate the HA candles first
|
||||
m_ha_calculator.Calculate(rates_total, open, high, low, close, ha_open, ha_high, ha_low, ha_close);
|
||||
|
||||
//--- Now, populate the m_price array from the calculated HA candles
|
||||
ArrayResize(m_price, rates_total);
|
||||
switch(price_type)
|
||||
// Resize internal HA buffers
|
||||
if(ArraySize(m_ha_open) != rates_total)
|
||||
{
|
||||
case PRICE_OPEN:
|
||||
ArrayCopy(m_price, ha_open, 0, 0, rates_total);
|
||||
break;
|
||||
case PRICE_HIGH:
|
||||
ArrayCopy(m_price, ha_high, 0, 0, rates_total);
|
||||
break;
|
||||
case PRICE_LOW:
|
||||
ArrayCopy(m_price, ha_low, 0, 0, rates_total);
|
||||
break;
|
||||
case PRICE_MEDIAN:
|
||||
for(int i = 0; i < rates_total; i++)
|
||||
m_price[i] = (ha_high[i] + ha_low[i]) / 2.0;
|
||||
break;
|
||||
case PRICE_TYPICAL:
|
||||
for(int i = 0; i < rates_total; i++)
|
||||
m_price[i] = (ha_high[i] + ha_low[i] + ha_close[i]) / 3.0;
|
||||
break;
|
||||
case PRICE_WEIGHTED:
|
||||
for(int i = 0; i < rates_total; i++)
|
||||
m_price[i] = (ha_high[i] + ha_low[i] + 2 * ha_close[i]) / 4.0;
|
||||
break;
|
||||
default: // PRICE_CLOSE
|
||||
ArrayCopy(m_price, ha_close, 0, 0, rates_total);
|
||||
break;
|
||||
ArrayResize(m_ha_open, rates_total);
|
||||
ArrayResize(m_ha_high, rates_total);
|
||||
ArrayResize(m_ha_low, rates_total);
|
||||
ArrayResize(m_ha_close, rates_total);
|
||||
}
|
||||
|
||||
//--- STRICT CALL: Use the optimized 10-param HA calculation
|
||||
m_ha_calculator.Calculate(rates_total, start_index, open, high, low, close,
|
||||
m_ha_open, m_ha_high, m_ha_low, m_ha_close);
|
||||
|
||||
//--- Copy to m_price (Optimized loop)
|
||||
for(int i = start_index; i < rates_total; i++)
|
||||
{
|
||||
switch(price_type)
|
||||
{
|
||||
case PRICE_CLOSE:
|
||||
m_price[i] = m_ha_close[i];
|
||||
break;
|
||||
case PRICE_OPEN:
|
||||
m_price[i] = m_ha_open[i];
|
||||
break;
|
||||
case PRICE_HIGH:
|
||||
m_price[i] = m_ha_high[i];
|
||||
break;
|
||||
case PRICE_LOW:
|
||||
m_price[i] = m_ha_low[i];
|
||||
break;
|
||||
case PRICE_MEDIAN:
|
||||
m_price[i] = (m_ha_high[i]+m_ha_low[i])/2.0;
|
||||
break;
|
||||
case PRICE_TYPICAL:
|
||||
m_price[i] = (m_ha_high[i]+m_ha_low[i]+m_ha_close[i])/3.0;
|
||||
break;
|
||||
case PRICE_WEIGHTED:
|
||||
m_price[i] = (m_ha_high[i]+m_ha_low[i]+2*m_ha_close[i])/4.0;
|
||||
break;
|
||||
default:
|
||||
m_price[i] = m_ha_close[i];
|
||||
break;
|
||||
}
|
||||
}
|
||||
return true;
|
||||
}
|
||||
//+------------------------------------------------------------------+
|
||||
//+------------------------------------------------------------------+
|
||||
|
||||
Reference in New Issue
Block a user