Enhance code quality and stability across various modules

- Updated .coderabbit.yaml to exclude additional file types from reviews, improving the focus on relevant code changes.
- Modified scanner.sh to handle test failures more gracefully, ensuring that analysis stops on test failures and improving logging.
- Improved sonarscanner.sh to ensure build and test failures are properly reported, enhancing CI reliability.
- Refined SimdExtensions.cs documentation for clarity on variance calculation methods.
- Cleaned up TSeries.Tests.cs by simplifying the test structure and ensuring proper namespace usage.
- Fixed potential issues in tseries.cs by ensuring correct handling of DateTime values.
- Enhanced CsvFeed.cs to improve error handling during CSV parsing, ensuring robustness against malformed data.
- Updated GBM.cs to correctly calculate volume in the current bar, ensuring accurate simulation.
- Adjusted index.html to use globalThis for better compatibility across environments.
- Refined quantalib.csproj to exclude unnecessary files from compilation, streamlining the build process.
- Added comprehensive tests for the Mama class to ensure correct behavior during updates and state management.
- Improved error handling in various trend classes (Kama, Dema, Ema, T3, Tema, Wma) to ensure NaN values are managed correctly.
- Removed redundant Mama.Repro.Tests.cs file and consolidated tests into Mama.Tests.cs for better organization.
- Enhanced T3 and Tema classes to maintain state integrity during updates, particularly with NaN values.
This commit is contained in:
Miha Kralj
2025-12-10 14:51:58 -05:00
parent 7a4850956b
commit b26d5d7751
27 changed files with 260 additions and 136 deletions
+45 -8
View File
@@ -119,8 +119,16 @@ if [ "$SKIP_BUILD" = false ]; then
dotnet build /p:DisableGitVersionTask=true /p:Version=0.0.0-wsl /p:AssemblyVersion=0.0.0.0 /p:FileVersion=0.0.0.0
log_info "Running tests with coverage..."
set +e
dotnet test --no-build --collect:"XPlat Code Coverage" \
-- DataCollectionRunSettings.DataCollectors.DataCollector.Configuration.Format=opencover,lcov || true
-- DataCollectionRunSettings.DataCollectors.DataCollector.Configuration.Format=opencover,lcov
TEST_EXIT_CODE=$?
set -e
if [ $TEST_EXIT_CODE -ne 0 ]; then
log_error "Tests failed with exit code $TEST_EXIT_CODE. Stopping analysis."
exit $TEST_EXIT_CODE
fi
# Copy coverage files to Qodana directory and convert Windows paths to Linux
log_info "Copying coverage files for Qodana..."
@@ -175,18 +183,38 @@ if [ "$SKIP_CODACY" = false ]; then
log_info "Uploading coverage to Codacy..."
# Find the most recent coverage files (one per test project)
coverage_files=$(find . -name "coverage.opencover.xml" -type f -printf '%T@ %p\n' | sort -rn | head -2 | cut -d' ' -f2-)
mapfile -t coverage_files < <(find . -name "coverage.opencover.xml" -type f -printf '%T@ %p\n' | sort -rn | head -2 | cut -d' ' -f2-)
if [ -n "$coverage_files" ]; then
for file in $coverage_files; do
if [ ${#coverage_files[@]} -gt 0 ]; then
# Download and verify Codacy reporter
CODACY_VERSION="14.1.0"
CODACY_SHA256="f1db13a9b21a9d161ddfeadf0cf6a65ffb0e9eaae8c314d3d14502946ee08475"
CODACY_URL="https://github.com/codacy/codacy-coverage-reporter/releases/download/${CODACY_VERSION}/codacy-coverage-reporter-linux"
CODACY_BIN="/tmp/codacy-coverage-reporter"
log_info "Downloading Codacy coverage reporter v${CODACY_VERSION}..."
curl -L -o "$CODACY_BIN" "$CODACY_URL"
# Verify hash
echo "$CODACY_SHA256 $CODACY_BIN" | sha256sum -c -
if [ $? -ne 0 ]; then
log_error "Codacy reporter checksum verification failed!"
rm -f "$CODACY_BIN"
exit 1
fi
chmod +x "$CODACY_BIN"
for file in "${coverage_files[@]}"; do
log_detail "Uploading: $file"
bash <(curl -Ls https://coverage.codacy.com/get.sh) report -r "$file" --partial || true
"$CODACY_BIN" report -r "$file" --partial || true
done
# Send final notification
log_detail "Finalizing coverage report..."
bash <(curl -Ls https://coverage.codacy.com/get.sh) final || true
"$CODACY_BIN" final || true
rm -f "$CODACY_BIN"
log_success "Codacy: https://app.codacy.com/gh/mihakralj/QuanTAlib/dashboard"
else
log_warn "No coverage.opencover.xml files found"
@@ -201,12 +229,21 @@ if [ "$SKIP_QODANA" = false ]; then
log_info "Starting Qodana analysis..."
# Install dependencies required for Qodana (IntelliJ) on minimal Debian
# Note: CI environments must run as root or have passwordless sudo configured
if ! dpkg -s libfreetype6 fontconfig &> /dev/null; then
log_info "Installing missing dependencies (libfreetype6, fontconfig)..."
if [ "$EUID" -ne 0 ]; then
sudo apt-get update && sudo apt-get install -y libfreetype6 fontconfig
# Use sudo -n to fail fast if password is required
if ! sudo -n apt-get update || ! sudo -n DEBIAN_FRONTEND=noninteractive apt-get install -y libfreetype6 fontconfig; then
log_error "Dependency installation failed. Ensure passwordless sudo is configured."
exit 1
fi
else
apt-get update && apt-get install -y libfreetype6 fontconfig
if ! apt-get update || ! DEBIAN_FRONTEND=noninteractive apt-get install -y libfreetype6 fontconfig; then
log_error "Dependency installation failed."
exit 1
fi
fi
fi
+8 -1
View File
@@ -28,12 +28,19 @@ dotnet sonarscanner begin \
echo "==> Building solution..."
dotnet build --no-incremental
if [ $? -ne 0 ]; then
echo "Error: Build failed"
exit 1
fi
echo "==> Running tests with coverage..."
mkdir -p "$COVERAGE_DIR"
# Run tests with both formats if possible, or sequentially
dotnet test --no-build --collect:"XPlat Code Coverage" \
-- DataCollectionRunSettings.DataCollectors.DataCollector.Configuration.Format=lcov,opencover
if [ $? -ne 0 ]; then
echo "Error: Tests failed"
exit 1
fi
# Copy coverage to Qodana directory
find . -name "coverage.info" -exec cp {} "$COVERAGE_DIR/" \;