semver fix

.github/workflows/Publish.yml

@@ -194,7 +194,7 @@ jobs:
           languages: 'csharp'
           queries: security-and-quality
           config-file: ./.github/codeql/codeql-config.yml
-          tools: latest
+          tools: linked
 
       - name: Restore dependencies
         run: dotnet restore
@@ -263,13 +263,6 @@ jobs:
         with:
           dotnet-version: ${{ env.DOTNET_VERSION }}
 
-      - name: Cache NuGet packages
-        uses: actions/cache@v4
-        with:
-          path: ~/.nuget/packages
-          key: ${{ runner.os }}-nuget-${{ hashFiles('**/*.csproj') }}
-          restore-keys: ${{ runner.os }}-nuget-
-
       - name: Install GitVersion
         uses: gittools/actions/gitversion/setup@v0
         with:
@@ -281,12 +274,19 @@ jobs:
         uses: gittools/actions/gitversion/execute@v0
         with:
           useConfigFile: true
-          updateAssemblyInfo: true
+          updateAssemblyInfo: false
+
+      - name: Cache NuGet packages
+        uses: actions/cache@v4
+        with:
+          path: ~/.nuget/packages
+          key: ${{ runner.os }}-nuget-${{ hashFiles('**/*.csproj') }}
+          restore-keys: ${{ runner.os }}-nuget-
 
       - name: Build projects
         run: |
-          dotnet build ./lib/quantalib.csproj --configuration Release --nologo \
-            -p:PackageVersion=${{ steps.gitversion.outputs.MajorMinorPatch }}
+          dotnet restore
+          dotnet build ./lib/quantalib.csproj --configuration Release --nologo
           dotnet build ./quantower/Averages/_Averages.csproj --configuration Release --nologo
           dotnet build ./quantower/Statistics/_Statistics.csproj --configuration Release --nologo
           dotnet build ./quantower/Volatility/_Volatility.csproj --configuration Release --nologo
@@ -325,8 +325,8 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
           gh release create v${{ steps.gitversion.outputs.MajorMinorPatch }} \
-            --title "Release ${{ steps.gitversion.outputs.MajorMinorPatch }}" \
-            --notes "Release notes for version ${{ steps.gitversion.outputs.MajorMinorPatch }}" \
+            --title "Release from commit ${{ steps.gitversion.outputs.MajorMinorPatch }}" \
+            --notes "Release notes for this version." \
             quantower/Averages/bin/Release/Averages.dll \
             quantower/Statistics/bin/Release/Statistics.dll \
             quantower/Volatility/bin/Release/Volatility.dll \

Directory.Build.props

@@ -20,9 +20,6 @@
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <PlatformTarget>AnyCPU</PlatformTarget>
     <IsLocalBuild Condition="'$(GITHUB_ACTIONS)' == ''">true</IsLocalBuild>
-    <GenerateAssemblyInfo>true</GenerateAssemblyInfo>
-    <UpdateAssemblyInfo>true</UpdateAssemblyInfo>
-    <GenerateGitVersionInformation>true</GenerateGitVersionInformation>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)' == 'Release'">
@@ -31,11 +28,11 @@
     <PublishAot>true</PublishAot>
     <PublishReadyToRun>true</PublishReadyToRun>
     <TieredCompilation>true</TieredCompilation>
-    <DebugType>none</DebugType>
+    <DebugType>portable</DebugType>
     <Optimize>true</Optimize>
     <EnableCompressionInSingleFile>true</EnableCompressionInSingleFile>
     <PublishSingleFile>true</PublishSingleFile>
-    <DebugSymbols>false</DebugSymbols>
+    <DebugSymbols>true</DebugSymbols>
     <Deterministic>true</Deterministic>
     <EnableUnsafeBinaryFormatterSerialization>false</EnableUnsafeBinaryFormatterSerialization>
     <EnableUnsafeUTF7Encoding>false</EnableUnsafeUTF7Encoding>
@@ -45,13 +42,14 @@
     <MetadataUpdaterSupport>false</MetadataUpdaterSupport>
     <UseSystemResourceKeys>true</UseSystemResourceKeys>
   </PropertyGroup>
-    <PropertyGroup>
+
+  <PropertyGroup>
     <NoWarn>S1944,S2053,S2222,S2259,S2583,S2589,S3329,S3655,S3900,S3949,S3966,S4158,S4347,S5773,S6781</NoWarn>
   </PropertyGroup>
+
   <ItemGroup>
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All"/>
     <PackageReference Include="Microsoft.DotNet.Interactive.Formatting" Version="1.0.0-beta.21459.1" />
-    <PackageReference Include="GitVersion.MsBuild" Version="6.0.0-beta.7" PrivateAssets="All" />
   </ItemGroup>
 
   <PropertyGroup Condition="'$(IsLocalBuild)' == 'true' AND $([MSBuild]::IsOSPlatform('Windows'))">

GitVersion.yml

@@ -1,18 +1,39 @@
-next-version: 0.6.1
-mode: ContinuousDelivery
+workflow: GitHubFlow/v1
+assembly-versioning-scheme: MajorMinorPatch
+assembly-file-versioning-scheme: MajorMinorPatch
 major-version-bump-message: '\+semver:\s?(breaking|major)'
 minor-version-bump-message: '\+semver:\s?(feature|minor)'
 patch-version-bump-message: '\+semver:\s?(fix|patch)'
 no-bump-message: '\+semver:\s?(none|skip)'
+tag-prefix: '[vV]'
+semantic-version-format: Strict
+
 branches:
   main:
+    label: ''
     regex: ^main$
+    mode: ContinuousDeployment
+    increment: Patch
+    prevent-increment:
+      of-merged-branch: true
+    track-merge-target: false
+    track-merge-message: true
+    is-release-branch: true
+    pre-release-weight: 0
+
+
+  dev:
+    label: beta
+    regex: ^dev(elop)?(ment)?$
     mode: ContinuousDelivery
     increment: Patch
-  dev:
-    regex: ^dev(elop)?(ment)?$
-    mode: ContinuousDeployment
-    increment: Inherit
+    prevent-increment:
+      when-current-commit-tagged: false
+    track-merge-target: true
+    is-release-branch: false
+    source-branches: ['main']
+    pre-release-weight: 30000
+
 ignore:
   sha: []
 merge-message-formats: {}

lib/oscillators/Stc.cs

@@ -62,8 +62,28 @@ public sealed class Stc : AbstractBase
                int slowPeriod = DefaultSlowPeriod, int d1Period = DefaultD1Period,
                int stcPeriod = DefaultStcPeriod)
     {
-        if (cyclePeriod < 1 || fastPeriod < 1 || slowPeriod < 1 || d1Period < 1 || stcPeriod < 1)
-            throw new ArgumentOutOfRangeException(nameof(cyclePeriod), "All periods must be greater than 0");
+        string err = "All periods must be greater than 0";
+
+        if (cyclePeriod < 1)
+        {
+            throw new ArgumentOutOfRangeException(nameof(cyclePeriod), err);
+        }
+        if (fastPeriod < 1)
+        {
+            throw new ArgumentOutOfRangeException(nameof(fastPeriod), err);
+        }
+        if (slowPeriod < 1)
+        {
+            throw new ArgumentOutOfRangeException(nameof(slowPeriod), err);
+        }
+        if (d1Period < 1)
+        {
+            throw new ArgumentOutOfRangeException(nameof(d1Period), err);
+        }
+        if (stcPeriod < 1)
+        {
+            throw new ArgumentOutOfRangeException(nameof(stcPeriod), err);
+        }
         if (fastPeriod >= slowPeriod)
         {
             throw new ArgumentOutOfRangeException(nameof(fastPeriod), "Fast period must be less than slow period");

lib/quantalib.csproj

@@ -10,8 +10,8 @@
     <PackageReadmeFile>readme.md</PackageReadmeFile>
     <RootNamespace>QuanTAlib</RootNamespace>
     <AssemblyName>QuanTAlib</AssemblyName>
-    <IsPublishable>True</IsPublishable>
-    <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
+    <IsPublishable>true</IsPublishable>
+    <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <PackageIcon>QuanTAlib2.png</PackageIcon>
     <PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
     <PackageTags>
@@ -25,6 +25,7 @@
   </PropertyGroup>
 
   <ItemGroup>
+    <PackageReference Include="GitVersion.MsBuild" Version="6.0.4" PrivateAssets="All" />
     <Compile Include="**\*.cs" Exclude="obj\**\*.cs" />
   </ItemGroup>