gavindiaz/NexQuant
1
0
Fork 0
mirror of https://github.com/NicolasBohn/NexQuant.git synced 2026-07-27 15:37:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: add configurable volume mode for Docker volumes in env.py (#537)

Browse Source 
* feat: Add configurable volume mode for Docker volumes in env.py

* fix: Change default extra_volume_mode to read-only in DockerConf
This commit is contained in:
you-n-g
2025-01-24 14:08:38 +08:00
committed by GitHub
parent 6ec56a3f6c
commit 92bc51bf42
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rdagent/utils/env.py
+3 -2
View File
@@ -134,6 +134,7 @@ class DockerConf(ExtendedBaseSettings):
default_entry: str # the entry point of the image
extra_volumes: dict = {}
extra_volume_mode: str = "ro" # by default. only the mount_path should be writable, others are changed to read-only
# Sometime, we need maintain some extra data for the workspace.
# And the extra data may be shared and the downloading can be time consuming.
# So we just want to download it once.
@@ -345,10 +346,10 @@ class DockerEnv(Env[DockerConf]):
volumns[local_path] = {"bind": self.conf.mount_path, "mode": "rw"}
if self.conf.extra_volumes is not None:
for lp, rp in self.conf.extra_volumes.items():
volumns[lp] = {"bind": rp, "mode": "rw"}
volumns[lp] = {"bind": rp, "mode": self.conf.extra_volume_mode}
if running_extra_volume is not None:
for lp, rp in running_extra_volume.items():
volumns[lp] = {"bind": rp, "mode": "rw"}
volumns[lp] = {"bind": rp, "mode": self.conf.extra_volume_mode}
log_output = ""