Files
wickra/bindings/r/tests/testthat/test-golden-all.R
T
kingchencandGitHub 4f708d410d test: golden-pin the four de-duplicated indicators across all bindings (#305)
* test: golden-pin the four de-duplicated indicators across all C-ABI bindings

Extend gen_golden to emit reference fixtures for AdOscillator (ADOSC),
IntradayIntensity, AwesomeOscillatorHistogram and AverageDrawdown, and replay
them through the Go / C# / Java / R golden harnesses so their corrected
definitions stay bit-identical to the Rust core in every binding. Go suite
verified locally (gcc 13 + cgo): all 9 golden tests pass; C#/Java/R use the
same fixtures and harness pattern (CI-verified). First step of extending the
golden coverage beyond the seven archetype representatives.

* test: golden-pin the scalar-output tranche (308 indicators) against Rust

Extend gen_golden with a generated emit_scalar that writes reference fixtures
for every single-f64-output indicator (scalar / candle / pairwise input) using
valid constructor params, and add a manifest-driven generic Python golden
replay that reconstructs each by its native name and checks it bit-for-bit
against the Rust output. 308 indicators now value-tied to the Rust core in
Python (pytest: 308/308). Takes golden coverage from the 7 archetype
representatives to 308+ of the catalogue.

22 scalar indicators with non-default constructor constraints are skipped by
gen_golden for now (logged), as are non-f64-output ones; multi-output, exotic
inputs and the per-indicator arg arities of the C-ABI/Node replays follow.
Generated + verified locally with the full toolchain.

* test: golden-pin the multi-output tranche (70 indicators) in Python

Add a generated emit_multi to gen_golden (per-indicator Output-field access,
one CSV column per field) and a manifest-driven generic Python replay that
checks every field of each multi-output indicator against the Rust reference.
70 multi-output indicators now value-tied to Rust in Python; combined with the
scalar tranche, 378 indicators are golden-pinned. 8 multi with non-default
param constraints and 5 with non-f64 Output fields (Option/Vec/i64) are
deferred. pytest green.

* test(golden): add 30 constraint-tuned indicators to scalar/multi golden suite

Emit golden fixtures for 22 scalar-output and 8 multi-output indicators
whose constructors need non-default parameters (Alma, Jma, Psar, T3, Mama,
DoubleBollinger, ZigZag, ...). All 408 fixtures replay bit-for-bit through
the Python binding.

* test(golden): cover 36 missed scalar/multi indicators

Add 26 single-output (LinearRegression family, HT cycle, Candle
volatility estimators, DrawdownDuration) and 10 multi-output
(BollingerBands, MACD/MACDEXT/MACDFIX, Camarilla, VWAP bands, ...)
indicators to the golden suite. 444 fixtures replay bit-for-bit
through the Python binding.

* test(golden): cover 50 exotic-input indicators

Add deterministic synthetic feeders for the DerivativesTick (17),
CrossSection (15), Trade (8), TradeQuote (3) and OrderBook (7)
families, derived from the shared OHLCV input series in both
gen_golden and a new Python replay harness (test_golden_exotic).
All 494 fixtures replay bit-for-bit through the Python binding.

* test(golden): complete 514-indicator golden coverage

Add the final tranches: 3 mixed multi-output indicators (Ichimoku,
WilliamsFractals, LeadLagCrossCorrelation), 6 histogram profiles
(time/volume seasonality + TPO/volume price profiles), 10 alt-chart
bar builders and the footprint. Every one of the 514 distinct
indicators now has a Rust-generated g_<Canonical>.csv fixture and a
generic Python replay (scalar/multi/exotic/profile/bars), all passing
bit-for-bit.

* test(golden): add generic Node replay for all 514 indicators

A manifest-driven node:test harness reconstructs every indicator by its
native class, feeds the same synthetic stream derived from the shared
golden input, and checks output bit-for-bit against the Rust reference
fixtures (scalar/multi/exotic/profile/bars). node_manifest.json is
generated from index.d.ts plus the Python-side manifests. 514/514 pass.

* test(golden): add generated Go replay for all 514 indicators

golden_all_test.go (generated by gen_golden_test.py) reconstructs every
Go indicator, feeds the shared synthetic stream and checks output
bit-for-bit against the Rust reference fixtures. A reflection-based
comparator flattens multi-output structs, profiles and bar slices so one
path covers all archetypes. This is the first C-ABI binding verified
across the full catalogue. 514/514 pass.

* test(golden): add generated C# replay for all 514 indicators

GoldenAllTests.g.cs (generated by gen_golden_test.py) reconstructs every
C# indicator, feeds the shared synthetic stream and checks output
bit-for-bit against the Rust reference fixtures via a reflection-based
flatten covering scalar/multi/profile/bar archetypes. 514/514 pass.

Also add the '#nullable enable' directive the compiler requires to the
generated Indicators.g.cs, clearing the four CS8669 warnings on the
nullable double[] profile return types.

* fix(java): marshal C ABI bool params correctly; add 514 golden replay

The Java FFM binding marshalled the cross-section state flags (newHigh,
newLow, aboveMa, onBuySignal) as JAVA_DOUBLE arrays, but the C ABI takes
them as const bool* (one byte each), so the native side read the low byte
of each 8-byte double and saw every flag as false. Add WickraNative.
boolSegment and use it across the 15 cross-section indicators. Also pass
the MacdExt MaType arguments as byte to match the uint8_t downcall
descriptor (was int, throwing WrongMethodTypeException).

Add GoldenAllTest.java (generated by gen_golden_test.py): a reflection
runner replaying all 514 indicators against the Rust reference fixtures.
The bugs above were found by this test; 514/514 now pass.

* fix(r): marshal C ABI bool flags correctly; add 514 golden replay

The R wrapper passed the cross-section state flags as (bool *)REAL(x),
reinterpreting the 8-byte doubles as 1-byte bools so the native side read
every flag as false. Add wk_bool_vec to convert each flag vector into a
real C bool buffer and use it for all 15 cross-section update wrappers.

Add test-golden-all.R + generated golden_specs.R: a reflective runner
replaying all 514 indicators against the Rust reference fixtures. The bug
above was found by this test; verified 514/514 pass locally.

* test(golden): add WASM replay for all 514 indicators

A manifest-driven node:test harness loads the nodejs-target wasm-pack
build, reconstructs every indicator by its JS class, feeds the shared
synthetic stream and checks output bit-for-bit against the Rust
reference fixtures. wasm_manifest.json is generated from the wasm .d.ts
plus the shared manifests; a recursive flattener covers scalar, multi
(Reflect objects), profile and bar shapes. 514/514 pass locally
(wasm-pack build --target nodejs, then node --test).

* test(golden): add C and C++ replay for all 514 indicators

golden_test.c (generated by gen_golden_test.py) drives every indicator
through the C ABI (wickra.h) and checks output bit-for-bit against the
Rust reference fixtures. golden_test.cpp #includes the same source so the
identical runner is compiled and run under both gcc (C) and g++ (C++) via
the CMake targets golden_test / golden_test_cpp — proving the extern "C"
header is consumable from each language. Both 514/514 (verified via ctest).

* test(golden): gofmt the generated Go golden replay

* test(golden): make the Node fixture reader CRLF-safe and pin fixtures to LF
2026-06-15 04:48:51 +02:00

122 lines
4.9 KiB
R

# Generic golden-fixture parity for the whole 514-indicator catalogue: every
# indicator is reconstructed by its constructor, fed the synthetic stream derived
# from the shared testdata/golden input (identical to gen_golden's Rust
# construction) and checked bit-for-bit against g_<Canonical>.csv. One reflective
# runner flattens scalar, multi-output, profile and bar shapes.
#
# Like test-golden.R, the fixtures live at the repo root and are not bundled into
# the standalone package, so packaged checks (r-universe / CRAN) skip; the parity
# is enforced by the monorepo CI. Specs are generated by gen_golden_test.py.
find_golden_dir_all <- function() {
d <- normalizePath(getwd(), winslash = "/", mustWork = FALSE)
repeat {
g <- file.path(d, "testdata", "golden")
if (dir.exists(g)) return(g)
parent <- dirname(d)
if (identical(parent, d)) return(NULL)
d <- parent
}
}
golden_dir_all <- find_golden_dir_all()
test_that("all 514 indicators match the Rust golden fixtures", {
skip_if(is.null(golden_dir_all), "golden fixtures not bundled with the package")
source(test_path("golden_specs.R"), local = TRUE)
gcell <- function(s) {
if (s == "nan") NA_real_ else if (s == "inf") Inf else if (s == "-inf") -Inf else as.numeric(s)
}
read_rows <- function(name) {
lines <- readLines(file.path(golden_dir_all, paste0(name, ".csv")))[-1]
lapply(lines, function(l) {
if (nchar(l) == 0) return(numeric(0))
vapply(strsplit(l, ",", fixed = TRUE)[[1]], gcell, numeric(1), USE.NAMES = FALSE)
})
}
input_rows <- lapply(
readLines(file.path(golden_dir_all, "input.csv"))[-1],
function(l) as.numeric(strsplit(l, ",", fixed = TRUE)[[1]])
)
deriv_fields <- function(r) {
o <- r[1]; h <- r[2]; l <- r[3]; c <- r[4]; v <- r[5]
c((c - o) / c * 0.01, c, c - 0.5, c + 1.0, v * 10, v * 0.6, v * 0.4,
v * 0.55, v * 0.45, h - c, c - l)
}
cross_lists <- function(r) {
o <- r[1]; c <- r[4]; v <- r[5]; j <- 0:4
list(change = (c - o) + j, volume = v + j * 10,
newHigh = as.numeric(j %% 2 == 0), newLow = as.numeric(j %% 3 == 0),
aboveMa = as.numeric(j %% 2 == 0), onBuy = as.numeric(j %% 3 == 0))
}
ob_lists <- function(r) {
c <- r[4]; v <- r[5]; k <- 1:5
list(bp = c - 0.1 * k, bs = v / k, ap = c + 0.1 * k, asz = v * 0.9 / k)
}
flatten <- function(o, arch, width) {
if (arch %in% c("profile_bins")) {
if (is.null(o) || length(o) == 0 || all(is.na(o))) return(rep(NA_real_, width))
return(as.numeric(o))
}
if (arch == "profile_pricebins") {
if (is.list(o)) return(c(o$price_low, o$price_high, as.numeric(o$values)))
return(rep(NA_real_, width))
}
if (arch %in% c("bars_close", "bars_candle4", "bars_candle5", "footprint")) {
if (is.null(o) || length(o) == 0) return(numeric(0))
if (is.matrix(o)) return(as.numeric(t(o)))
return(as.numeric(o))
}
as.numeric(o)
}
compute <- function(spec, ind, r, i) {
o <- r[1]; h <- r[2]; l <- r[3]; cl <- r[4]; v <- r[5]; ts <- as.integer(i - 1)
out <- switch(spec$arch,
scalar_f64 = update(ind, cl),
multi_f64 = update(ind, cl),
pairwise = , multi_pairwise = update(ind, cl, o),
scalar_candle = , multi_candle = , profile_bins = , profile_pricebins =
update(ind, o, h, l, cl, v, ts),
trade = update(ind, cl, v, cl >= o, ts),
trademid = update(ind, cl, v, cl >= o, ts, (h + l) / 2),
ob = { L <- ob_lists(r); update(ind, L$bp, L$bs, L$ap, L$asz) },
cross = { L <- cross_lists(r)
update(ind, L$change, L$volume, L$newHigh, L$newLow, L$aboveMa, L$onBuy, ts) },
deriv = , deriv_multi = { d <- deriv_fields(r)
do.call(update, c(list(ind), as.list(d), list(ts))) },
bars_close = update(ind, cl, cl, cl, cl, 1, 0L),
bars_candle4 = update(ind, o, h, l, cl, 1, 0L),
bars_candle5 = update(ind, o, h, l, cl, v, 0L),
footprint = update(ind, cl, v, cl >= o, ts),
stop("arch ", spec$arch)
)
flatten(out, spec$arch, spec$width)
}
for (spec in GOLDEN_SPECS) {
ind <- do.call(get(spec$canon), as.list(spec$params))
exp <- read_rows(paste0("g_", spec$canon))
for (i in seq_along(input_rows)) {
got <- compute(spec, ind, input_rows[[i]], i)
want <- exp[[i]]
expect_equal(length(got), length(want),
info = sprintf("%s row %d arity", spec$canon, i))
for (k in seq_along(want)) {
w <- want[k]; g <- got[k]
if (is.na(w)) {
expect_true(is.na(g), info = sprintf("%s row %d col %d: want NA", spec$canon, i, k))
} else if (is.infinite(w)) {
expect_true(is.infinite(g) && sign(g) == sign(w),
info = sprintf("%s row %d col %d: want %g", spec$canon, i, k, w))
} else {
expect_lte(abs(g - w), 1e-6 * max(1, abs(w)),
label = sprintf("%s row %d col %d (got %s want %g)", spec$canon, i, k, as.character(g), w))
}
}
}
}
})