Files
wickra/.github/PULL_REQUEST_TEMPLATE/detailed.md
T
kingchencandGitHub 23d636fd97 Add the Go binding over the C ABI hub (#228)
Adds a Go binding (`bindings/go`) over the C ABI hub — the second language stecker after C#.

## What's here
- **`bindings/go`** — a cgo binding exposing all 514 indicators as idiomatic Go types with `New<Indicator>` constructors and `Update`/`Batch`/`Reset`/`Close` methods. The wrappers in `indicators_gen.go` are generated from `bindings/c/include/wickra.h` (same archetype taxonomy as the C# generator: scalar/batch, multi-output, bars, profile, profile-values, array-input). Opaque handles are freed by `Close()` with a `runtime.SetFinalizer` backstop; pointer arguments are caller-owned, panics never cross the boundary.
- **`examples/go`** — the full example suite mirroring C/C#: streaming, backtest, multi_timeframe, parallel_assets (goroutine fan-out), three strategies, and `fetch_btcusdt`/`live_binance`.
- **CI** — a `go` job builds the C ABI library, stages it, and runs `gofmt`/`go vet`/`go test` plus the offline examples on Linux, macOS and Windows.
- **Docs** — Go added to the README languages table, project layout, building/testing, CONTRIBUTING binding table + regenerate note, ARCHITECTURE, examples index, issue/PR templates, the About-description template, and the other binding READMEs.

## Linking / distribution
The binding links the prebuilt C ABI library via cgo (`libwickra.so`/`.dylib`/`wickra.dll` staged under `bindings/go/lib`, gitignored). The native libraries are already shipped per target triple by the existing `c-abi-build` release job; distribution is via the subdirectory module tag `bindings/go/vX.Y.Z` (gated), so `release.yml` needs no new publish job.

No Rust crate or `Cargo.toml` change — the Go module is standalone and additive.

Not for merge yet (gated, per request).
2026-06-09 17:33:37 +02:00

2.2 KiB

Summary

Type of change

  • Bug fix (Non-breaking change which fixes an issue)
  • New feature (Non-breaking change which adds functionality)
  • Breaking change (Fix or feature that changes existing public API)
  • Performance improvement
  • Refactor (No functional change)
  • Documentation only
  • CI / build / tooling

Affected surfaces

  • Rust crate (crates/wickra)
  • Python binding (bindings/python)
  • Node.js binding (bindings/node)
  • WebAssembly binding (bindings/wasm)
  • C ABI (bindings/c)
  • C# / .NET binding (bindings/csharp)
  • Go binding (bindings/go)
  • Examples / docs

Linked issues

Closes #

How was this tested?

Numerical correctness (If you touched an indicator)

  • Output matches an existing reference (TA-Lib, paper, prior Wickra release) within documented tolerance
  • Streaming update() matches batch / from_slice output on the same input
  • Edge cases covered: empty input, single point, NaN, leading warm-up window

Performance impact (If applicable)

Benchmark Before After Δ

Checklist

  • cargo fmt --all and cargo clippy --all-targets -- -D warnings are clean
  • cargo test --workspace passes locally
  • Binding tests run (If a binding changed)
  • Public API changes are reflected in CHANGELOG.md
  • Public API changes are reflected in rustdoc / README / examples
  • No todo*.md or other local-only notes are staged
  • License header / LICENSE reference unchanged (MIT OR Apache-2.0)

Notes for reviewers