test(golden): language-neutral fixtures + per-binding parity runners (#255)

**Task 5 — golden-fixture parity for the C-ABI bindings.** Lifts the C#/Go/Java/R tests from *one indicator per archetype* toward reference-value parity, catching FFI wiring bugs (swapped params, wrong multi-output field) the math-only core tests cannot see.

## What's here
- **`examples/rust/src/bin/gen_golden.rs`** + **`testdata/golden/*.csv`** — a Rust generator computing a deterministic OHLCV series plus the core's reference outputs for a curated archetype-spanning set: scalar (`Sma`/`Ema`/`Rsi`), candle (`Atr`), scalar multi-output (`MACD`), candle multi-output (`ADX`), pairwise (`Beta`). `nan` marks warmup. Regenerate with `cargo run -p wickra-examples --bin gen_golden`.
- **Parity runners** replaying the identical fixtures through each FFI (rel-tol 1e-6), each a standard test in the binding's existing suite (no `ci.yml` change — rides `dotnet test` / `go test` / `mvn install` / `R CMD`+testthat). A walk-up search locates `testdata/golden` regardless of run dir.
  - **C#** (`bindings/csharp/.../GoldenTests.cs`) —  validated locally, 7/7 pass.
  - **Go** (`bindings/go/golden_test.go`) —  validated locally, pass.
  - **Java** (`bindings/java/.../GoldenTests.java`) — modeled on the archetype API; validated by CI (no local mvn).
  - **R** (`bindings/r/tests/testthat/test-golden.R`) — modeled on the archetype API; validated by CI (no local Rscript).

## Notes
- The curated set spans every marshalling archetype; extending the indicator list is mechanical (add to the generator + regenerate). Bars/profile archetypes can be added next.
- No new CI jobs.
This commit is contained in:
kingchenc
2026-06-11 15:22:29 +02:00
committed by GitHub
parent 395a2289f4
commit 8bfe24ac1d
13 changed files with 1397 additions and 0 deletions
+162
View File
@@ -0,0 +1,162 @@
using System.Globalization;
using System.Runtime.CompilerServices;
using Wickra;
using Xunit;
namespace Wickra.Tests;
/// <summary>
/// Golden-fixture parity: replay the shared <c>testdata/golden</c> input series
/// through the C# FFI and assert every value matches the Rust reference output.
/// Where the archetype tests only check finiteness, this pins exact values, so a
/// wiring bug (swapped parameter, wrong multi-output field) is caught.
/// Fixtures are generated by <c>cargo run -p wickra-examples --bin gen_golden</c>.
/// </summary>
public class GoldenTests
{
private const double Tol = 1e-6;
private static string GoldenDir([CallerFilePath] string file = "") =>
Path.GetFullPath(Path.Combine(Path.GetDirectoryName(file)!, "..", "..", "..", "testdata", "golden"));
private static List<string[]> ReadCsv(string name)
{
var path = Path.Combine(GoldenDir(), name + ".csv");
return File.ReadAllLines(path)
.Skip(1) // header
.Where(l => l.Length > 0)
.Select(l => l.Split(','))
.ToList();
}
private static double[][] Input()
{
return ReadCsv("input")
.Select(r => r.Select(c => double.Parse(c, CultureInfo.InvariantCulture)).ToArray())
.ToArray();
}
private static double Cell(string s) =>
s == "nan" ? double.NaN : double.Parse(s, CultureInfo.InvariantCulture);
private static void AssertClose(double got, double want, int row, string field)
{
if (double.IsNaN(want))
{
Assert.True(double.IsNaN(got), $"row {row} {field}: expected warmup/NaN, got {got}");
return;
}
var tol = Tol * Math.Max(1.0, Math.Abs(want));
Assert.True(Math.Abs(got - want) <= tol, $"row {row} {field}: got {got}, want {want}");
}
// --- scalar (close-driven) ------------------------------------------------
[Theory]
[InlineData("sma")]
[InlineData("ema")]
[InlineData("rsi")]
public void Scalar_MatchesGolden(string name)
{
var input = Input();
var expected = ReadCsv(name);
using var ind = (IDisposable)(name switch
{
"sma" => new Sma(14),
"ema" => new Ema(14),
"rsi" => new Rsi(14),
_ => throw new ArgumentOutOfRangeException(nameof(name)),
});
for (var i = 0; i < input.Length; i++)
{
var close = input[i][3];
double got = ind switch
{
Sma s => s.Update(close),
Ema e => e.Update(close),
Rsi r => r.Update(close),
_ => double.NaN,
};
AssertClose(got, Cell(expected[i][0]), i, name);
}
}
// --- candle, single output ------------------------------------------------
[Fact]
public void Candle_Atr_MatchesGolden()
{
var input = Input();
var expected = ReadCsv("atr");
using var atr = new Atr(14);
for (var i = 0; i < input.Length; i++)
{
var (o, h, l, c, v) = (input[i][0], input[i][1], input[i][2], input[i][3], input[i][4]);
AssertClose(atr.Update(o, h, l, c, v, i), Cell(expected[i][0]), i, "atr");
}
}
// --- pairwise -------------------------------------------------------------
[Fact]
public void Pairwise_Beta_MatchesGolden()
{
var input = Input();
var expected = ReadCsv("beta");
using var beta = new Beta(20);
for (var i = 0; i < input.Length; i++)
{
// generator fed (close, open)
AssertClose(beta.Update(input[i][3], input[i][0]), Cell(expected[i][0]), i, "beta");
}
}
// --- scalar multi-output: MACD -------------------------------------------
[Fact]
public void MultiOutput_Macd_MatchesGolden()
{
var input = Input();
var expected = ReadCsv("macd");
using var macd = new MacdIndicator(12, 26, 9);
for (var i = 0; i < input.Length; i++)
{
MacdOutput? got = macd.Update(input[i][3]);
var e = expected[i];
if (e[0] == "nan")
{
Assert.Null(got);
continue;
}
Assert.NotNull(got);
AssertClose(got!.Value.Macd, Cell(e[0]), i, "macd.macd");
AssertClose(got.Value.Signal, Cell(e[1]), i, "macd.signal");
AssertClose(got.Value.Histogram, Cell(e[2]), i, "macd.histogram");
}
}
// --- candle multi-output: ADX --------------------------------------------
[Fact]
public void MultiOutput_Adx_MatchesGolden()
{
var input = Input();
var expected = ReadCsv("adx");
using var adx = new Adx(14);
for (var i = 0; i < input.Length; i++)
{
var (o, h, l, c, v) = (input[i][0], input[i][1], input[i][2], input[i][3], input[i][4]);
AdxOutput? got = adx.Update(o, h, l, c, v, i);
var e = expected[i];
if (e[0] == "nan")
{
Assert.Null(got);
continue;
}
Assert.NotNull(got);
AssertClose(got!.Value.PlusDi, Cell(e[0]), i, "adx.plus_di");
AssertClose(got.Value.MinusDi, Cell(e[1]), i, "adx.minus_di");
AssertClose(got.Value.Adx, Cell(e[2]), i, "adx.adx");
}
}
}
+191
View File
@@ -0,0 +1,191 @@
package wickra
import (
"bufio"
"math"
"os"
"strconv"
"strings"
"testing"
)
// Golden-fixture parity: replay the shared testdata/golden input series through
// the Go FFI and assert every value matches the Rust reference output. Where the
// archetype test only checks finiteness, this pins exact values, catching wiring
// bugs (swapped params, wrong multi-output field). Fixtures are generated by
// `cargo run -p wickra-examples --bin gen_golden`.
const goldenTol = 1e-6
func readGolden(t *testing.T, name string) [][]string {
t.Helper()
f, err := os.Open("../../testdata/golden/" + name + ".csv")
if err != nil {
t.Fatalf("open %s: %v", name, err)
}
defer f.Close()
var rows [][]string
sc := bufio.NewScanner(f)
first := true
for sc.Scan() {
line := sc.Text()
if first {
first = false
continue
}
if line == "" {
continue
}
rows = append(rows, strings.Split(line, ","))
}
return rows
}
func goldenCell(s string) float64 {
if s == "nan" {
return math.NaN()
}
v, _ := strconv.ParseFloat(s, 64)
return v
}
func goldenInput(t *testing.T) [][]float64 {
rows := readGolden(t, "input")
out := make([][]float64, len(rows))
for i, r := range rows {
vals := make([]float64, len(r))
for j, c := range r {
vals[j] = goldenCell(c)
}
out[i] = vals
}
return out
}
func assertGoldenClose(t *testing.T, got, want float64, row int, field string) {
t.Helper()
if math.IsNaN(want) {
if !math.IsNaN(got) {
t.Errorf("row %d %s: expected warmup/NaN, got %v", row, field, got)
}
return
}
tol := goldenTol * math.Max(1.0, math.Abs(want))
if math.Abs(got-want) > tol {
t.Errorf("row %d %s: got %v want %v", row, field, got, want)
}
}
func TestGoldenScalar(t *testing.T) {
input := goldenInput(t)
sma, err := NewSma(14)
if err != nil {
t.Fatal(err)
}
defer sma.Close()
ema, err := NewEma(14)
if err != nil {
t.Fatal(err)
}
defer ema.Close()
rsi, err := NewRsi(14)
if err != nil {
t.Fatal(err)
}
defer rsi.Close()
cases := []struct {
name string
upd func(close float64) float64
}{
{"sma", sma.Update},
{"ema", ema.Update},
{"rsi", rsi.Update},
}
for _, tc := range cases {
exp := readGolden(t, tc.name)
for i := range input {
assertGoldenClose(t, tc.upd(input[i][3]), goldenCell(exp[i][0]), i, tc.name)
}
}
}
func TestGoldenAtr(t *testing.T) {
input := goldenInput(t)
exp := readGolden(t, "atr")
atr, err := NewAtr(14)
if err != nil {
t.Fatal(err)
}
defer atr.Close()
for i := range input {
got := atr.Update(input[i][0], input[i][1], input[i][2], input[i][3], input[i][4], int64(i))
assertGoldenClose(t, got, goldenCell(exp[i][0]), i, "atr")
}
}
func TestGoldenBeta(t *testing.T) {
input := goldenInput(t)
exp := readGolden(t, "beta")
beta, err := NewBeta(20)
if err != nil {
t.Fatal(err)
}
defer beta.Close()
for i := range input {
// generator fed (close, open)
assertGoldenClose(t, beta.Update(input[i][3], input[i][0]), goldenCell(exp[i][0]), i, "beta")
}
}
func TestGoldenMacd(t *testing.T) {
input := goldenInput(t)
exp := readGolden(t, "macd")
macd, err := NewMacdIndicator(12, 26, 9)
if err != nil {
t.Fatal(err)
}
defer macd.Close()
for i := range input {
out, ok := macd.Update(input[i][3])
if exp[i][0] == "nan" {
if ok {
t.Errorf("row %d macd: expected warmup, got %+v", i, out)
}
continue
}
if !ok {
t.Errorf("row %d macd: expected value, got warmup", i)
continue
}
assertGoldenClose(t, out.Macd, goldenCell(exp[i][0]), i, "macd.macd")
assertGoldenClose(t, out.Signal, goldenCell(exp[i][1]), i, "macd.signal")
assertGoldenClose(t, out.Histogram, goldenCell(exp[i][2]), i, "macd.histogram")
}
}
func TestGoldenAdx(t *testing.T) {
input := goldenInput(t)
exp := readGolden(t, "adx")
adx, err := NewAdx(14)
if err != nil {
t.Fatal(err)
}
defer adx.Close()
for i := range input {
out, ok := adx.Update(input[i][0], input[i][1], input[i][2], input[i][3], input[i][4], int64(i))
if exp[i][0] == "nan" {
if ok {
t.Errorf("row %d adx: expected warmup, got %+v", i, out)
}
continue
}
if !ok {
t.Errorf("row %d adx: expected value, got warmup", i)
continue
}
assertGoldenClose(t, out.PlusDi, goldenCell(exp[i][0]), i, "adx.plus_di")
assertGoldenClose(t, out.MinusDi, goldenCell(exp[i][1]), i, "adx.minus_di")
assertGoldenClose(t, out.Adx, goldenCell(exp[i][2]), i, "adx.adx")
}
}
@@ -0,0 +1,160 @@
package org.wickra;
import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
import java.io.File;
import java.nio.file.Files;
import java.nio.file.Path;
import java.util.ArrayList;
import java.util.List;
/**
* Golden-fixture parity: replay the shared {@code testdata/golden} input series
* through the Java FFI and assert every value matches the Rust reference output.
* Where the archetype tests only check finiteness, this pins exact values, so a
* wiring bug (swapped parameter, wrong multi-output field) is caught. Fixtures
* are generated by {@code cargo run -p wickra-examples --bin gen_golden}.
*/
class GoldenTests {
private static final double TOL = 1e-6;
private static Path goldenDir() {
File d = new File("").getAbsoluteFile();
while (d != null) {
File g = new File(d, "testdata/golden");
if (g.isDirectory()) {
return g.toPath();
}
d = d.getParentFile();
}
throw new IllegalStateException("testdata/golden not found from " + new File("").getAbsolutePath());
}
private static List<String[]> readCsv(String name) throws Exception {
List<String> lines = Files.readAllLines(goldenDir().resolve(name + ".csv"));
List<String[]> rows = new ArrayList<>();
for (int i = 1; i < lines.size(); i++) { // skip header
if (!lines.get(i).isEmpty()) {
rows.add(lines.get(i).split(","));
}
}
return rows;
}
private static double cell(String s) {
return s.equals("nan") ? Double.NaN : Double.parseDouble(s);
}
private static double[][] input() throws Exception {
List<String[]> rows = readCsv("input");
double[][] out = new double[rows.size()][];
for (int i = 0; i < rows.size(); i++) {
String[] r = rows.get(i);
double[] v = new double[r.length];
for (int j = 0; j < r.length; j++) {
v[j] = Double.parseDouble(r[j]);
}
out[i] = v;
}
return out;
}
private static void close(double got, double want, int row, String field) {
if (Double.isNaN(want)) {
assertTrue(Double.isNaN(got), "row " + row + " " + field + ": expected warmup/NaN, got " + got);
return;
}
double tol = TOL * Math.max(1.0, Math.abs(want));
assertTrue(Math.abs(got - want) <= tol, "row " + row + " " + field + ": got " + got + " want " + want);
}
@Test
void scalarMatchesGolden() throws Exception {
double[][] in = input();
try (Sma sma = new Sma(14)) {
List<String[]> e = readCsv("sma");
for (int i = 0; i < in.length; i++) {
close(sma.update(in[i][3]), cell(e.get(i)[0]), i, "sma");
}
}
try (Ema ema = new Ema(14)) {
List<String[]> e = readCsv("ema");
for (int i = 0; i < in.length; i++) {
close(ema.update(in[i][3]), cell(e.get(i)[0]), i, "ema");
}
}
try (Rsi rsi = new Rsi(14)) {
List<String[]> e = readCsv("rsi");
for (int i = 0; i < in.length; i++) {
close(rsi.update(in[i][3]), cell(e.get(i)[0]), i, "rsi");
}
}
}
@Test
void candleAtrMatchesGolden() throws Exception {
double[][] in = input();
List<String[]> e = readCsv("atr");
try (Atr atr = new Atr(14)) {
for (int i = 0; i < in.length; i++) {
close(atr.update(in[i][0], in[i][1], in[i][2], in[i][3], in[i][4], i), cell(e.get(i)[0]), i, "atr");
}
}
}
@Test
void pairwiseBetaMatchesGolden() throws Exception {
double[][] in = input();
List<String[]> e = readCsv("beta");
try (Beta beta = new Beta(20)) {
for (int i = 0; i < in.length; i++) {
// generator fed (close, open)
close(beta.update(in[i][3], in[i][0]), cell(e.get(i)[0]), i, "beta");
}
}
}
@Test
void macdMatchesGolden() throws Exception {
double[][] in = input();
List<String[]> e = readCsv("macd");
try (MacdIndicator macd = new MacdIndicator(12, 26, 9)) {
for (int i = 0; i < in.length; i++) {
MacdOutput o = macd.update(in[i][3]);
String[] row = e.get(i);
if (row[0].equals("nan")) {
assertNull(o, "row " + i + " macd: expected warmup");
continue;
}
assertNotNull(o, "row " + i + " macd: expected value");
close(o.macd(), cell(row[0]), i, "macd.macd");
close(o.signal(), cell(row[1]), i, "macd.signal");
close(o.histogram(), cell(row[2]), i, "macd.histogram");
}
}
}
@Test
void adxMatchesGolden() throws Exception {
double[][] in = input();
List<String[]> e = readCsv("adx");
try (Adx adx = new Adx(14)) {
for (int i = 0; i < in.length; i++) {
AdxOutput o = adx.update(in[i][0], in[i][1], in[i][2], in[i][3], in[i][4], i);
String[] row = e.get(i);
if (row[0].equals("nan")) {
assertNull(o, "row " + i + " adx: expected warmup");
continue;
}
assertNotNull(o, "row " + i + " adx: expected value");
close(o.plusDi(), cell(row[0]), i, "adx.plus_di");
close(o.minusDi(), cell(row[1]), i, "adx.minus_di");
close(o.adx(), cell(row[2]), i, "adx.adx");
}
}
}
}
+98
View File
@@ -0,0 +1,98 @@
# Golden-fixture parity: replay the shared testdata/golden input series through
# the R FFI and assert every value matches the Rust reference output. Where the
# archetype test only checks finiteness, this pins exact values, catching wiring
# bugs (swapped params, wrong multi-output field). Fixtures are generated by
# `cargo run -p wickra-examples --bin gen_golden`.
golden_dir <- local({
d <- normalizePath(getwd(), winslash = "/", mustWork = FALSE)
repeat {
g <- file.path(d, "testdata", "golden")
if (dir.exists(g)) return(g)
parent <- dirname(d)
if (identical(parent, d)) stop("testdata/golden not found from ", getwd())
d <- parent
}
})
read_golden <- function(name) {
read.csv(file.path(golden_dir, paste0(name, ".csv")),
colClasses = "character", check.names = FALSE)
}
gcell <- function(s) if (identical(s, "nan")) NA_real_ else as.numeric(s)
expect_close <- function(got, want, row, field) {
if (is.na(want)) {
expect_true(is.na(got), info = paste("row", row, field, "expected warmup/NA"))
} else {
tol <- 1e-6 * max(1, abs(want))
expect_lte(abs(got - want), tol, label = paste("row", row, field, "got", got, "want", want))
}
}
golden_input <- read.csv(file.path(golden_dir, "input.csv"))
test_that("scalar indicators match golden", {
specs <- list(c("sma", 14), c("ema", 14), c("rsi", 14))
for (spec in specs) {
name <- spec[[1]]
ind <- switch(name, sma = Sma(14), ema = Ema(14), rsi = Rsi(14))
exp <- read_golden(name)
for (i in seq_len(nrow(golden_input))) {
got <- update(ind, golden_input$close[i])
expect_close(got, gcell(exp[i, 1]), i, name)
}
}
})
test_that("candle Atr matches golden", {
atr <- Atr(14)
exp <- read_golden("atr")
for (i in seq_len(nrow(golden_input))) {
got <- update(atr, golden_input$open[i], golden_input$high[i], golden_input$low[i],
golden_input$close[i], golden_input$volume[i], i - 1)
expect_close(got, gcell(exp[i, 1]), i, "atr")
}
})
test_that("pairwise Beta matches golden", {
beta <- Beta(20)
exp <- read_golden("beta")
for (i in seq_len(nrow(golden_input))) {
# generator fed (close, open)
got <- update(beta, golden_input$close[i], golden_input$open[i])
expect_close(got, gcell(exp[i, 1]), i, "beta")
}
})
test_that("multi-output MACD matches golden", {
macd <- MacdIndicator(12, 26, 9)
exp <- read_golden("macd")
for (i in seq_len(nrow(golden_input))) {
out <- update(macd, golden_input$close[i])
if (identical(exp[i, "macd"], "nan")) {
expect_true(all(is.na(out)), info = paste("row", i, "macd warmup"))
} else {
expect_close(out[["macd"]], gcell(exp[i, "macd"]), i, "macd.macd")
expect_close(out[["signal"]], gcell(exp[i, "signal"]), i, "macd.signal")
expect_close(out[["histogram"]], gcell(exp[i, "histogram"]), i, "macd.histogram")
}
}
})
test_that("multi-output ADX matches golden", {
adx <- Adx(14)
exp <- read_golden("adx")
for (i in seq_len(nrow(golden_input))) {
out <- update(adx, golden_input$open[i], golden_input$high[i], golden_input$low[i],
golden_input$close[i], golden_input$volume[i], i - 1)
if (identical(exp[i, "plus_di"], "nan")) {
expect_true(all(is.na(out)), info = paste("row", i, "adx warmup"))
} else {
expect_close(out[["plus_di"]], gcell(exp[i, "plus_di"]), i, "adx.plus_di")
expect_close(out[["minus_di"]], gcell(exp[i, "minus_di"]), i, "adx.minus_di")
expect_close(out[["adx"]], gcell(exp[i, "adx"]), i, "adx.adx")
}
}
})