gavindiaz/rust-optimizer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: unify optimize and optimize_with via blanket Objective impl

Browse Source 
- Add blanket `impl Objective<V> for Fn(&mut Trial) -> Result<V, E>`
  so closures work directly with `optimize`
- Rewrite optimize, optimize_async, optimize_parallel to accept
  `impl Objective<V>` with before_trial/after_trial hooks
- Remove optimize_with, optimize_with_async, optimize_with_parallel
- Remove max_retries and retry logic from Objective trait
- Add explicit closure type annotations for HRTB inference
- Convert FnMut test closures to Fn via RefCell/Cell
This commit is contained in:
Manuel Raimann
2026-02-12 13:09:14 +01:00
parent c20a53dfba
commit 47b5f9cec8
41 changed files with 316 additions and 793 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/visualization_tests.rs
+6 -6
View File
@@ -9,7 +9,7 @@ fn html_report_creates_file() {
let y = IntParam::new(1, 5).name("y");
study
.optimize(10, |trial| {
.optimize(10, |trial: &mut optimizer::Trial| {
let xv = x.suggest(trial)?;
let yv = y.suggest(trial)?;
Ok::<_, optimizer::Error>(xv + yv as f64)
@@ -32,7 +32,7 @@ fn html_report_contains_all_chart_sections() {
let y = FloatParam::new(-5.0, 5.0).name("y");
study
.optimize(20, |trial| {
.optimize(20, |trial: &mut optimizer::Trial| {
let xv = x.suggest(trial)?;
let yv = y.suggest(trial)?;
Ok::<_, optimizer::Error>(xv * xv + yv * yv)
@@ -85,7 +85,7 @@ fn html_report_single_param_no_parcoords() {
let x = FloatParam::new(0.0, 10.0).name("x");
study
.optimize(5, |trial| {
.optimize(5, |trial: &mut optimizer::Trial| {
let xv = x.suggest(trial)?;
Ok::<_, optimizer::Error>(xv * xv)
})
@@ -109,7 +109,7 @@ fn html_report_maximize_direction() {
let x = FloatParam::new(0.0, 10.0).name("x");
study
.optimize(5, |trial| {
.optimize(5, |trial: &mut optimizer::Trial| {
let xv = x.suggest(trial)?;
Ok::<_, optimizer::Error>(xv)
})
@@ -130,7 +130,7 @@ fn export_html_convenience_method() {
let x = FloatParam::new(0.0, 10.0).name("x");
study
.optimize(5, |trial| {
.optimize(5, |trial: &mut optimizer::Trial| {
let xv = x.suggest(trial)?;
Ok::<_, optimizer::Error>(xv * xv)
})
@@ -156,7 +156,7 @@ fn html_report_with_intermediate_values() {
let x = FloatParam::new(0.0, 10.0).name("x");
study
.optimize(10, |trial| {
.optimize(10, |trial: &mut optimizer::Trial| {
let xv = x.suggest(trial)?;
for step in 0..5 {
let val = xv * xv + step as f64;