From 3420edee2b719d8229afea9199ef13dd5a4a27ba Mon Sep 17 00:00:00 2001 From: porcelaincode Date: Wed, 3 Jun 2026 21:28:00 +0530 Subject: [PATCH] fix(indicators): correct test_macd signal line warmup assertion signal_start = (slow_period-1) + (signal_period-1) = 24+8 = 32, so signal_line[33] is the first valid value, not NaN. Test was asserting [33].is_nan() which was always wrong. Co-Authored-By: porcelaincode --- src/indicators/momentum.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/indicators/momentum.rs b/src/indicators/momentum.rs index b351c5c..30ff934 100644 --- a/src/indicators/momentum.rs +++ b/src/indicators/momentum.rs @@ -276,9 +276,9 @@ mod tests { assert!(result.macd_line[24].is_nan()); assert!(!result.macd_line[25].is_nan()); - // Signal line should be valid later - assert!(result.signal_line[33].is_nan()); - assert!(!result.signal_line[34].is_nan()); + // Signal line starts at index slow_period-1 + signal_period-1 = 25+8 = 33 + assert!(result.signal_line[32].is_nan()); + assert!(!result.signal_line[33].is_nan()); } #[test]