fix: resolve major clippy warnings causing CI failures including unused doc comments, dead code, needless borrows, and assertion constants

This commit is contained in:
floor-licker
2025-12-04 07:26:38 -05:00
parent fe772c055a
commit 3742a5b864
7 changed files with 16 additions and 10 deletions
+2 -2
View File
@@ -26,7 +26,7 @@ const POLY_PASS_HEADER: &str = "poly_passphrase";
type Headers = HashMap<&'static str, String>; type Headers = HashMap<&'static str, String>;
/// EIP-712 struct for CLOB authentication // EIP-712 struct for CLOB authentication
sol! { sol! {
struct ClobAuth { struct ClobAuth {
address address; address address;
@@ -36,7 +36,7 @@ sol! {
} }
} }
/// EIP-712 struct for order signing // EIP-712 struct for order signing
sol! { sol! {
struct Order { struct Order {
uint256 salt; uint256 salt;
+2 -1
View File
@@ -392,6 +392,7 @@ impl OrderBook {
/// Otherwise, set the total size at this price level /// Otherwise, set the total size at this price level
/// ///
/// This converts to fixed-point and calls the fast version /// This converts to fixed-point and calls the fast version
#[allow(dead_code)]
fn apply_bid_delta(&mut self, price: Decimal, size: Decimal) { fn apply_bid_delta(&mut self, price: Decimal, size: Decimal) {
// Convert to fixed-point (this should be rare since we use fast path) // Convert to fixed-point (this should be rare since we use fast path)
let price_ticks = decimal_to_price(price).unwrap_or(0); let price_ticks = decimal_to_price(price).unwrap_or(0);
@@ -403,6 +404,7 @@ impl OrderBook {
/// Same logic as bids - size of 0 means remove the price level /// Same logic as bids - size of 0 means remove the price level
/// ///
/// This converts to fixed-point and calls the fast version /// This converts to fixed-point and calls the fast version
#[allow(dead_code)]
fn apply_ask_delta(&mut self, price: Decimal, size: Decimal) { fn apply_ask_delta(&mut self, price: Decimal, size: Decimal) {
// Convert to fixed-point (this should be rare since we use fast path) // Convert to fixed-point (this should be rare since we use fast path)
let price_ticks = decimal_to_price(price).unwrap_or(0); let price_ticks = decimal_to_price(price).unwrap_or(0);
@@ -461,7 +463,6 @@ impl OrderBook {
/// mostly noise and will never get hit in normal trading /// mostly noise and will never get hit in normal trading
/// 4. Stale data: Deep levels often contain old orders that haven't been cancelled /// 4. Stale data: Deep levels often contain old orders that haven't been cancelled
/// 5. Network bandwidth: Less data to send when streaming updates /// 5. Network bandwidth: Less data to send when streaming updates
fn trim_depth(&mut self) { fn trim_depth(&mut self) {
// For bids, remove the LOWEST prices (worst bids) if we have too many // For bids, remove the LOWEST prices (worst bids) if we have too many
// Example: If best bid is $0.65, we don't care about bids at $0.10 // Example: If best bid is $0.65, we don't care about bids at $0.10
+2 -2
View File
@@ -173,7 +173,7 @@ impl ClobClient {
/// Test basic connectivity /// Test basic connectivity
pub async fn get_ok(&self) -> bool { pub async fn get_ok(&self) -> bool {
match self.http_client.get(&format!("{}/ok", self.base_url)).send().await { match self.http_client.get(format!("{}/ok", self.base_url)).send().await {
Ok(response) => response.status().is_success(), Ok(response) => response.status().is_success(),
Err(_) => false, Err(_) => false,
} }
@@ -182,7 +182,7 @@ impl ClobClient {
/// Get server time /// Get server time
pub async fn get_server_time(&self) -> Result<u64> { pub async fn get_server_time(&self) -> Result<u64> {
let response = self.http_client let response = self.http_client
.get(&format!("{}/time", self.base_url)) .get(format!("{}/time", self.base_url))
.send() .send()
.await?; .await?;
+1 -1
View File
@@ -372,7 +372,7 @@ pub fn parse_stream_message(raw: &str) -> Result<StreamMessage> {
.as_str() .as_str()
.and_then(|s| chrono::DateTime::parse_from_rfc3339(s).ok()) .and_then(|s| chrono::DateTime::parse_from_rfc3339(s).ok())
.map(|dt| dt.with_timezone(&Utc)) .map(|dt| dt.with_timezone(&Utc))
.unwrap_or_else(|| Utc::now()); .unwrap_or_else(Utc::now);
Ok(StreamMessage::Heartbeat { timestamp }) Ok(StreamMessage::Heartbeat { timestamp })
} }
_ => Err(PolyfillError::parse( _ => Err(PolyfillError::parse(
+1 -1
View File
@@ -572,7 +572,7 @@ mod tests {
// Test basic properties exist (we can't access private fields directly) // Test basic properties exist (we can't access private fields directly)
// But we can test that the engine was created successfully // But we can test that the engine was created successfully
assert!(true); // Engine creation successful // Engine creation successful
} }
#[test] #[test]
+4 -3
View File
@@ -142,8 +142,9 @@ mod benches {
use chrono::Utc; use chrono::Utc;
use std::str::FromStr; use std::str::FromStr;
#[allow(dead_code)]
fn order_book_benchmark(c: &mut criterion::Criterion) { fn order_book_benchmark(c: &mut criterion::Criterion) {
let mut book_manager = OrderBookManager::new(100); let book_manager = OrderBookManager::new(100);
c.bench_function("apply_order_delta", |b| { c.bench_function("apply_order_delta", |b| {
b.iter(|| { b.iter(|| {
@@ -173,10 +174,10 @@ mod tests {
#[test] #[test]
fn test_client_creation() { fn test_client_creation() {
let client = ClobClient::new("https://test.example.com"); let _client = ClobClient::new("https://test.example.com");
// Test that the client was created successfully // Test that the client was created successfully
// We can't test private fields, but we can verify the client exists // We can't test private fields, but we can verify the client exists
assert!(true); // Client creation successful // Client creation successful
} }
#[test] #[test]
+4
View File
@@ -30,6 +30,7 @@ pub trait MarketStream: Stream<Item = Result<StreamMessage>> + Send + Sync {
/// WebSocket-based market stream implementation /// WebSocket-based market stream implementation
#[derive(Debug)] #[derive(Debug)]
#[allow(dead_code)]
pub struct WebSocketStream { pub struct WebSocketStream {
/// WebSocket connection /// WebSocket connection
connection: Option<tokio_tungstenite::WebSocketStream<tokio_tungstenite::MaybeTlsStream<tokio::net::TcpStream>>>, connection: Option<tokio_tungstenite::WebSocketStream<tokio_tungstenite::MaybeTlsStream<tokio::net::TcpStream>>>,
@@ -219,6 +220,7 @@ impl WebSocketStream {
} }
/// Handle incoming WebSocket messages /// Handle incoming WebSocket messages
#[allow(dead_code)]
async fn handle_message(&mut self, message: tokio_tungstenite::tungstenite::Message) -> Result<()> { async fn handle_message(&mut self, message: tokio_tungstenite::tungstenite::Message) -> Result<()> {
match message { match message {
tokio_tungstenite::tungstenite::Message::Text(text) => { tokio_tungstenite::tungstenite::Message::Text(text) => {
@@ -264,6 +266,7 @@ impl WebSocketStream {
} }
/// Parse Polymarket WebSocket message format /// Parse Polymarket WebSocket message format
#[allow(dead_code)]
fn parse_polymarket_message(&self, text: &str) -> Result<StreamMessage> { fn parse_polymarket_message(&self, text: &str) -> Result<StreamMessage> {
let value: Value = serde_json::from_str(text) let value: Value = serde_json::from_str(text)
.map_err(|e| PolyfillError::parse(format!("Failed to parse WebSocket message: {}", e), Some(Box::new(e))))?; .map_err(|e| PolyfillError::parse(format!("Failed to parse WebSocket message: {}", e), Some(Box::new(e))))?;
@@ -325,6 +328,7 @@ impl WebSocketStream {
} }
/// Reconnect with exponential backoff /// Reconnect with exponential backoff
#[allow(dead_code)]
async fn reconnect(&mut self) -> Result<()> { async fn reconnect(&mut self) -> Result<()> {
let mut delay = self.reconnect_config.base_delay; let mut delay = self.reconnect_config.base_delay;
let mut retries = 0; let mut retries = 0;