gavindiaz/mt5-ai-xauusd-trader

Fork 0

mirror of https://github.com/triqbit/mt5-ai-xauusd-trader.git synced 2026-11-02 06:56:15 +00:00

Files

T

fdd92dddf3 ✨ Jules05: Product coherence improvements (#828 )

* refactor: ✨ Jules05: Product coherence improvements

- Standardized CLI help text and transitioned main.py to structlog.
- Harmonized model predict signatures to return standardized Signal NamedTuple.
- Verified centralization of core enums in src/core/constants.py.
- Updated docs/quality/PRODUCT_COHERENCE_AUDIT.md with remediation status.
- Ensured third-party logs are redirected through structlog in main.py.
- Fixed polymorphic compatibility for all model subclasses.

Co-authored-by: yxynoty <278895235+yxynoty@users.noreply.github.com>

* refactor: ✨ jules05: product coherence improvements

- Standardized CLI help text and transitioned main.py to structlog.
- Harmonized model predict signatures to return standardized Signal NamedTuple.
- Verified centralization of core enums in src/core/constants.py.
- Updated docs/quality/PRODUCT_COHERENCE_AUDIT.md with remediation status.
- Ensured third-party logs are redirected through structlog in main.py.
- Fixed polymorphic compatibility for all model subclasses.
- Added test for model interface polymorphism.

Co-authored-by: yxynoty <278895235+yxynoty@users.noreply.github.com>

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: yxynoty <278895235+yxynoty@users.noreply.github.com>

2026-05-07 18:33:41 +00:00

2.3 KiB

Raw Permalink Blame History

Product Coherence Audit - May 2026

1. Executive Summary

This audit evaluates the MT5 AI XAUUSD Trader for architectural coherence, naming consistency, and institutional polish. While the system demonstrates high technical maturity, several areas of "fragmentation debt" have been identified that could reduce operator trust and increase maintenance overhead.

Status Update (May 8, 2026): Remediation in progress by Jules05 to resolve fragmentation debt in CLI, logging, and model output standardization.

2. Findings

A. Naming & Type Consistency

Duplicate Enums: SignalDirection is defined in both src/core/schemas.py and src/core/constants.py. (RESOLVED)
Mapping Layers: Multiple layers of mapping exist between ModelAction (0,1,2) and SignalDirection (1,-1,0). (HARMOMIZING)
Terminology Drift: Standardizing on "Signal" for raw model outputs and "Decision" for risk-filtered outputs. (IN PROGRESS)

B. Module Boundaries

Core Package bloat: src/core contains diverse logic. Evaluation for future domain separation (e.g., moving FeatureEngineer to src/data) is ongoing.
Circular Risk: Centralizing enums in constants.py has reduced circular dependency risks between schemas and other modules.

C. UX & Institutional Polish

CLI Terminology: argparse help messages are inconsistent. (STANDARDIZING)
Logging: main.py transitions from standard logging to structlog for system-wide consistency. (IN PROGRESS)

3. Remediation Plan

Immediate Fixes (PR ✨ Jules05 - Applied May 8, 2026)

Consolidate Enums: Move SignalDirection and DecisionStatus into src/core/constants.py. (Verified)
Harmonize Schemas: Update src/core/schemas.py to import from constants.py. (Verified)
Refactor BaseModel & Subclasses: Ensure all models return a Signal NamedTuple using SignalDirection. (Applied to PPO, LSTM, Transformer, Ensemble)
Main entrypoint cleanup: Standardize terminology in CLI flags and help text; implement structlog. (Applied)

Long-term Recommendations

Domain Separation: Evaluate moving feature_engineering.py to src/data/.
TUI Dashboard: Transition the CLI from rich-panels to a full TUI (Decision Cockpit) for better operator experience.

Audit Status: ✅ RECOVERING (Remediation active) Steward: Jules05 (yxynoty)

2.3 KiB Raw Permalink Blame History