//+------------------------------------------------------------------+ //| Ehlers_Smoother_Calculator.mqh | //| Calculation engine for John Ehlers' SuperSmoother and | //| Ultimate Smoother filters. Definition-true implementation. | //| Copyright 2025, xxxxxxxx | //+------------------------------------------------------------------+ #property copyright "Copyright 2025, xxxxxxxx" #include //--- Enum names now match the Ehlers articles exactly enum ENUM_SMOOTHER_TYPE { SUPERSMOOTHER, ULTIMATESMOOTHER }; //+==================================================================+ //| | //| CLASS 1: CEhlersSmootherCalculator (Base) | //| | //+==================================================================+ class CEhlersSmootherCalculator { protected: int m_period; ENUM_SMOOTHER_TYPE m_type; double m_price[]; virtual bool PreparePriceSeries(int rates_total, ENUM_APPLIED_PRICE price_type, const double &open[], const double &high[], const double &low[], const double &close[]); public: CEhlersSmootherCalculator(void) {}; virtual ~CEhlersSmootherCalculator(void) {}; bool Init(int period, ENUM_SMOOTHER_TYPE type); void Calculate(int rates_total, ENUM_APPLIED_PRICE price_type, const double &open[], const double &high[], const double &low[], const double &close[], double &filter_buffer[]); }; //+------------------------------------------------------------------+ bool CEhlersSmootherCalculator::Init(int period, ENUM_SMOOTHER_TYPE type) { m_period = (period < 2) ? 2 : period; m_type = type; return true; } //+------------------------------------------------------------------+ void CEhlersSmootherCalculator::Calculate(int rates_total, ENUM_APPLIED_PRICE price_type, const double &open[], const double &high[], const double &low[], const double &close[], double &filter_buffer[]) { if(rates_total < 3) // Need at least 3 bars for Price[i-2] return; if(!PreparePriceSeries(rates_total, price_type, open, high, low, close)) return; //--- Calculate coefficients exactly as per Ehlers' EasyLanguage code //--- Note: Ehlers uses 1.414*180 in his code, which is an approximation of sqrt(2)*180. //--- For cos(), radians are required in MQL5, so we use sqrt(2)*PI. double a1 = exp(-M_SQRT2 * M_PI / m_period); double b1 = 2.0 * a1 * cos(M_SQRT2 * M_PI / m_period); //--- These coefficients are common to both filters double c2 = b1; double c3 = -a1 * a1; //--- The c1 coefficient is different for each filter double c1 = 0; if(m_type == SUPERSMOOTHER) { c1 = 1 - c2 - c3; } else // ULTIMATESMOOTHER { c1 = (1 + c2 - c3) / 4.0; } //--- Full recalculation loop for stability for(int i = 0; i < rates_total; i++) { //--- Initialization for early bars, as per Ehlers' code (CurrentBar < 4) if(i < 2) { filter_buffer[i] = m_price[i]; continue; } //--- State variables from previous calculations double f1 = filter_buffer[i-1]; double f2 = filter_buffer[i-2]; //--- Apply the selected formula, translated directly from EasyLanguage if(m_type == SUPERSMOOTHER) { filter_buffer[i] = c1 * (m_price[i] + m_price[i-1]) / 2.0 + c2 * f1 + c3 * f2; } else // ULTIMATESMOOTHER { filter_buffer[i] = (1 - c1) * m_price[i] + (2 * c1 - c2) * m_price[i-1] - (c1 + c3) * m_price[i-2] + c2 * f1 + c3 * f2; } } } //+------------------------------------------------------------------+ bool CEhlersSmootherCalculator::PreparePriceSeries(int rates_total, ENUM_APPLIED_PRICE price_type, const double &open[], const double &high[], const double &low[], const double &close[]) { ArrayResize(m_price, rates_total); switch(price_type) { case PRICE_CLOSE: ArrayCopy(m_price, close, 0, 0, rates_total); break; case PRICE_OPEN: ArrayCopy(m_price, open, 0, 0, rates_total); break; case PRICE_HIGH: ArrayCopy(m_price, high, 0, 0, rates_total); break; case PRICE_LOW: ArrayCopy(m_price, low, 0, 0, rates_total); break; case PRICE_MEDIAN: for(int i=0; i