From e2d94b12abc76dfd8becc7d25c704002a9c1acad Mon Sep 17 00:00:00 2001 From: Toh4iem9 Date: Mon, 29 Sep 2025 12:24:27 +0200 Subject: [PATCH] new files added --- Indicators/MyIndicators/CCI_Pro.mq5 | 155 ++++++++++++++++++++++++++++ 1 file changed, 155 insertions(+) create mode 100644 Indicators/MyIndicators/CCI_Pro.mq5 diff --git a/Indicators/MyIndicators/CCI_Pro.mq5 b/Indicators/MyIndicators/CCI_Pro.mq5 new file mode 100644 index 0000000..82b93c0 --- /dev/null +++ b/Indicators/MyIndicators/CCI_Pro.mq5 @@ -0,0 +1,155 @@ +//+------------------------------------------------------------------+ +//| CCI_Pro.mq5| +//| Copyright 2025, xxxxxxxx| +//| | +//+------------------------------------------------------------------+ +#property copyright "Copyright 2025, xxxxxxxx" +#property link "" +#property version "3.01" // Corrected calculator logic and draw begin +#property description "Professional Commodity Channel Index (CCI) with a signal line and" +#property description "selectable price source (Standard and Heikin Ashi)." + +//--- Indicator Window and Plot Properties --- +#property indicator_separate_window +#property indicator_buffers 2 // CCI and Signal Line +#property indicator_plots 2 +#property indicator_level1 -100.0 +#property indicator_level2 100.0 +#property indicator_level3 0.0 +#property indicator_levelstyle STYLE_DOT + +//--- Plot 1: CCI line +#property indicator_label1 "CCI" +#property indicator_type1 DRAW_LINE +#property indicator_color1 clrLightSeaGreen +#property indicator_style1 STYLE_SOLID +#property indicator_width1 1 + +//--- Plot 2: Signal line +#property indicator_label2 "Signal" +#property indicator_type2 DRAW_LINE +#property indicator_color2 clrOrangeRed +#property indicator_style2 STYLE_DOT +#property indicator_width2 1 + +//--- Include the calculator engine --- +#include + +//--- Custom Enum for Price Source, including Heikin Ashi --- +enum ENUM_APPLIED_PRICE_HA_ALL + { +//--- Heikin Ashi Prices (negative values for easy identification) + PRICE_HA_CLOSE = -1, + PRICE_HA_OPEN = -2, + PRICE_HA_HIGH = -3, + PRICE_HA_LOW = -4, + PRICE_HA_MEDIAN = -5, + PRICE_HA_TYPICAL = -6, + PRICE_HA_WEIGHTED = -7, +//--- Standard Prices (using built-in ENUM_APPLIED_PRICE values) + PRICE_CLOSE_STD = PRICE_CLOSE, + PRICE_OPEN_STD = PRICE_OPEN, + PRICE_HIGH_STD = PRICE_HIGH, + PRICE_LOW_STD = PRICE_LOW, + PRICE_MEDIAN_STD = PRICE_MEDIAN, + PRICE_TYPICAL_STD = PRICE_TYPICAL, + PRICE_WEIGHTED_STD= PRICE_WEIGHTED + }; + +//--- Input Parameters --- +input int InpCCIPeriod = 20; +input ENUM_APPLIED_PRICE_HA_ALL InpSourcePrice = PRICE_TYPICAL_STD; +input group "Signal Line Settings" +input int InpMAPeriod = 14; +input ENUM_MA_METHOD InpMAMethod = MODE_SMA; + +//--- Indicator Buffers --- +double BufferCCI[]; +double BufferSignal[]; + +//--- Global calculator object (as a base class pointer) --- +CCCI_Calculator *g_calculator; + +//+------------------------------------------------------------------+ +//| Custom indicator initialization function. | +//+------------------------------------------------------------------+ +int OnInit() + { +//--- Map the buffers and set as non-timeseries + SetIndexBuffer(0, BufferCCI, INDICATOR_DATA); + SetIndexBuffer(1, BufferSignal, INDICATOR_DATA); + ArraySetAsSeries(BufferCCI, false); + ArraySetAsSeries(BufferSignal, false); + +//--- Dynamically create the appropriate calculator instance + if(InpSourcePrice <= PRICE_HA_CLOSE) // Heikin Ashi source selected + { + g_calculator = new CCCI_Calculator_HA(); + IndicatorSetString(INDICATOR_SHORTNAME, StringFormat("CCI HA(%d, %d)", InpCCIPeriod, InpMAPeriod)); + } + else // Standard price source selected + { + g_calculator = new CCCI_Calculator(); + IndicatorSetString(INDICATOR_SHORTNAME, StringFormat("CCI(%d, %d)", InpCCIPeriod, InpMAPeriod)); + } + +//--- Check if creation was successful and initialize + if(CheckPointer(g_calculator) == POINTER_INVALID || !g_calculator.Init(InpCCIPeriod, InpMAPeriod, InpMAMethod)) + { + Print("Failed to create or initialize CCI Calculator object."); + return(INIT_FAILED); + } + +//--- Set indicator display properties +//--- CORRECTED: The first CCI value is at (period-1), the first signal value is at (period-1 + ma_period-1) + int cci_draw_begin = InpCCIPeriod - 1; + PlotIndexSetInteger(0, PLOT_DRAW_BEGIN, cci_draw_begin); + PlotIndexSetInteger(1, PLOT_DRAW_BEGIN, cci_draw_begin + InpMAPeriod - 1); + IndicatorSetInteger(INDICATOR_DIGITS, 2); + + return(INIT_SUCCEEDED); + } + +//+------------------------------------------------------------------+ +//| Custom indicator deinitialization function. | +//+------------------------------------------------------------------+ +void OnDeinit(const int reason) + { +//--- Free the calculator object to prevent memory leaks + if(CheckPointer(g_calculator) != POINTER_INVALID) + delete g_calculator; + } + +//+------------------------------------------------------------------+ +//| Custom indicator calculation function. | +//+------------------------------------------------------------------+ +int OnCalculate(const int rates_total, + const int prev_calculated, + const datetime &time[], + const double &open[], + const double &high[], + const double &low[], + const double &close[], + const long &tick_volume[], + const long &volume[], + const int &spread[]) + { +//--- Ensure the calculator object is valid + if(CheckPointer(g_calculator) == POINTER_INVALID) + return 0; + +//--- Convert our custom enum to the standard ENUM_APPLIED_PRICE + ENUM_APPLIED_PRICE price_type; + if(InpSourcePrice <= PRICE_HA_CLOSE) + price_type = (ENUM_APPLIED_PRICE)(-(int)InpSourcePrice); + else + price_type = (ENUM_APPLIED_PRICE)InpSourcePrice; + +//--- Delegate the entire calculation to our calculator object + g_calculator.Calculate(rates_total, open, high, low, close, price_type, BufferCCI, BufferSignal); + +//--- Return rates_total for a full recalculation, ensuring stability + return(rates_total); + } +//+------------------------------------------------------------------+ +//+------------------------------------------------------------------+