refactor: Optimized for incremental calculation

This commit is contained in:
Toh4iem9
2025-12-16 13:36:18 +01:00
parent a9111f2717
commit beffff7297
@@ -1,11 +1,9 @@
//+------------------------------------------------------------------+ //+------------------------------------------------------------------+
//| FisherTransform_Pro.mq5| //| FisherTransform_Pro.mq5|
//| Copyright 2025, xxxxxxxx| //| Copyright 2025, xxxxxxxx|
//| |
//+------------------------------------------------------------------+ //+------------------------------------------------------------------+
#property copyright "Copyright 2025, xxxxxxxx" #property copyright "Copyright 2025, xxxxxxxx"
#property link "" #property version "3.10" // Optimized for incremental calculation
#property version "3.01" // Corrected calculator call signature
#property description "Professional Fisher Transform Oscillator with selectable" #property description "Professional Fisher Transform Oscillator with selectable"
#property description "candle source (Standard or Heikin Ashi)." #property description "candle source (Standard or Heikin Ashi)."
@@ -107,10 +105,10 @@ void OnDeinit(const int reason)
} }
//+------------------------------------------------------------------+ //+------------------------------------------------------------------+
//| Custom indicator calculation function. | //| Custom indicator calculation function |
//+------------------------------------------------------------------+ //+------------------------------------------------------------------+
int OnCalculate(const int rates_total, int OnCalculate(const int rates_total,
const int prev_calculated, const int prev_calculated, // <--- Now used!
const datetime &time[], const datetime &time[],
const double &open[], const double &open[],
const double &high[], const double &high[],
@@ -120,15 +118,13 @@ int OnCalculate(const int rates_total,
const long &volume[], const long &volume[],
const int &spread[]) const int &spread[])
{ {
//--- Ensure the calculator object is valid
if(CheckPointer(g_calculator) == POINTER_INVALID) if(CheckPointer(g_calculator) == POINTER_INVALID)
return 0; return 0;
//--- Delegate the entire calculation to our calculator object //--- Delegate calculation with prev_calculated optimization
//--- CORRECTED: Pass all OHLC arrays for HA calculation // Note: price_type is not used by Fisher (it always uses HL2), but we pass OHLC arrays.
g_calculator.Calculate(rates_total, open, high, low, close, BufferFisher, BufferTrigger); g_calculator.Calculate(rates_total, prev_calculated, open, high, low, close, BufferFisher, BufferTrigger);
//--- Return rates_total for a full recalculation, ensuring stability
return(rates_total); return(rates_total);
} }
//+------------------------------------------------------------------+ //+------------------------------------------------------------------+