gavindiaz/gmgn-skills
1
0
Fork 0
mirror of https://github.com/GMGNAI/gmgn-skills.git synced 2026-08-20 11:38:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: move wallet_holdings filter defaults to CLI, remove no-op flags

Browse Source 
Portfolio holdings to return empty results for wallets that only have closed positions (issue #21).

Changes:
- Convert --hide-closed, --hide-airdrop, --hide-abnormal to value options with explicit defaults (hide_closed=true, hide_airdrop=true, hide_abnormal=false), so defaults are enforced by the CLI and users can override with e.g. --hide-closed false
- Remove --sell-out and --show-small which are hard-coded in the service and were never forwarded to the upstream API
- Update SKILL.md to reflect new option signatures and defaults

Fixes #21

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
David Lau
2026-03-27 18:48:47 +08:00
committed by GMGN.AI
co-authored by Claude Sonnet 4.6
parent 59d7c71e75
commit b7302f5253
2 changed files with 9 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/commands/portfolio.ts
+6 -10
View File
@@ -17,11 +17,9 @@ export function registerPortfolioCommands(program: Command): void {
.option("--order-by <field>", "Sort field: usd_value / last_active_timestamp / realized_profit / unrealized_profit / total_profit / history_bought_cost / history_sold_income", "usd_value")
.option("--direction <dir>", "Sort direction: asc / desc", "desc")
.option("--interval <interval>", "Stats interval (default 24h)")
.option("--sell-out", "Include sold-out positions")
.option("--show-small", "Include small-value positions")
.option("--hide-abnormal", "Hide abnormal positions")
.option("--hide-airdrop", "Hide airdrop positions")
.option("--hide-closed", "Hide closed positions")
.option("--hide-abnormal <bool>", "Hide abnormal positions (default: false)", "false")
.option("--hide-airdrop <bool>", "Hide airdrop positions (default: true)", "true")
.option("--hide-closed <bool>", "Hide closed positions (default: true)", "true")
.option("--hide-open", "Hide open positions")
.option("--tx30d", "Only show positions with trades in last 30 days")
.option("--raw", "Output raw JSON")
@@ -34,11 +32,9 @@ export function registerPortfolioCommands(program: Command): void {
if (opts.orderBy) extra["order_by"] = opts.orderBy;
if (opts.direction) extra["direction"] = opts.direction;
if (opts.interval) extra["interval"] = opts.interval;
if (opts.sellOut) extra["sell_out"] = "true";
if (opts.showSmall) extra["show_small"] = "true";
if (opts.hideAbnormal) extra["hide_abnormal"] = "true";
if (opts.hideAirdrop) extra["hide_airdrop"] = "true";
if (opts.hideClosed) extra["hide_closed"] = "true";
extra["hide_abnormal"] = opts.hideAbnormal;
extra["hide_airdrop"] = opts.hideAirdrop;
extra["hide_closed"] = opts.hideClosed;
if (opts.hideOpen) extra["hide_open"] = "true";
if (opts.tx30d) extra["tx30d"] = "true";