fix: resolve all clippy warnings blocking push

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Pratik Bhadane
2026-04-01 20:16:25 +05:30
co-authored by Claude Sonnet 4.6
parent 70b99ad870
commit ec9bf0410f
7 changed files with 33 additions and 29 deletions
+4 -8
View File
@@ -22,14 +22,10 @@ pub fn check_threshold(series: &[f64], level: f64, direction: i32) -> Vec<i8> {
if prev.is_nan() || curr.is_nan() {
continue;
}
if direction == 1 {
if prev <= level && curr > level {
out[i] = 1;
}
} else if direction == -1 {
if prev >= level && curr < level {
out[i] = 1;
}
if (direction == 1 && prev <= level && curr > level)
|| (direction == -1 && prev >= level && curr < level)
{
out[i] = 1;
}
}
out
+3
View File
@@ -1565,6 +1565,7 @@ pub struct MultiAssetBacktestResult {
/// `weights_2d`: row-major (n_assets, n_bars)
///
/// Callers must transpose from (n_bars, n_assets) if needed.
#[allow(clippy::too_many_arguments)]
pub fn backtest_multi_asset_core(
close_2d: &[Vec<f64>],
weights_2d: &[Vec<f64>],
@@ -1585,6 +1586,7 @@ pub fn backtest_multi_asset_core(
// Apply portfolio constraints per bar
let mut constrained: Vec<Vec<f64>> = weights_2d.to_vec();
#[allow(clippy::needless_range_loop)]
if max_asset_weight != 1.0 || max_gross_exposure > 0.0 || max_net_exposure > 0.0 {
for i in 0..n_bars {
// 1. Clamp per-asset weight
@@ -1635,6 +1637,7 @@ pub fn backtest_multi_asset_core(
// Portfolio return = sum of per-asset strategy returns
let mut portfolio_returns = vec![0.0_f64; n_bars];
#[allow(clippy::needless_range_loop)]
for i in 0..n_bars {
let mut s = 0.0_f64;
for j in 0..n_assets {
+1
View File
@@ -272,6 +272,7 @@ pub fn batch_atr(
/// Apply Stochastic to each set of (high, low, close) columns.
/// Returns `(slowk_columns, slowd_columns)`.
#[allow(clippy::type_complexity)]
pub fn batch_stoch(
high: &[Vec<f64>],
low: &[Vec<f64>],
+3 -7
View File
@@ -231,13 +231,7 @@ pub fn supertrend(
// Direction and output only from index timeperiod (warmup = 0, NaN)
if i >= timeperiod {
let prev_dir = direction[i - 1];
direction[i] = if prev_dir == 0 {
if close[i] > upper_band[i] {
1
} else {
-1
}
} else if prev_dir == -1 {
direction[i] = if prev_dir == 0 || prev_dir == -1 {
if close[i] > upper_band[i] {
1
} else {
@@ -464,6 +458,7 @@ pub fn chandelier_exit(
///
/// # Returns
/// `(tenkan, kijun, senkou_a, senkou_b, chikou)` arrays.
#[allow(clippy::type_complexity)]
pub fn ichimoku(
high: &[f64],
low: &[f64],
@@ -534,6 +529,7 @@ pub fn ichimoku(
///
/// # Returns
/// `(pivot, r1, s1, r2, s2)` arrays. Index 0 is always `NaN` (no previous bar).
#[allow(clippy::type_complexity)]
pub fn pivot_points(
high: &[f64],
low: &[f64],
+3
View File
@@ -165,6 +165,7 @@ pub fn correlation_matrix(data: &[Vec<f64>]) -> Vec<Vec<f64>> {
assert!(n_assets > 0, "data must contain at least one asset column");
let n_bars = data[0].len();
assert!(n_bars >= 2, "data must have at least 2 rows (bars)");
#[allow(clippy::needless_range_loop)]
for j in 1..n_assets {
assert!(
data[j].len() == n_bars,
@@ -190,6 +191,7 @@ pub fn correlation_matrix(data: &[Vec<f64>]) -> Vec<Vec<f64>> {
// Build correlation matrix (exploit symmetry: compute each pair once)
let mut result = vec![vec![0.0_f64; n_assets]; n_assets];
#[allow(clippy::needless_range_loop)]
for j1 in 0..n_assets {
result[j1][j1] = 1.0;
for j2 in (j1 + 1)..n_assets {
@@ -332,6 +334,7 @@ pub fn compose_weighted(data: &[Vec<f64>], weights: &[f64]) -> Vec<f64> {
return vec![];
}
let n_bars = data[0].len();
#[allow(clippy::needless_range_loop)]
for j in 1..n_sigs {
assert!(
data[j].len() == n_bars,