From d0bf8e4cd54eddf90e8919edae90588d89070bbf Mon Sep 17 00:00:00 2001 From: Daniel Szemerey Date: Fri, 7 Jan 2022 10:33:32 +0100 Subject: [PATCH] fix: Changed config registering to not mutate (#119) --- reporting/wandb.py | 3 ++- run_pipeline.py | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/reporting/wandb.py b/reporting/wandb.py index 4973e05..914aa53 100644 --- a/reporting/wandb.py +++ b/reporting/wandb.py @@ -17,7 +17,7 @@ def launch_wandb(project_name:str, default_config:dict, sweep:bool=False): def register_config_with_wandb(wandb: Optional[object], model_config:dict, training_config:dict, data_config:dict): - if wandb is None: return + if wandb is None: return model_config, training_config, data_config config: dict = wandb.config @@ -28,6 +28,7 @@ def register_config_with_wandb(wandb: Optional[object], model_config:dict, train for k in data_config: data_config[k] = config[k] + return model_config, training_config, data_config def send_report_to_wandb(results: pd.DataFrame, wandb:Optional[object], project_name: str, model_name: str): if wandb is None: return diff --git a/run_pipeline.py b/run_pipeline.py index 5dba2b1..f2378d5 100644 --- a/run_pipeline.py +++ b/run_pipeline.py @@ -27,7 +27,7 @@ def __setup_pipeline(project_name:str, with_wandb: bool, sweep: bool): wandb = None if with_wandb: wandb = launch_wandb(project_name=project_name, default_config=dict(**model_config, **training_config, **data_config), sweep=sweep) - register_config_with_wandb(wandb, model_config, training_config, data_config) + model_config, training_config, data_config = register_config_with_wandb(wandb, model_config, training_config, data_config) model_config, training_config, data_config = preprocess_config(model_config, training_config, data_config) return wandb, model_config, training_config, data_config