From a201a3d5674591b0d2eec6d17d9939fe62b1767e Mon Sep 17 00:00:00 2001 From: Wilson Freitas Date: Sat, 29 Aug 2026 17:42:14 -0300 Subject: [PATCH] Update PR review workflow in SKILL.md to clarify handling of `PR Review` attempts and validation criteria --- .agents/skills/sprr/SKILL.md | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.agents/skills/sprr/SKILL.md b/.agents/skills/sprr/SKILL.md index 377a0c6..984ae65 100644 --- a/.agents/skills/sprr/SKILL.md +++ b/.agents/skills/sprr/SKILL.md @@ -24,8 +24,9 @@ If GitHub MCP tools are unavailable, report that PR operations are blocked and p 1. Fetch PR details, current head SHA, files changed, labels, comments, and diff with GitHub MCP. 2. Confirm whether the `reviewed` label or prior maintainer comments exist, then proceed with full validation anyway. 3. Fetch the latest `Validate PR` workflow/check attempt for the current head SHA and apply the CI evidence rules below. -4. Focus on added lines in `README.md`. Flag any other changed files as unusual for a normal contribution. -5. When mechanical validation is not established by current-head CI, save or reconstruct the PR diff locally only if needed, then validate added README entries with: +4. Fetch the latest `PR Review` workflow/check attempt for the pull request and record its status. Treat it as supplementary evidence; it does not replace the current-head `Validate PR` result or manual review. +5. Focus on added lines in `README.md`. Flag any other changed files as unusual for a normal contribution. +6. When mechanical validation is not established by current-head CI, save or reconstruct the PR diff locally only if needed, then validate added README entries with: ```bash uv run python scripts/validate_readme.py --diff-from @@ -53,6 +54,11 @@ commercial free-tier eligibility or transparency, URL tracking, cross-PR uniquen multi-project relatedness. CI cannot establish any of these manual criteria. Search open PRs and PRs closed within the last 365 days for duplicate names and URLs. +`PR Review` runs on `pull_request_target`, so report the latest attempt associated with the pull +request without applying the current-head SHA rule used for `Validate PR`. Inspect its failing job +or step when useful, but never treat a successful `PR Review` attempt as proof that current-head +mechanical validation passed. + ## Validation Checklist For every added entry: @@ -118,6 +124,7 @@ Entries reviewed: Automated validation: - Validate PR: PASS | FAIL | PENDING | UNVERIFIED +- PR Review: PASS | FAIL | PENDING | UNVERIFIED - Commit: (CURRENT | STALE) - Mechanical checks: accepted from CI | reproduced manually | incomplete