mirror of
https://github.com/wilsonfreitas/awesome-quant.git
synced 2026-08-25 18:08:05 +00:00
refactor: update BPRR and SPRR skills for improved PR validation and workflow clarity
This commit is contained in:
@@ -20,9 +20,28 @@ Review multiple open pull requests for README entry contributions.
|
||||
1. List open PRs sorted oldest first.
|
||||
2. Filter to unreviewed PRs by default.
|
||||
3. Fetch the default-branch `README.md` once for duplicate checks.
|
||||
4. For each PR, fetch details, labels, files, body, and diff.
|
||||
4. For each PR, fetch details, current head SHA, labels, files, body, diff, and the latest `Validate PR` workflow/check attempt for that SHA.
|
||||
5. Review only added `README.md` entries unless the PR changes other files; flag other file changes as unusual.
|
||||
6. Validate each PR with the same checks as `$sprr`. Use `scripts/validate_readme.py --diff-from <base-ref>` when the PR branch is available locally; otherwise apply the validator's rules manually from the MCP diff.
|
||||
6. Apply the CI evidence rules below, then perform the remaining `$sprr` checks. Use `scripts/validate_readme.py --diff-from <base-ref>` only when current-head CI does not establish mechanical validity and the PR branch is available locally; otherwise apply the validator's rules manually from the MCP diff.
|
||||
|
||||
## CI Evidence Rules
|
||||
|
||||
Evaluate each PR independently. Use only the latest attempt for the current head SHA; a newer
|
||||
queued or pending attempt supersedes an older success for that SHA. A result for one PR or
|
||||
commit never applies to another.
|
||||
|
||||
| Current-head result | Review behavior |
|
||||
|---|---|
|
||||
| `success` | Accept parser format, tag syntax, separators, the required final period, HTTPS, GitHub-link syntax, recognized section, and base-README duplicate checks as passed. Do not repeat those mechanical checks. |
|
||||
| `failure` | Inspect the failing job or step. Use `NEEDS CHANGES` when validation failed; if another step failed or details are unavailable, reproduce mechanical validation before deciding. |
|
||||
| queued, pending, awaiting approval | Mark the review incomplete and do not return `APPROVE`. |
|
||||
| skipped, cancelled, missing | Treat mechanical validation as unverified and reproduce it before deciding. |
|
||||
| success only on an older SHA | Report `STALE`, ignore it, and reproduce mechanical validation for the current head SHA. |
|
||||
|
||||
For every PR, still inspect the diff and manually review tag meaning and concision, description
|
||||
quality, relevance, semantic section suitability, commercial classification, repository
|
||||
activity/archive/documentation/community evidence, duplicates in open PRs and PRs closed
|
||||
within the last 365 days, and multi-project relatedness.
|
||||
|
||||
## Validation Checklist
|
||||
|
||||
@@ -50,11 +69,17 @@ For each added entry, check:
|
||||
Present a table:
|
||||
|
||||
```text
|
||||
| PR | Title | Author | Entries | Format | URL | Section | Duplicate | Verdict |
|
||||
|----|-------|--------|---------|--------|-----|---------|-----------|---------|
|
||||
| PR | Title | Author | Head | Validate PR | Entries | Format/URL | Section | Duplicate | Verdict |
|
||||
|----|-------|--------|------|-------------|---------|------------|---------|-----------|---------|
|
||||
```
|
||||
|
||||
After the table, list any PRs that need detailed notes.
|
||||
Use the entry count in `Entries`. Use `PASS`, `FAIL`, `PENDING`, `UNVERIFIED`, or
|
||||
`STALE` in `Validate PR`. Use `CI PASS`, `CI FAIL`, `REPRODUCED PASS`,
|
||||
`REPRODUCED FAIL`, or `INCOMPLETE` in `Format/URL`. `Section` remains a manual
|
||||
semantic judgment. In `Duplicate`, report both `README PASS|FAIL` and
|
||||
`PR SEARCH PASS|FAIL`.
|
||||
|
||||
After the table, list any PRs that need detailed notes, including the failing workflow step or the reason CI evidence was not accepted.
|
||||
|
||||
Ask what to do next. Accept selections like:
|
||||
|
||||
|
||||
Reference in New Issue
Block a user