mirror of
https://github.com/wilsonfreitas/awesome-quant.git
synced 2026-07-27 20:07:50 +00:00
Enhance PR review guidelines for non-commercial entries in BPRR and SPRR skills
This commit is contained in:
@@ -29,14 +29,20 @@ Review multiple open pull requests for README entry contributions.
|
|||||||
For each added entry, check:
|
For each added entry, check:
|
||||||
|
|
||||||
- Parser regex match.
|
- Parser regex match.
|
||||||
- Required language tags for new non-commercial entries.
|
- Required backtick tags for new non-commercial entries. Treat them as a compact tag cloud:
|
||||||
|
accept concise languages, runtimes, protocols, interfaces, data types, and domain terms.
|
||||||
|
- Separate concepts must use adjacent tags, such as `` `Python` `C++` `MCP` ``; do not require
|
||||||
|
every tag to be a programming language.
|
||||||
- Description period before optional `[GitHub](...)`.
|
- Description period before optional `[GitHub](...)`.
|
||||||
- `https://` URLs.
|
- `https://` URLs.
|
||||||
- Exact optional `[GitHub](https://github.com/owner/repo)` format.
|
- Exact optional `[GitHub](https://github.com/owner/repo)` format.
|
||||||
- Correct category section.
|
- Correct category section.
|
||||||
- Commercial placement under `Commercial & Proprietary Services`.
|
- Commercial placement under `Commercial & Proprietary Services`.
|
||||||
- Duplicate project names or URLs.
|
- Duplicate project names or URLs.
|
||||||
- Activity, archived status, and basic documentation for GitHub repos.
|
- Treat any verifiable GitHub repository mentioned as the main URL or exact `[GitHub](...)`
|
||||||
|
suffix as a strong positive relevance signal.
|
||||||
|
- For GitHub repos, check source availability, activity, archived status, documentation, and
|
||||||
|
community evidence. GitHub relevance does not waive duplicate, format, or quality checks.
|
||||||
- Clear rationale for multiple related projects in one PR.
|
- Clear rationale for multiple related projects in one PR.
|
||||||
|
|
||||||
## Summary Output
|
## Summary Output
|
||||||
|
|||||||
@@ -36,14 +36,22 @@ If a base ref is not locally available, apply the same checks manually from the
|
|||||||
For every added entry:
|
For every added entry:
|
||||||
|
|
||||||
- It matches `^\s*- \[(.*)\]\((.*)\) - (.*)$`.
|
- It matches `^\s*- \[(.*)\]\((.*)\) - (.*)$`.
|
||||||
- New non-commercial entries include backtick language tags followed by ` - `.
|
- New non-commercial entries include one or more backtick tags followed by ` - `. Treat these
|
||||||
|
as a compact tag cloud: accept concise languages, runtimes, protocols, interfaces, data
|
||||||
|
types, and domain terms.
|
||||||
|
- Separate concepts use adjacent tags, such as `` `Python` `C++` `MCP` ``; do not reject a tag
|
||||||
|
merely because it is not a programming language.
|
||||||
- Description ends with a period before optional `[GitHub](...)`.
|
- Description ends with a period before optional `[GitHub](...)`.
|
||||||
- URLs use `https://`.
|
- URLs use `https://`.
|
||||||
- Optional GitHub link uses `[GitHub](https://github.com/owner/repo)`.
|
- Optional GitHub link uses `[GitHub](https://github.com/owner/repo)`.
|
||||||
- Section placement matches the project's purpose.
|
- Section placement matches the project's purpose.
|
||||||
- Commercial/proprietary projects are under `Commercial & Proprietary Services`.
|
- Commercial/proprietary projects are under `Commercial & Proprietary Services`.
|
||||||
- Project name and URLs are not duplicates of existing README entries.
|
- Project name and URLs are not duplicates of existing README entries.
|
||||||
- GitHub projects are active, not archived, and documented.
|
- Any verifiable GitHub repository mentioned as the main URL or exact `[GitHub](...)` suffix
|
||||||
|
is a strong positive relevance signal.
|
||||||
|
- GitHub projects are checked for source availability, activity, archived status,
|
||||||
|
documentation, and community evidence. GitHub relevance does not waive duplicate, format,
|
||||||
|
or quality checks.
|
||||||
- Multiple projects in one PR are closely related and explained in the PR body.
|
- Multiple projects in one PR are closely related and explained in the PR body.
|
||||||
|
|
||||||
## Verdicts
|
## Verdicts
|
||||||
|
|||||||
Reference in New Issue
Block a user