mirror of
https://github.com/mihakralj/QuanTAlib.git
synced 2026-07-27 17:27:43 +00:00
67ad6f0cba
Comprehensive refactor across all indicators replacing the periodic ResyncInterval-based drift correction (every 1000 ticks recalculate from scratch) with Kahan compensated summation for running sums. Key changes: - Remove ResyncInterval constants and TickCount fields from all State records - Add Kahan compensation fields (SumComp, SumSqComp, etc.) to State records - Replace naive sum += val - removed with Kahan delta pattern - Remove Resync()/RecalculateSum() methods that did O(N) recalculation - Update batch/SIMD paths to use Kahan compensation instead of resync loops - IIR filters (EMA, REMA, RGMA) simplified: inherently self-correcting - Version bump to 0.8.7 - Build system: README version stamping via Directory.Build.props - Minor doc/test tolerance adjustments for new numerical characteristics Affected modules: channels, core, cycles, dynamics, errors, momentum, oscillators, statistics, trends_FIR, trends_IIR, volatility, volume
427 lines
14 KiB
C#
427 lines
14 KiB
C#
using System.Runtime.CompilerServices;
|
||
using System.Runtime.InteropServices;
|
||
|
||
namespace QuanTAlib;
|
||
|
||
/// <summary>
|
||
/// LSMA: Least Squares Moving Average (Linear Regression)
|
||
/// </summary>
|
||
/// <remarks>
|
||
/// Linear regression endpoint with O(1) updates using running sums.
|
||
/// Kahan compensated summation prevents floating-point drift without periodic resync.
|
||
/// Projects trend line value at current bar (or offset position).
|
||
///
|
||
/// Calculation: <c>LSMA = b - m × offset</c> where <c>m = (n×Σxy - Σx×Σy) / denom</c>.
|
||
/// </remarks>
|
||
/// <seealso href="Lsma.md">Detailed documentation</seealso>
|
||
[SkipLocalsInit]
|
||
public sealed class Lsma : AbstractBase
|
||
{
|
||
private readonly int _period;
|
||
private readonly int _offset;
|
||
private readonly RingBuffer _buffer;
|
||
|
||
private readonly double _sum_x;
|
||
private readonly double _denominator;
|
||
private readonly TValuePublishedHandler _handler;
|
||
private ITValuePublisher? _source;
|
||
private int _disposed;
|
||
|
||
[StructLayout(LayoutKind.Auto)]
|
||
private record struct State(double SumY, double SumXY, double SumYComp, double SumXYComp, double LastVal, double LastValidValue);
|
||
private State _state;
|
||
private State _p_state;
|
||
|
||
private bool _isNew;
|
||
|
||
public override bool IsHot => _buffer.IsFull;
|
||
public bool IsNew => _isNew;
|
||
|
||
/// <summary>
|
||
/// Creates LSMA with specified period and offset.
|
||
/// </summary>
|
||
/// <param name="period">Lookback period (must be > 0)</param>
|
||
/// <param name="offset">Offset from current bar (default 0). Positive values project into future.</param>
|
||
public Lsma(int period, int offset = 0)
|
||
{
|
||
if (period <= 0)
|
||
{
|
||
throw new ArgumentException("Period must be greater than 0", nameof(period));
|
||
}
|
||
|
||
_period = period;
|
||
_offset = offset;
|
||
_buffer = new RingBuffer(period);
|
||
Name = $"Lsma({period})";
|
||
WarmupPeriod = period;
|
||
_handler = Handle;
|
||
|
||
// Precalculate constants
|
||
// sum_x = 0 + 1 + ... + (n-1) = n(n-1)/2
|
||
_sum_x = 0.5 * period * (period - 1);
|
||
|
||
// sum_x2 = 0^2 + ... + (n-1)^2 = (n-1)n(2n-1)/6
|
||
double sum_x2 = (period - 1.0) * period * (2.0 * period - 1.0) / 6.0;
|
||
|
||
// denominator = n * sum_x2 - sum_x^2
|
||
_denominator = period * sum_x2 - _sum_x * _sum_x;
|
||
_state.LastValidValue = double.NaN;
|
||
}
|
||
|
||
public Lsma(ITValuePublisher source, int period, int offset = 0) : this(period, offset)
|
||
{
|
||
_source = source ?? throw new ArgumentNullException(nameof(source));
|
||
_source.Pub += _handler;
|
||
}
|
||
|
||
private void Handle(object? sender, in TValueEventArgs e) => Update(e.Value, e.IsNew);
|
||
|
||
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
||
private double GetValidValue(double input)
|
||
{
|
||
if (double.IsFinite(input))
|
||
{
|
||
_state.LastValidValue = input;
|
||
return input;
|
||
}
|
||
return _state.LastValidValue;
|
||
}
|
||
|
||
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
||
private void UpdateState(double val)
|
||
{
|
||
if (_buffer.IsFull)
|
||
{
|
||
double oldest = _buffer.Oldest;
|
||
double prev_sum_y = _state.SumY;
|
||
|
||
// Kahan compensated update for SumXY: sumXY += (prev_sum_y - period * oldest)
|
||
double deltaXY = Math.FusedMultiplyAdd(-_period, oldest, prev_sum_y);
|
||
double yXY = deltaXY - _state.SumXYComp;
|
||
double tXY = _state.SumXY + yXY;
|
||
_state.SumXYComp = (tXY - _state.SumXY) - yXY;
|
||
_state.SumXY = tXY;
|
||
|
||
// Kahan compensated update for SumY: sumY += (val - oldest)
|
||
double deltaY = val - oldest;
|
||
double yY = deltaY - _state.SumYComp;
|
||
double tY = _state.SumY + yY;
|
||
_state.SumYComp = (tY - _state.SumY) - yY;
|
||
_state.SumY = tY;
|
||
|
||
_buffer.Add(val);
|
||
}
|
||
else
|
||
{
|
||
if (_buffer.Count > 0)
|
||
{
|
||
// Kahan compensated addition for SumXY: sumXY += sumY (shift existing values)
|
||
double yXY = _state.SumY - _state.SumXYComp;
|
||
double tXY = _state.SumXY + yXY;
|
||
_state.SumXYComp = (tXY - _state.SumXY) - yXY;
|
||
_state.SumXY = tXY;
|
||
}
|
||
|
||
// Kahan compensated addition for SumY
|
||
double yY = val - _state.SumYComp;
|
||
double tY = _state.SumY + yY;
|
||
_state.SumYComp = (tY - _state.SumY) - yY;
|
||
_state.SumY = tY;
|
||
|
||
_buffer.Add(val);
|
||
}
|
||
}
|
||
|
||
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
||
public override TValue Update(TValue input, bool isNew = true)
|
||
{
|
||
_isNew = isNew;
|
||
if (isNew)
|
||
{
|
||
double val = GetValidValue(input.Value);
|
||
UpdateState(val);
|
||
|
||
_p_state = _state;
|
||
_state.LastVal = val;
|
||
}
|
||
else
|
||
{
|
||
_state.LastValidValue = _p_state.LastValidValue;
|
||
double val = GetValidValue(input.Value);
|
||
|
||
// For isNew=false, we update the current bar.
|
||
// sum_xy remains constant because it depends on the previous window state which hasn't changed.
|
||
// sum_y updates to reflect the change in the newest value.
|
||
|
||
_state.SumY = _p_state.SumY - _p_state.LastVal + val;
|
||
_state.SumXY = _p_state.SumXY; // Restore sum_xy to the state after the shift
|
||
|
||
_buffer.UpdateNewest(val);
|
||
_state.LastVal = val;
|
||
}
|
||
|
||
double result;
|
||
if (_buffer.Count <= 1)
|
||
{
|
||
result = _buffer.Newest;
|
||
}
|
||
else
|
||
{
|
||
// Calculate regression parameters
|
||
// During warmup, we use the current count as n
|
||
double n = _buffer.Count;
|
||
double sx = _sum_x;
|
||
double denom = _denominator;
|
||
|
||
if (!_buffer.IsFull)
|
||
{
|
||
// Recalculate constants for smaller n
|
||
sx = 0.5 * n * (n - 1);
|
||
double sx2 = (n - 1.0) * n * (2.0 * n - 1.0) / 6.0;
|
||
denom = n * sx2 - sx * sx;
|
||
}
|
||
|
||
if (Math.Abs(denom) < 1e-10)
|
||
{
|
||
result = _buffer.Newest;
|
||
}
|
||
else
|
||
{
|
||
double m = Math.FusedMultiplyAdd(n, _state.SumXY, -sx * _state.SumY) / denom;
|
||
double b = Math.FusedMultiplyAdd(-m, sx, _state.SumY) / n;
|
||
|
||
// LSMA = b - m * offset
|
||
result = Math.FusedMultiplyAdd(-m, _offset, b);
|
||
}
|
||
}
|
||
|
||
Last = new TValue(input.Time, result);
|
||
PubEvent(Last, isNew);
|
||
return Last;
|
||
}
|
||
|
||
public override TSeries Update(TSeries source)
|
||
{
|
||
if (source.Count == 0)
|
||
{
|
||
return new TSeries([], []);
|
||
}
|
||
|
||
int len = source.Count;
|
||
var t = new List<long>(len);
|
||
var v = new List<double>(len);
|
||
CollectionsMarshal.SetCount(t, len);
|
||
CollectionsMarshal.SetCount(v, len);
|
||
|
||
var tSpan = CollectionsMarshal.AsSpan(t);
|
||
var vSpan = CollectionsMarshal.AsSpan(v);
|
||
|
||
double initialLastValid = _state.LastValidValue;
|
||
Batch(source.Values, vSpan, _period, _offset, initialLastValid);
|
||
source.Times.CopyTo(tSpan);
|
||
|
||
// Restore state
|
||
// We need to replay the last 'period' bars to set up the buffer and sums correctly
|
||
int windowSize = Math.Min(len, _period);
|
||
int startIndex = len - windowSize;
|
||
|
||
Reset();
|
||
|
||
// Initialize lastValidValue
|
||
if (startIndex > 0)
|
||
{
|
||
for (int i = startIndex - 1; i >= 0; i--)
|
||
{
|
||
if (double.IsFinite(source.Values[i]))
|
||
{
|
||
_state.LastValidValue = source.Values[i];
|
||
break;
|
||
}
|
||
}
|
||
}
|
||
else
|
||
{
|
||
_state.LastValidValue = initialLastValid;
|
||
}
|
||
|
||
double lastProcessedValue = _state.LastValidValue;
|
||
for (int i = startIndex; i < len; i++)
|
||
{
|
||
double val = GetValidValue(source.Values[i]);
|
||
UpdateState(val);
|
||
lastProcessedValue = val;
|
||
}
|
||
|
||
_state.LastVal = lastProcessedValue;
|
||
_p_state = _state;
|
||
|
||
Last = new TValue(tSpan[len - 1], vSpan[len - 1]);
|
||
return new TSeries(t, v);
|
||
}
|
||
|
||
public override void Prime(ReadOnlySpan<double> source, TimeSpan? step = null)
|
||
{
|
||
foreach (var value in source)
|
||
{
|
||
Update(new TValue(DateTime.MinValue, value));
|
||
}
|
||
}
|
||
|
||
public static TSeries Batch(TSeries source, int period, int offset = 0)
|
||
{
|
||
var lsma = new Lsma(period, offset);
|
||
return lsma.Update(source);
|
||
}
|
||
|
||
/// <summary>
|
||
/// Calculates LSMA in-place, writing results to pre-allocated output span.
|
||
/// Zero-allocation method for maximum performance.
|
||
/// </summary>
|
||
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
||
public static void Batch(ReadOnlySpan<double> source, Span<double> output, int period, int offset = 0, double initialLastValid = double.NaN)
|
||
{
|
||
if (source.Length != output.Length)
|
||
{
|
||
throw new ArgumentException("Source and output must have the same length", nameof(output));
|
||
}
|
||
|
||
if (period <= 0)
|
||
{
|
||
throw new ArgumentException("Period must be greater than 0", nameof(period));
|
||
}
|
||
|
||
int len = source.Length;
|
||
if (len == 0)
|
||
{
|
||
return;
|
||
}
|
||
|
||
const int StackAllocThreshold = 256;
|
||
Span<double> buffer = period <= StackAllocThreshold
|
||
? stackalloc double[period]
|
||
: new double[period];
|
||
|
||
double sum_y = 0;
|
||
double sum_xy = 0;
|
||
double lastValid = initialLastValid;
|
||
int bufferIndex = 0; // Points to where the NEXT value will be written (circular)
|
||
int count = 0;
|
||
|
||
// Precalculate constants for full period
|
||
double full_sum_x = 0.5 * period * (period - 1);
|
||
double full_sum_x2 = (period - 1.0) * period * (2.0 * period - 1.0) / 6.0;
|
||
double full_denom = period * full_sum_x2 - full_sum_x * full_sum_x;
|
||
|
||
for (int i = 0; i < len; i++)
|
||
{
|
||
double val = source[i];
|
||
if (double.IsFinite(val))
|
||
{
|
||
lastValid = val;
|
||
}
|
||
else
|
||
{
|
||
val = lastValid;
|
||
}
|
||
|
||
if (count < period)
|
||
{
|
||
// Warmup phase
|
||
buffer[count] = val;
|
||
count++;
|
||
|
||
// O(1) update: adding new value at x=0, existing values shift x+1
|
||
// New value at x=0 contributes 0, existing sum shifts by sum_y
|
||
if (count > 1)
|
||
{
|
||
sum_xy += sum_y; // Shift existing values before adding new
|
||
}
|
||
sum_y += val;
|
||
|
||
if (count <= 1)
|
||
{
|
||
output[i] = val;
|
||
}
|
||
else
|
||
{
|
||
double n = count;
|
||
double sx = 0.5 * n * (n - 1);
|
||
double sx2 = (n - 1.0) * n * (2.0 * n - 1.0) / 6.0;
|
||
double denom = n * sx2 - sx * sx;
|
||
|
||
if (Math.Abs(denom) < 1e-10)
|
||
{
|
||
output[i] = val;
|
||
}
|
||
else
|
||
{
|
||
double m = Math.FusedMultiplyAdd(n, sum_xy, -sx * sum_y) / denom;
|
||
double b = Math.FusedMultiplyAdd(-m, sx, sum_y) / n;
|
||
output[i] = Math.FusedMultiplyAdd(-m, offset, b);
|
||
}
|
||
}
|
||
|
||
if (count == period)
|
||
{
|
||
bufferIndex = 0; // Reset for circular buffer usage
|
||
}
|
||
}
|
||
else
|
||
{
|
||
// Full buffer phase - O(1) update
|
||
double oldest = buffer[bufferIndex];
|
||
double prev_sum_y = sum_y;
|
||
|
||
// sum_xy_new = sum_xy_old + sum_y_prev - n * oldest
|
||
sum_xy = Math.FusedMultiplyAdd(-period, oldest, sum_xy + prev_sum_y);
|
||
|
||
sum_y = sum_y - oldest + val;
|
||
buffer[bufferIndex] = val;
|
||
|
||
bufferIndex++;
|
||
if (bufferIndex >= period)
|
||
{
|
||
bufferIndex = 0;
|
||
}
|
||
|
||
double m = Math.FusedMultiplyAdd(period, sum_xy, -full_sum_x * sum_y) / full_denom;
|
||
double b = Math.FusedMultiplyAdd(-m, full_sum_x, sum_y) / period;
|
||
output[i] = Math.FusedMultiplyAdd(-m, offset, b);
|
||
}
|
||
}
|
||
}
|
||
|
||
public static (TSeries Results, Lsma Indicator) Calculate(TSeries source, int period, int offset = 0)
|
||
{
|
||
var indicator = new Lsma(period, offset);
|
||
TSeries results = indicator.Update(source);
|
||
return (results, indicator);
|
||
}
|
||
|
||
/// <summary>
|
||
/// Resets the LSMA state.
|
||
/// </summary>
|
||
public override void Reset()
|
||
{
|
||
_buffer.Clear();
|
||
_state = default;
|
||
_state.LastValidValue = double.NaN;
|
||
_p_state = default;
|
||
Last = default;
|
||
}
|
||
|
||
/// <summary>
|
||
/// Disposes the Lsma instance, unsubscribing from the source publisher if subscribed.
|
||
/// This method is idempotent and thread-safe.
|
||
/// </summary>
|
||
protected override void Dispose(bool disposing)
|
||
{
|
||
// Use Interlocked.CompareExchange for thread-safe, idempotent disposal
|
||
if (Interlocked.CompareExchange(ref _disposed, 1, 0) == 0 && _source != null)
|
||
{
|
||
_source.Pub -= _handler;
|
||
_source = null;
|
||
}
|
||
base.Dispose(disposing);
|
||
}
|
||
} |