gavindiaz/QuanTAlib
1
0
Fork 0
mirror of https://github.com/mihakralj/QuanTAlib.git synced 2026-08-16 09:38:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Update action versions in Publish.yml; improve .gitignore entries; refactor Alma, Super, and Trima classes for clarity and performance

Browse Source
This commit is contained in:
Miha Kralj
2025-12-17 10:16:37 -08:00
parent 80237b3b5a
commit facc814ede
5 changed files with 36 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/trends/alma/Alma.cs
+6 -6
View File
@@ -86,12 +86,7 @@ public sealed class Alma : AbstractBase
[MethodImpl(MethodImplOptions.AggressiveInlining)]
private double GetValidValue(double input)
{
if (double.IsFinite(input))
{
_state.LastValidValue = input;
return input;
}
return _state.LastValidValue;
return double.IsFinite(input) ? input : _state.LastValidValue;
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
@@ -107,6 +102,11 @@ public sealed class Alma : AbstractBase
}
double val = GetValidValue(input.Value);
if (double.IsFinite(input.Value))
{
_state.LastValidValue = input.Value;
}
_buffer.Add(val, isNew);
double result = 0;
lib/trends/super/Super.cs
+19 -5
View File
@@ -180,15 +180,29 @@ public sealed class Super : ITValuePublisher
}
// SuperTrend
if (input.Close <= (_state.IsBullish ? _state.LowerBand : _state.UpperBand))
if (_state.IsBullish)
{
superTrend = _state.UpperBand;
_state.IsBullish = false;
if (input.Close < _state.LowerBand)
{
_state.IsBullish = false;
superTrend = _state.UpperBand;
}
else
{
superTrend = _state.LowerBand;
}
}
else
{
superTrend = _state.LowerBand;
_state.IsBullish = true;
if (input.Close > _state.UpperBand)
{
_state.IsBullish = true;
superTrend = _state.LowerBand;
}
else
{
superTrend = _state.UpperBand;
}
}
upperBand = _state.UpperBand;
lib/trends/trima/Trima.cs
+7 -7
View File
@@ -14,8 +14,8 @@ namespace QuanTAlib;
/// Equivalent to a double SMA: SMA(SMA(period1), period2).
///
/// Calculation:
/// p1 = period / 2 + 1
/// p2 = (period + 1) / 2
/// p1 = (period + 1) / 2
/// p2 = period / 2 + 1
/// TRIMA = SMA(SMA(input, p1), p2)
///
/// O(1) update:
@@ -36,8 +36,8 @@ public sealed class Trima : AbstractBase
if (period <= 0) throw new ArgumentException("Period must be greater than 0", nameof(period));
_period = period;
int p1 = period / 2 + 1;
int p2 = (period + 1) / 2;
int p1 = (period + 1) / 2;
int p2 = period / 2 + 1;
_sma1 = new Sma(p1);
_sma2 = new Sma(p2);
@@ -94,7 +94,7 @@ public sealed class Trima : AbstractBase
_sma1.Prime(source);
// Calculate intermediate SMA series to prime the second SMA
int p1 = _period / 2 + 1;
int p1 = (_period + 1) / 2;
double[] tempArray = ArrayPool<double>.Shared.Rent(source.Length);
Span<double> tempSpan = tempArray.AsSpan(0, source.Length);
@@ -129,8 +129,8 @@ public sealed class Trima : AbstractBase
if (period <= 0)
throw new ArgumentException("Period must be greater than 0", nameof(period));
int p1 = period / 2 + 1;
int p2 = (period + 1) / 2;
int p1 = (period + 1) / 2;
int p2 = period / 2 + 1;
double[] tempArray = ArrayPool<double>.Shared.Rent(source.Length);
Span<double> tempSpan = tempArray.AsSpan(0, source.Length);