mirror of
https://github.com/mihakralj/QuanTAlib.git
synced 2026-08-07 21:47:43 +00:00
Refactor event handling and improve argument validation across indicators
- Updated event handler signatures to use TValueEventArgs for consistency in Mama, Mgdi, Pwma, Rma, Sma, Ssf, Super, T3, Tema, Trima, Usf, Vidya, Wma, and Atr classes. - Enhanced argument validation by specifying parameter names in exceptions for clarity. - Adjusted tests to align with new event handler signatures. - Improved code readability and maintainability by using structured records and lambda expressions.
This commit is contained in:
@@ -103,8 +103,8 @@ public class AdlTests
|
||||
{
|
||||
var adl = new Adl();
|
||||
bool eventFired = false;
|
||||
adl.Pub += (val) => eventFired = true;
|
||||
|
||||
adl.Pub += (object? sender, TValueEventArgs args) => eventFired = true;
|
||||
|
||||
adl.Update(new TBar(DateTime.UtcNow, 10, 12, 8, 10, 100));
|
||||
Assert.True(eventFired);
|
||||
}
|
||||
|
||||
@@ -33,7 +33,7 @@ public sealed class Adl : ITValuePublisher
|
||||
/// </summary>
|
||||
public static string Name => "ADL";
|
||||
|
||||
public event Action<TValue>? Pub;
|
||||
public event TValuePublishedHandler? Pub;
|
||||
|
||||
/// <summary>
|
||||
/// Current ADL value.
|
||||
@@ -90,7 +90,7 @@ public sealed class Adl : ITValuePublisher
|
||||
|
||||
_isInitialized = true;
|
||||
Last = new TValue(input.Time, _adl);
|
||||
Pub?.Invoke(Last);
|
||||
Pub?.Invoke(this, new TValueEventArgs { Value = Last, IsNew = true });
|
||||
return Last;
|
||||
}
|
||||
|
||||
@@ -106,7 +106,7 @@ public sealed class Adl : ITValuePublisher
|
||||
}
|
||||
|
||||
Last = new TValue(input.Time, _adl);
|
||||
Pub?.Invoke(Last);
|
||||
Pub?.Invoke(this, new TValueEventArgs { Value = Last, IsNew = true });
|
||||
return Last;
|
||||
}
|
||||
|
||||
@@ -143,7 +143,7 @@ public sealed class Adl : ITValuePublisher
|
||||
public static void Calculate(ReadOnlySpan<double> high, ReadOnlySpan<double> low, ReadOnlySpan<double> close, ReadOnlySpan<double> volume, Span<double> output)
|
||||
{
|
||||
if (high.Length != low.Length || high.Length != close.Length || high.Length != volume.Length || high.Length != output.Length)
|
||||
throw new ArgumentException("All spans must be of the same length");
|
||||
throw new ArgumentException("All spans must be of the same length", nameof(output));
|
||||
|
||||
int len = high.Length;
|
||||
int i = 0;
|
||||
@@ -197,3 +197,4 @@ public sealed class Adl : ITValuePublisher
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -32,7 +32,7 @@ public sealed class Adosc : ITValuePublisher
|
||||
/// </summary>
|
||||
public string Name { get; }
|
||||
|
||||
public event Action<TValue>? Pub;
|
||||
public event TValuePublishedHandler? Pub;
|
||||
|
||||
/// <summary>
|
||||
/// Current ADOSC value.
|
||||
@@ -96,7 +96,7 @@ public sealed class Adosc : ITValuePublisher
|
||||
|
||||
double adosc = eFast.Value - eSlow.Value;
|
||||
Last = new TValue(input.Time, adosc);
|
||||
Pub?.Invoke(Last);
|
||||
Pub?.Invoke(this, new TValueEventArgs { Value = Last, IsNew = true });
|
||||
return Last;
|
||||
}
|
||||
|
||||
@@ -162,7 +162,7 @@ public sealed class Adosc : ITValuePublisher
|
||||
public static void Calculate(ReadOnlySpan<double> high, ReadOnlySpan<double> low, ReadOnlySpan<double> close, ReadOnlySpan<double> volume, Span<double> output, int fastPeriod = 3, int slowPeriod = 10)
|
||||
{
|
||||
if (high.Length != output.Length)
|
||||
throw new ArgumentException("Source and output spans must be of the same length.");
|
||||
throw new ArgumentException("Source and output spans must be of the same length.", nameof(output));
|
||||
|
||||
Span<double> adl = high.Length <= 1024 ? stackalloc double[high.Length] : new double[high.Length];
|
||||
Adl.Calculate(high, low, close, volume, adl);
|
||||
@@ -176,3 +176,4 @@ public sealed class Adosc : ITValuePublisher
|
||||
SimdExtensions.Subtract(fastEma, slowEma, output);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user