Refactor event handling and improve argument validation across indicators

- Updated event handler signatures to use TValueEventArgs for consistency in Mama, Mgdi, Pwma, Rma, Sma, Ssf, Super, T3, Tema, Trima, Usf, Vidya, Wma, and Atr classes.
- Enhanced argument validation by specifying parameter names in exceptions for clarity.
- Adjusted tests to align with new event handler signatures.
- Improved code readability and maintainability by using structured records and lambda expressions.
This commit is contained in:
Miha Kralj
2025-12-27 15:46:28 -08:00
parent 4750c2b1e8
commit d7dbd7078a
73 changed files with 502 additions and 300 deletions
+7 -4
View File
@@ -33,8 +33,9 @@ public sealed class Wma : AbstractBase, IDisposable
private readonly double _divisor;
private readonly RingBuffer _buffer;
private readonly ITValuePublisher? _source;
private readonly Action<TValue>? _handler;
private readonly TValuePublishedHandler? _handler;
[StructLayout(LayoutKind.Auto)]
private record struct State(double Sum, double WSum, double LastInput, double LastValidValue, int TickCount, bool HasSeenValidData);
private State _state;
private State _p_state;
@@ -68,7 +69,7 @@ public sealed class Wma : AbstractBase, IDisposable
public Wma(ITValuePublisher source, int period) : this(period)
{
_source = source;
_handler = (item) => Update(item);
_handler = Handle;
source.Pub += _handler;
}
@@ -159,7 +160,7 @@ public sealed class Wma : AbstractBase, IDisposable
double currentDivisor = _buffer.IsFull ? _divisor : (double)_buffer.Count * (_buffer.Count + 1) * 0.5;
Last = new TValue(input.Time, _state.WSum / currentDivisor);
PubEvent(Last);
PubEvent(Last, isNew);
return Last;
}
@@ -185,6 +186,8 @@ public sealed class Wma : AbstractBase, IDisposable
return new TSeries(t, v);
}
private void Handle(object? sender, TValueEventArgs e) => Update(e.Value, e.IsNew);
public override void Prime(ReadOnlySpan<double> source)
{
if (source.Length == 0) return;
@@ -248,7 +251,7 @@ public sealed class Wma : AbstractBase, IDisposable
public static void Batch(ReadOnlySpan<double> source, Span<double> output, int period)
{
if (source.Length != output.Length)
throw new ArgumentException("Source and output must have the same length");
throw new ArgumentException("Source and output must have the same length", nameof(output));
if (period <= 0)
throw new ArgumentException("Period must be greater than 0", nameof(period));