mirror of
https://github.com/mihakralj/QuanTAlib.git
synced 2026-08-15 09:08:04 +00:00
Refactor event handling and improve argument validation across indicators
- Updated event handler signatures to use TValueEventArgs for consistency in Mama, Mgdi, Pwma, Rma, Sma, Ssf, Super, T3, Tema, Trima, Usf, Vidya, Wma, and Atr classes. - Enhanced argument validation by specifying parameter names in exceptions for clarity. - Adjusted tests to align with new event handler signatures. - Improved code readability and maintainability by using structured records and lambda expressions.
This commit is contained in:
@@ -33,7 +33,7 @@ public sealed class Alma : AbstractBase, IDisposable
|
||||
private readonly double _invWeightSum;
|
||||
private readonly RingBuffer _buffer;
|
||||
private readonly ITValuePublisher? _source;
|
||||
private readonly Action<TValue>? _pubHandler;
|
||||
private readonly TValuePublishedHandler? _pubHandler;
|
||||
|
||||
private record struct State(double LastValidValue);
|
||||
private State _state;
|
||||
@@ -84,10 +84,13 @@ public sealed class Alma : AbstractBase, IDisposable
|
||||
: this(period, offset, sigma)
|
||||
{
|
||||
_source = source;
|
||||
_pubHandler = (item) => Update(item);
|
||||
_pubHandler = Handle;
|
||||
_source.Pub += _pubHandler;
|
||||
}
|
||||
|
||||
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
||||
private void Handle(object? sender, TValueEventArgs e) => Update(e.Value, e.IsNew);
|
||||
|
||||
public void Dispose()
|
||||
{
|
||||
if (_source != null && _pubHandler != null)
|
||||
@@ -235,7 +238,7 @@ public sealed class Alma : AbstractBase, IDisposable
|
||||
if (period <= 0)
|
||||
throw new ArgumentException("Period must be greater than 0", nameof(period));
|
||||
if (source.Length != output.Length)
|
||||
throw new ArgumentException("Source and output must have the same length");
|
||||
throw new ArgumentException("Source and output must have the same length", nameof(output));
|
||||
|
||||
// Precompute weights
|
||||
// Use stackalloc for small periods to avoid heap allocation, ArrayPool for large
|
||||
|
||||
Reference in New Issue
Block a user