gavindiaz/QuanTAlib
1
0
Fork 0
mirror of https://github.com/mihakralj/QuanTAlib.git synced 2026-08-24 13:38:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: address code review issues in indicators and core components

Browse Source
This commit is contained in:
Miha Kralj
2025-12-09 16:00:04 -05:00
parent 5e6e3a070e
commit c802a9ea80
12 changed files with 54 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/trends/kama/Kama.cs
+1 -6
View File
@@ -177,12 +177,7 @@ public sealed class Kama : ITValuePublisher
// Use static Calculate for performance
var outputSpan = new double[len];
Calculate(source.Values, outputSpan, _period,
(int)(2.0 / _fastAlpha - 1), (int)(2.0 / _slowAlpha - 1)); // Reverse calc periods from alphas?
// Actually better to pass alphas or periods.
// The static method signature should match constructor params.
// Wait, I need to pass periods to static method.
// fastPeriod = 2/fastAlpha - 1.
int fastPeriod = (int)Math.Round(2.0 / _fastAlpha - 1);
int slowPeriod = (int)Math.Round(2.0 / _slowAlpha - 1);