diff --git a/lib/core/ringbuffer/RingBuffer.Tests.cs b/lib/core/ringbuffer/RingBuffer.Tests.cs index 7e5e9b6c..27b7df8a 100644 --- a/lib/core/ringbuffer/RingBuffer.Tests.cs +++ b/lib/core/ringbuffer/RingBuffer.Tests.cs @@ -372,7 +372,7 @@ public class RingBufferTests buffer.Add(20.0); buffer.Add(30.0); - var values = new List(); + List values = []; foreach (var v in buffer) { values.Add(v); @@ -395,7 +395,7 @@ public class RingBufferTests buffer.Add(40.0); buffer.Add(50.0); - var values = new List(); + List values = []; foreach (var v in buffer) { values.Add(v); @@ -637,7 +637,7 @@ public class RingBufferTests buffer.Add(20.0); IEnumerable enumerable = buffer; - var values = new List(); + List values = []; foreach (var v in enumerable) { values.Add(v); @@ -656,7 +656,7 @@ public class RingBufferTests buffer.Add(20.0); IEnumerable enumerable = buffer; - var values = new List(); + List values = []; foreach (var v in enumerable) { values.Add((double)v); diff --git a/lib/core/ringbuffer/RingBuffer.cs b/lib/core/ringbuffer/RingBuffer.cs index 06479c57..a9018708 100644 --- a/lib/core/ringbuffer/RingBuffer.cs +++ b/lib/core/ringbuffer/RingBuffer.cs @@ -526,10 +526,10 @@ public sealed class RingBuffer : IEnumerable _index == other._index && _current.Equals(other._current); - public override readonly bool Equals(object? obj) => + public readonly override bool Equals(object? obj) => obj is Enumerator other && Equals(other); - public override readonly int GetHashCode() => + public readonly override int GetHashCode() => HashCode.Combine(RuntimeHelpers.GetHashCode(_buffer), _start, _count, _index, _current); public static bool operator ==(Enumerator left, Enumerator right) => left.Equals(right); diff --git a/lib/core/tbarseries/tbarseries.cs b/lib/core/tbarseries/tbarseries.cs index 0a773d3c..2b0696cd 100644 --- a/lib/core/tbarseries/tbarseries.cs +++ b/lib/core/tbarseries/tbarseries.cs @@ -106,14 +106,12 @@ public delegate void TBarPublishedHandler(object? sender, in TBarEventArgs args) public class TBarSeries : IReadOnlyList { -#pragma warning disable MA0016 // Prefer using collection abstraction instead of implementation - protected readonly List _t; - protected readonly List _o; - protected readonly List _h; - protected readonly List _l; - protected readonly List _c; - protected readonly List _v; -#pragma warning restore MA0016 + private readonly List _t; + private readonly List _o; + private readonly List _h; + private readonly List _l; + private readonly List _c; + private readonly List _v; public string Name { get; set; } = "Bar"; public event TBarPublishedHandler? Pub; diff --git a/lib/core/tseries/tseries.cs b/lib/core/tseries/tseries.cs index 2389ed8d..cccbb186 100644 --- a/lib/core/tseries/tseries.cs +++ b/lib/core/tseries/tseries.cs @@ -99,8 +99,8 @@ public class TSeries : IReadOnlyList, ITValuePublisher } else { - _t = new List(time); - _v = new List(values); + _t = [..time]; + _v = [..values]; } } diff --git a/lib/core/tvalue/tvalue.cs b/lib/core/tvalue/tvalue.cs index e557b362..9fb96f66 100644 --- a/lib/core/tvalue/tvalue.cs +++ b/lib/core/tvalue/tvalue.cs @@ -33,7 +33,7 @@ public readonly record struct TValue(long Time, double Value) double.PositiveInfinity => ((char)0x221E).ToString(), double.NegativeInfinity => "-" + (char)0x221E, _ when double.IsNaN(Value) => "NaN", - _ => Value.ToString("F2") + _ => Value.ToString("F2"), }; return $"[{AsDateTime:yyyy-MM-dd HH:mm:ss}, {valueStr}]"; } diff --git a/quantower/IndicatorExtensions.cs b/quantower/IndicatorExtensions.cs index d63a3b1e..7fc85b9d 100644 --- a/quantower/IndicatorExtensions.cs +++ b/quantower/IndicatorExtensions.cs @@ -115,7 +115,7 @@ public static class IndicatorExtensions int count = leftIndex - rightIndex; if (count <= 0) return Array.Empty(); - Point[] allPoints = new Point[count]; + var allPoints = new Point[count]; for (int i = 0; i < count; i++) { @@ -191,7 +191,7 @@ public static class IndicatorExtensions if (showColdValues) { int coldStart = Math.Max(0, hotCount); - int coldSegments = (count - 1) - coldStart; + int coldSegments = count - coldStart - 1; if (coldSegments > 0) {