[CodeFactor] Apply fixes to commit 0606491

This commit is contained in:
codefactor-io
2026-03-12 19:37:50 +00:00
parent 060649192f
commit 8f79257155
384 changed files with 1197 additions and 1215 deletions
@@ -114,12 +114,12 @@ public sealed class ChandelierBasicTests
// Steady uptrend
for (int i = 0; i < 20; i++)
{
double price = basePrice + i * 2;
double price = basePrice + (i * 2);
_ = ch.Update(new TBar(DateTime.UtcNow.AddMinutes(i),
price + 1, price - 1, price + 0.5, price, 1000));
}
Assert.True(ch.ExitLong < 100.0 + 19 * 2, "ExitLong should be below the current price in an uptrend");
Assert.True(ch.ExitLong < 100.0 + (19 * 2), "ExitLong should be below the current price in an uptrend");
}
}
+2 -2
View File
@@ -131,12 +131,12 @@ public sealed class CkstopBasicTests
// Steady uptrend
for (int i = 0; i < 20; i++)
{
double price = basePrice + i * 2;
double price = basePrice + (i * 2);
_ = ck.Update(new TBar(DateTime.UtcNow.AddMinutes(i),
price + 1, price - 1, price + 0.5, price, 1000));
}
Assert.True(ck.StopLong < 100.0 + 19 * 2, "StopLong should be below the current price in an uptrend");
Assert.True(ck.StopLong < 100.0 + (19 * 2), "StopLong should be below the current price in an uptrend");
}
}
@@ -97,7 +97,7 @@ public sealed class FractalsBasicTests
// Monotone ascending - no fractal
for (int i = 0; i < 5; i++)
{
double price = 100.0 + i * 5;
double price = 100.0 + (i * 5);
_ = f.Update(new TBar(dt.AddMinutes(i), price, price + 2, price - 2, price + 1, 1000), isNew: true);
}
@@ -64,7 +64,7 @@ public sealed class PivotIndicatorTests
var now = DateTime.UtcNow;
for (int i = 0; i < 10; i++)
{
double basePrice = 100 + i * 2;
double basePrice = 100 + (i * 2);
indicator.HistoricalData.AddBar(now.AddMinutes(i), basePrice, basePrice + 5, basePrice - 5, basePrice + 2);
var args = new UpdateArgs(UpdateReason.HistoricalBar);
+4 -4
View File
@@ -101,12 +101,12 @@ public sealed class PivotBasicTests
double expectedPP = (120.0 + 100.0 + 115.0) / 3.0;
Assert.Equal(expectedPP, p.PP, precision: 10);
Assert.Equal(2.0 * expectedPP - 100.0, p.R1, precision: 10);
Assert.Equal(2.0 * expectedPP - 120.0, p.S1, precision: 10);
Assert.Equal((2.0 * expectedPP) - 100.0, p.R1, precision: 10);
Assert.Equal((2.0 * expectedPP) - 120.0, p.S1, precision: 10);
Assert.Equal(expectedPP + 20.0, p.R2, precision: 10);
Assert.Equal(expectedPP - 20.0, p.S2, precision: 10);
Assert.Equal(120.0 + 2.0 * (expectedPP - 100.0), p.R3, precision: 10);
Assert.Equal(100.0 - 2.0 * (120.0 - expectedPP), p.S3, precision: 10);
Assert.Equal(120.0 + (2.0 * (expectedPP - 100.0)), p.R3, precision: 10);
Assert.Equal(100.0 - (2.0 * (120.0 - expectedPP)), p.S3, precision: 10);
}
[Fact]
@@ -61,12 +61,12 @@ public sealed class PivotValidationTests
double range = pH - pL;
Assert.Equal(pp, p.PP, precision: 10);
Assert.Equal(2.0 * pp - pL, p.R1, precision: 10);
Assert.Equal(2.0 * pp - pH, p.S1, precision: 10);
Assert.Equal((2.0 * pp) - pL, p.R1, precision: 10);
Assert.Equal((2.0 * pp) - pH, p.S1, precision: 10);
Assert.Equal(pp + range, p.R2, precision: 10);
Assert.Equal(pp - range, p.S2, precision: 10);
Assert.Equal(pH + 2.0 * (pp - pL), p.R3, precision: 10);
Assert.Equal(pL - 2.0 * (pH - pp), p.S3, precision: 10);
Assert.Equal(pH + (2.0 * (pp - pL)), p.R3, precision: 10);
Assert.Equal(pL - (2.0 * (pH - pp)), p.S3, precision: 10);
}
}
}
@@ -258,5 +258,4 @@ public sealed class PivotValidationTests
}
}
}
}
@@ -64,7 +64,7 @@ public sealed class PivotcamIndicatorTests
var now = DateTime.UtcNow;
for (int i = 0; i < 10; i++)
{
double basePrice = 100 + i * 2;
double basePrice = 100 + (i * 2);
indicator.HistoricalData.AddBar(now.AddMinutes(i), basePrice, basePrice + 5, basePrice - 5, basePrice + 2);
var args = new UpdateArgs(UpdateReason.HistoricalBar);
+16 -16
View File
@@ -83,14 +83,14 @@ public sealed class PivotcamBasicTests
double range = 20.0;
double pC = 100.0;
Assert.Equal(100.0, p.PP, precision: 10);
Assert.Equal(pC + range * 1.0833 / 12.0, p.R1, precision: 4);
Assert.Equal(pC - range * 1.0833 / 12.0, p.S1, precision: 4);
Assert.Equal(pC + range * 1.1666 / 12.0, p.R2, precision: 4);
Assert.Equal(pC - range * 1.1666 / 12.0, p.S2, precision: 4);
Assert.Equal(pC + range * 1.25 / 12.0, p.R3, precision: 4);
Assert.Equal(pC - range * 1.25 / 12.0, p.S3, precision: 4);
Assert.Equal(pC + range * 1.5 / 12.0, p.R4, precision: 4);
Assert.Equal(pC - range * 1.5 / 12.0, p.S4, precision: 4);
Assert.Equal(pC + (range * 1.0833 / 12.0), p.R1, precision: 4);
Assert.Equal(pC - (range * 1.0833 / 12.0), p.S1, precision: 4);
Assert.Equal(pC + (range * 1.1666 / 12.0), p.R2, precision: 4);
Assert.Equal(pC - (range * 1.1666 / 12.0), p.S2, precision: 4);
Assert.Equal(pC + (range * 1.25 / 12.0), p.R3, precision: 4);
Assert.Equal(pC - (range * 1.25 / 12.0), p.S3, precision: 4);
Assert.Equal(pC + (range * 1.5 / 12.0), p.R4, precision: 4);
Assert.Equal(pC - (range * 1.5 / 12.0), p.S4, precision: 4);
}
[Fact]
@@ -108,14 +108,14 @@ public sealed class PivotcamBasicTests
double pC = 115.0;
Assert.Equal(expectedPP, p.PP, precision: 10);
Assert.Equal(pC + range * 1.0833 / 12.0, p.R1, precision: 4);
Assert.Equal(pC - range * 1.0833 / 12.0, p.S1, precision: 4);
Assert.Equal(pC + range * 1.1666 / 12.0, p.R2, precision: 4);
Assert.Equal(pC - range * 1.1666 / 12.0, p.S2, precision: 4);
Assert.Equal(pC + range * 1.25 / 12.0, p.R3, precision: 4);
Assert.Equal(pC - range * 1.25 / 12.0, p.S3, precision: 4);
Assert.Equal(pC + range * 1.5 / 12.0, p.R4, precision: 4);
Assert.Equal(pC - range * 1.5 / 12.0, p.S4, precision: 4);
Assert.Equal(pC + (range * 1.0833 / 12.0), p.R1, precision: 4);
Assert.Equal(pC - (range * 1.0833 / 12.0), p.S1, precision: 4);
Assert.Equal(pC + (range * 1.1666 / 12.0), p.R2, precision: 4);
Assert.Equal(pC - (range * 1.1666 / 12.0), p.S2, precision: 4);
Assert.Equal(pC + (range * 1.25 / 12.0), p.R3, precision: 4);
Assert.Equal(pC - (range * 1.25 / 12.0), p.S3, precision: 4);
Assert.Equal(pC + (range * 1.5 / 12.0), p.R4, precision: 4);
Assert.Equal(pC - (range * 1.5 / 12.0), p.S4, precision: 4);
}
[Fact]
@@ -59,14 +59,14 @@ public sealed class PivotcamValidationTests
double range = pH - pL;
Assert.Equal(pp, p.PP, precision: 10);
Assert.Equal(pC + range * 1.0833 / 12.0, p.R1, precision: 4);
Assert.Equal(pC - range * 1.0833 / 12.0, p.S1, precision: 4);
Assert.Equal(pC + range * 1.1666 / 12.0, p.R2, precision: 4);
Assert.Equal(pC - range * 1.1666 / 12.0, p.S2, precision: 4);
Assert.Equal(pC + range * 1.25 / 12.0, p.R3, precision: 4);
Assert.Equal(pC - range * 1.25 / 12.0, p.S3, precision: 4);
Assert.Equal(pC + range * 1.5 / 12.0, p.R4, precision: 4);
Assert.Equal(pC - range * 1.5 / 12.0, p.S4, precision: 4);
Assert.Equal(pC + (range * 1.0833 / 12.0), p.R1, precision: 4);
Assert.Equal(pC - (range * 1.0833 / 12.0), p.S1, precision: 4);
Assert.Equal(pC + (range * 1.1666 / 12.0), p.R2, precision: 4);
Assert.Equal(pC - (range * 1.1666 / 12.0), p.S2, precision: 4);
Assert.Equal(pC + (range * 1.25 / 12.0), p.R3, precision: 4);
Assert.Equal(pC - (range * 1.25 / 12.0), p.S3, precision: 4);
Assert.Equal(pC + (range * 1.5 / 12.0), p.R4, precision: 4);
Assert.Equal(pC - (range * 1.5 / 12.0), p.S4, precision: 4);
}
}
}
@@ -272,5 +272,4 @@ public sealed class PivotcamValidationTests
}
}
}
}
@@ -64,7 +64,7 @@ public sealed class PivotdemIndicatorTests
var now = DateTime.UtcNow;
for (int i = 0; i < 10; i++)
{
double basePrice = 100 + i * 2;
double basePrice = 100 + (i * 2);
indicator.HistoricalData.AddBar(now.AddMinutes(i), basePrice, basePrice + 5, basePrice - 5, basePrice + 2);
var args = new UpdateArgs(UpdateReason.HistoricalBar);
@@ -36,9 +36,9 @@ public sealed class PivotdemValidationTests
double pC = bars[i - 1].Close;
double x;
if (pC < pO) { x = pH + 2.0 * pL + pC; }
else if (pC > pO) { x = 2.0 * pH + pL + pC; }
else { x = pH + pL + 2.0 * pC; }
if (pC < pO) { x = pH + (2.0 * pL) + pC; }
else if (pC > pO) { x = (2.0 * pH) + pL + pC; }
else { x = pH + pL + (2.0 * pC); }
double expectedPP = x * 0.25;
Assert.Equal(expectedPP, p.PP, precision: 10);
@@ -64,9 +64,9 @@ public sealed class PivotdemValidationTests
double pC = bars[i - 1].Close;
double x;
if (pC < pO) { x = pH + 2.0 * pL + pC; }
else if (pC > pO) { x = 2.0 * pH + pL + pC; }
else { x = pH + pL + 2.0 * pC; }
if (pC < pO) { x = pH + (2.0 * pL) + pC; }
else if (pC > pO) { x = (2.0 * pH) + pL + pC; }
else { x = pH + pL + (2.0 * pC); }
double halfX = x * 0.5;
Assert.Equal(x * 0.25, p.PP, precision: 10);
@@ -239,5 +239,4 @@ public sealed class PivotdemValidationTests
}
}
}
}
@@ -64,7 +64,7 @@ public sealed class PivotextIndicatorTests
var now = DateTime.UtcNow;
for (int i = 0; i < 10; i++)
{
double basePrice = 100 + i * 2;
double basePrice = 100 + (i * 2);
indicator.HistoricalData.AddBar(now.AddMinutes(i), basePrice, basePrice + 5, basePrice - 5, basePrice + 2);
var args = new UpdateArgs(UpdateReason.HistoricalBar);
@@ -125,16 +125,16 @@ public sealed class PivotextBasicTests
double hMinusPP = 120.0 - expectedPP;
Assert.Equal(expectedPP, p.PP, precision: 10);
Assert.Equal(2.0 * expectedPP - 100.0, p.R1, precision: 10);
Assert.Equal(2.0 * expectedPP - 120.0, p.S1, precision: 10);
Assert.Equal((2.0 * expectedPP) - 100.0, p.R1, precision: 10);
Assert.Equal((2.0 * expectedPP) - 120.0, p.S1, precision: 10);
Assert.Equal(expectedPP + 20.0, p.R2, precision: 10);
Assert.Equal(expectedPP - 20.0, p.S2, precision: 10);
Assert.Equal(120.0 + 2.0 * ppMinusL, p.R3, precision: 10);
Assert.Equal(100.0 - 2.0 * hMinusPP, p.S3, precision: 10);
Assert.Equal(120.0 + 3.0 * ppMinusL, p.R4, precision: 10);
Assert.Equal(100.0 - 3.0 * hMinusPP, p.S4, precision: 10);
Assert.Equal(120.0 + 4.0 * ppMinusL, p.R5, precision: 10);
Assert.Equal(100.0 - 4.0 * hMinusPP, p.S5, precision: 10);
Assert.Equal(120.0 + (2.0 * ppMinusL), p.R3, precision: 10);
Assert.Equal(100.0 - (2.0 * hMinusPP), p.S3, precision: 10);
Assert.Equal(120.0 + (3.0 * ppMinusL), p.R4, precision: 10);
Assert.Equal(100.0 - (3.0 * hMinusPP), p.S4, precision: 10);
Assert.Equal(120.0 + (4.0 * ppMinusL), p.R5, precision: 10);
Assert.Equal(100.0 - (4.0 * hMinusPP), p.S5, precision: 10);
}
[Fact]
@@ -60,16 +60,16 @@ public sealed class PivotextValidationTests
double hMinusPP = pH - pp;
Assert.Equal(pp, p.PP, precision: 10);
Assert.Equal(2.0 * pp - pL, p.R1, precision: 10);
Assert.Equal(2.0 * pp - pH, p.S1, precision: 10);
Assert.Equal((2.0 * pp) - pL, p.R1, precision: 10);
Assert.Equal((2.0 * pp) - pH, p.S1, precision: 10);
Assert.Equal(pp + range, p.R2, precision: 10);
Assert.Equal(pp - range, p.S2, precision: 10);
Assert.Equal(pH + 2.0 * ppMinusL, p.R3, precision: 10);
Assert.Equal(pL - 2.0 * hMinusPP, p.S3, precision: 10);
Assert.Equal(pH + 3.0 * ppMinusL, p.R4, precision: 10);
Assert.Equal(pL - 3.0 * hMinusPP, p.S4, precision: 10);
Assert.Equal(pH + 4.0 * ppMinusL, p.R5, precision: 10);
Assert.Equal(pL - 4.0 * hMinusPP, p.S5, precision: 10);
Assert.Equal(pH + (2.0 * ppMinusL), p.R3, precision: 10);
Assert.Equal(pL - (2.0 * hMinusPP), p.S3, precision: 10);
Assert.Equal(pH + (3.0 * ppMinusL), p.R4, precision: 10);
Assert.Equal(pL - (3.0 * hMinusPP), p.S4, precision: 10);
Assert.Equal(pH + (4.0 * ppMinusL), p.R5, precision: 10);
Assert.Equal(pL - (4.0 * hMinusPP), p.S5, precision: 10);
}
}
}
@@ -64,7 +64,7 @@ public sealed class PivotfibIndicatorTests
var now = DateTime.UtcNow;
for (int i = 0; i < 10; i++)
{
double basePrice = 100 + i * 2;
double basePrice = 100 + (i * 2);
indicator.HistoricalData.AddBar(now.AddMinutes(i), basePrice, basePrice + 5, basePrice - 5, basePrice + 2);
var args = new UpdateArgs(UpdateReason.HistoricalBar);
@@ -36,10 +36,10 @@ public sealed class PivotfibValidationTests
double range = pH - pL;
Assert.Equal(expectedPP, ind.PP, 10);
Assert.Equal(expectedPP + 0.382 * range, ind.R1, 10);
Assert.Equal(expectedPP - 0.382 * range, ind.S1, 10);
Assert.Equal(expectedPP + 0.618 * range, ind.R2, 10);
Assert.Equal(expectedPP - 0.618 * range, ind.S2, 10);
Assert.Equal(expectedPP + (0.382 * range), ind.R1, 10);
Assert.Equal(expectedPP - (0.382 * range), ind.S1, 10);
Assert.Equal(expectedPP + (0.618 * range), ind.R2, 10);
Assert.Equal(expectedPP - (0.618 * range), ind.S2, 10);
Assert.Equal(expectedPP + range, ind.R3, 10);
Assert.Equal(expectedPP - range, ind.S3, 10);
}
@@ -245,5 +245,4 @@ public sealed class PivotfibValidationTests
Assert.Equal(ind.R3 - ind.PP, ind.PP - ind.S3, 10);
}
}
}
@@ -64,7 +64,7 @@ public sealed class PivotwoodIndicatorTests
var now = DateTime.UtcNow;
for (int i = 0; i < 10; i++)
{
double basePrice = 100 + i * 2;
double basePrice = 100 + (i * 2);
indicator.HistoricalData.AddBar(now.AddMinutes(i), basePrice, basePrice + 5, basePrice - 5, basePrice + 2);
var args = new UpdateArgs(UpdateReason.HistoricalBar);
@@ -32,16 +32,16 @@ public sealed class PivotwoodValidationTests
double pL = bars[i - 1].Low;
double pC = bars[i - 1].Close;
double expectedPP = (pH + pL + 2.0 * pC) / 4.0;
double expectedPP = (pH + pL + (2.0 * pC)) / 4.0;
double range = pH - pL;
Assert.Equal(expectedPP, ind.PP, 10);
Assert.Equal(2.0 * expectedPP - pL, ind.R1, 10);
Assert.Equal(2.0 * expectedPP - pH, ind.S1, 10);
Assert.Equal((2.0 * expectedPP) - pL, ind.R1, 10);
Assert.Equal((2.0 * expectedPP) - pH, ind.S1, 10);
Assert.Equal(expectedPP + range, ind.R2, 10);
Assert.Equal(expectedPP - range, ind.S2, 10);
Assert.Equal(pH + 2.0 * (expectedPP - pL), ind.R3, 10);
Assert.Equal(pL - 2.0 * (pH - expectedPP), ind.S3, 10);
Assert.Equal(pH + (2.0 * (expectedPP - pL)), ind.R3, 10);
Assert.Equal(pL - (2.0 * (pH - expectedPP)), ind.S3, 10);
}
}
@@ -253,5 +253,4 @@ public sealed class PivotwoodValidationTests
}
}
}
}
+5 -5
View File
@@ -150,12 +150,12 @@ public sealed class PsarBasicTests
// Steady uptrend - SAR should trail below
for (int i = 0; i < 20; i++)
{
double price = 100.0 + i * 2;
double price = 100.0 + (i * 2);
_ = psar.Update(new TBar(DateTime.UtcNow.AddMinutes(i),
price + 1, price - 1, price + 0.5, price, 1000));
}
double lastClose = 100.0 + 19 * 2;
double lastClose = 100.0 + (19 * 2);
Assert.True(psar.Sar < lastClose, "SAR should be below price in uptrend");
Assert.True(psar.IsLong, "Should be in long mode during uptrend");
}
@@ -168,12 +168,12 @@ public sealed class PsarBasicTests
// Steady downtrend - SAR should trail above
for (int i = 0; i < 20; i++)
{
double price = 200.0 - i * 2;
double price = 200.0 - (i * 2);
_ = psar.Update(new TBar(DateTime.UtcNow.AddMinutes(i),
price + 1, price - 1, price + 0.5, price, 1000));
}
double lastClose = 200.0 - 19 * 2;
double lastClose = 200.0 - (19 * 2);
Assert.True(psar.Sar > lastClose, "SAR should be above price in downtrend");
Assert.False(psar.IsLong, "Should be in short mode during downtrend");
}
@@ -423,7 +423,7 @@ public sealed class PsarConsistencyTests
// Continue uptrend
for (int i = 1; i <= 5; i++)
{
double price = 105 + i * 2;
double price = 105 + (i * 2);
_ = psar.Update(new TBar(dt.AddMinutes(i),
price + 1, price - 1, price + 0.5, price, 1000), isNew: true);
}
+1 -1
View File
@@ -114,7 +114,7 @@ public sealed class SwingsBasicTests
// Monotone ascending - no swing high or low
for (int i = 0; i < 5; i++)
{
double price = 100.0 + i * 5;
double price = 100.0 + (i * 5);
_ = sw.Update(new TBar(dt.AddMinutes(i), price, price + 2, price - 2, price + 1, 1000), isNew: true);
}
@@ -102,7 +102,7 @@ public sealed class SwingsValidationTests
int lookback = 3;
Swings.Batch(bars.HighValues, bars.LowValues, spanHigh, spanLow, lookback);
int windowSize = 2 * lookback + 1;
int windowSize = (2 * lookback) + 1;
for (int i = windowSize - 1; i < bars.Count; i++)
{
if (double.IsNaN(spanHigh[i]))
@@ -139,7 +139,7 @@ public sealed class SwingsValidationTests
int lookback = 3;
Swings.Batch(bars.HighValues, bars.LowValues, spanHigh, spanLow, lookback);
int windowSize = 2 * lookback + 1;
int windowSize = (2 * lookback) + 1;
for (int i = windowSize - 1; i < bars.Count; i++)
{
if (double.IsNaN(spanLow[i]))
@@ -101,7 +101,7 @@ public sealed class TtmScalperBasicTests
// Monotone ascending — no pivot
for (int i = 0; i < 3; i++)
{
double price = 100.0 + i * 5;
double price = 100.0 + (i * 5);
_ = ts.Update(new TBar(dt.AddMinutes(i), price, price + 2, price - 2, price + 1, 1000), isNew: true);
}