From 8e43d62cbb6f2f6da67fc4619d09362b945fbc88 Mon Sep 17 00:00:00 2001 From: Miha Kralj Date: Wed, 4 Mar 2026 17:54:25 -0800 Subject: [PATCH] fix: move Roslyn SARIF upload from Sonar_Analysis to ReSharper_Analysis SonarScanner wrapper overrides ErrorLog MSBuild property, preventing Roslyn SARIF generation. ReSharper_Analysis already builds without SonarScanner wrapping, so ErrorLog works correctly there. --- .github/workflows/Publish.yml | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/.github/workflows/Publish.yml b/.github/workflows/Publish.yml index 1e4afae9..fe858258 100644 --- a/.github/workflows/Publish.yml +++ b/.github/workflows/Publish.yml @@ -107,6 +107,17 @@ jobs: path: .sarif/resharper.sarif retention-days: 7 + - name: Upload Roslyn SARIF artifacts + if: always() + uses: actions/upload-artifact@v4 + with: + name: sarif-roslyn + path: | + .sarif/*.sarif + !.sarif/resharper.sarif + retention-days: 7 + if-no-files-found: warn + # ============================================================================== # 2) Snyk Security Scan -> SARIF artifact # ============================================================================== @@ -438,20 +449,8 @@ jobs: path: coverage-merged/ retention-days: 7 - - name: List Roslyn SARIF files - if: always() - run: | - echo "Roslyn SARIF files generated (per-project, SARIF 2.1):" - ls -la .sarif/*.sarif 2>/dev/null || echo "No SARIF files found" - - - name: Upload Roslyn SARIF Artifacts - if: always() - uses: actions/upload-artifact@v4 - with: - name: sarif-roslyn - path: .sarif/*.sarif - retention-days: 7 - if-no-files-found: warn + # Roslyn SARIF artifacts are uploaded by ReSharper_Analysis job + # (which builds without SonarScanner wrapper that can suppress ErrorLog output) # ============================================================================== # 5) GitHub Code Scanning Upload (SARIF → Security tab)