gavindiaz/QuanTAlib
1
0
Fork 0
mirror of https://github.com/mihakralj/QuanTAlib.git synced 2026-08-19 11:08:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor IndicatorExtensions: Remove unused methods and optimize price retrieval

Browse Source
This commit is contained in:
Miha Kralj
2025-12-24 13:50:19 -08:00
parent c47b106597
commit 8917575994
101 changed files with 1311 additions and 450292 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/volume/adosc/Adosc.Quantower.Tests.cs
+15 -11
View File
@@ -20,24 +20,28 @@ public class AdoscIndicatorTests
}
[Fact]
public void AdoscIndicator_MinHistoryDepths_EqualsSlowPeriod()
public void AdoscIndicator_MinHistoryDepths_EqualsZero()
{
var indicator = new AdoscIndicator { SlowPeriod = 20 };
var indicator = new AdoscIndicator
{
SlowPeriod = 20
};
Assert.Equal(20, indicator.MinHistoryDepths);
Assert.Equal(0, AdoscIndicator.MinHistoryDepths);
IWatchlistIndicator watchlistIndicator = indicator;
Assert.Equal(20, watchlistIndicator.MinHistoryDepths);
Assert.Equal(0, watchlistIndicator.MinHistoryDepths);
}
[Fact]
public void AdoscIndicator_ShortName_IncludesParameters()
public void AdoscIndicator_SlowPeriod_CanBeChanged()
{
var indicator = new AdoscIndicator { FastPeriod = 10, SlowPeriod = 40 };
indicator.Initialize();
var indicator = new AdoscIndicator
{
SlowPeriod = 40
};
Assert.Contains("ADOSC", indicator.ShortName);
Assert.Contains("10", indicator.ShortName);
Assert.Contains("40", indicator.ShortName);
Assert.Equal(40, indicator.SlowPeriod);
Assert.Equal(0, AdoscIndicator.MinHistoryDepths);
}
[Fact]
@@ -117,6 +121,6 @@ public class AdoscIndicatorTests
Assert.Equal(10, indicator.FastPeriod);
Assert.Equal(40, indicator.SlowPeriod);
Assert.Equal(40, indicator.MinHistoryDepths);
Assert.Equal(0, AdoscIndicator.MinHistoryDepths);
}
}
lib/volume/adosc/Adosc.Quantower.cs
+11 -14
View File
@@ -1,9 +1,11 @@
using System.Drawing;
using System.Runtime.CompilerServices;
using TradingPlatform.BusinessLayer;
namespace QuanTAlib;
public class AdoscIndicator : Indicator, IWatchlistIndicator
[SkipLocalsInit]
public sealed class AdoscIndicator : Indicator, IWatchlistIndicator
{
[InputParameter("Fast Period", sortIndex: 1, 1, 1000, 1, 0)]
public int FastPeriod { get; set; } = 3;
@@ -15,9 +17,9 @@ public class AdoscIndicator : Indicator, IWatchlistIndicator
public bool ShowColdValues { get; set; } = true;
private Adosc? _adosc;
protected LineSeries? Series;
private readonly LineSeries? _series;
public int MinHistoryDepths => SlowPeriod;
public static int MinHistoryDepths => 0;
int IWatchlistIndicator.MinHistoryDepths => MinHistoryDepths;
public override string ShortName => $"ADOSC {FastPeriod}:{SlowPeriod}";
@@ -30,28 +32,23 @@ public class AdoscIndicator : Indicator, IWatchlistIndicator
Name = "ADOSC - Accumulation/Distribution Oscillator";
Description = "Momentum indicator for the Accumulation/Distribution Line";
Series = new(name: "ADOSC", color: Color.Orange, width: 2, style: LineStyle.Solid);
AddLineSeries(Series);
_series = new(name: "ADOSC", color: Color.Orange, width: 2, style: LineStyle.Solid);
AddLineSeries(_series);
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
protected override void OnInit()
{
_adosc = new Adosc(FastPeriod, SlowPeriod);
base.OnInit();
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
protected override void OnUpdate(UpdateArgs args)
{
bool isNew = args.Reason == UpdateReason.NewBar || args.Reason == UpdateReason.HistoricalBar;
TBar bar = this.GetInputBar(args);
TValue result = _adosc!.Update(bar, isNew);
TValue result = _adosc!.Update(bar, args.IsNewBar());
if (!_adosc.IsHot && !ShowColdValues)
{
return;
}
Series!.SetValue(result.Value);
_series!.SetValue(result.Value, _adosc.IsHot, ShowColdValues);
}
}