gavindiaz/QuanTAlib
1
0
Fork 0
mirror of https://github.com/mihakralj/QuanTAlib.git synced 2026-08-24 05:28:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor IndicatorExtensions: Remove unused methods and optimize price retrieval

Browse Source
This commit is contained in:
Miha Kralj
2025-12-24 13:50:19 -08:00
parent c47b106597
commit 8917575994
101 changed files with 1311 additions and 450292 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/trends/mgdi/Mgdi.Quantower.Tests.cs
+1 -1
View File
@@ -13,7 +13,7 @@ public class MgdiIndicatorTests
var indicator = new MgdiIndicator();
Assert.Equal("MGDI - McGinley Dynamic Indicator", indicator.Name);
Assert.Equal("MGDI(14,0.6):Close", indicator.ShortName);
Assert.Equal(14, indicator.MinHistoryDepths);
Assert.Equal(0, MgdiIndicator.MinHistoryDepths);
Assert.Single(indicator.LinesSeries);
}
lib/trends/mgdi/Mgdi.Quantower.cs
+19 -28
View File
@@ -1,15 +1,17 @@
using System;
using System.Drawing;
using System.Runtime.CompilerServices;
using TradingPlatform.BusinessLayer;
namespace QuanTAlib;
public class MgdiIndicator : Indicator, IWatchlistIndicator
[SkipLocalsInit]
public sealed class MgdiIndicator : Indicator, IWatchlistIndicator
{
[InputParameter("Period", sortIndex: 1, 1, 2000, 1, 0)]
public int Period { get; set; } = 14;
[InputParameter("K Factor", sortIndex: 2, 0.1, 10, 0.1, 1)]
[InputParameter("K Factor", sortIndex: 2, 0.1, 10.0, 0.1, 1)]
public double K { get; set; } = 0.6;
[IndicatorExtensions.DataSourceInput]
@@ -19,51 +21,40 @@ public class MgdiIndicator : Indicator, IWatchlistIndicator
public bool ShowColdValues { get; set; } = true;
private Mgdi? _mgdi;
protected LineSeries? Series;
protected string? SourceName;
private int _warmupBarIndex = -1;
private readonly LineSeries? _series;
private string? _sourceName;
private Func<IHistoryItem, double>? _priceSelector;
public int MinHistoryDepths => Period;
public static int MinHistoryDepths => 0;
int IWatchlistIndicator.MinHistoryDepths => MinHistoryDepths;
public override string ShortName => $"MGDI({Period},{K}):{SourceName}";
public override string ShortName => $"MGDI({Period},{K}):{_sourceName}";
public MgdiIndicator()
{
OnBackGround = true;
SeparateWindow = false;
SourceName = Source.ToString();
_sourceName = Source.ToString();
Name = "MGDI - McGinley Dynamic Indicator";
Description = "McGinley Dynamic Indicator";
Series = new(name: "MGDI", color: Color.Orange, width: 2, style: LineStyle.Solid);
AddLineSeries(Series);
_series = new(name: $"MGDI {Period}", color: IndicatorExtensions.Averages, width: 2, style: LineStyle.Solid);
AddLineSeries(_series);
}
protected override void OnInit()
{
_priceSelector = Source.GetPriceSelector();
_sourceName = Source.ToString();
_mgdi = new Mgdi(Period, K);
SourceName = Source.ToString();
_warmupBarIndex = -1;
base.OnInit();
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
protected override void OnUpdate(UpdateArgs args)
{
TValue input = this.GetInputValue(args, Source);
bool isNew = args.Reason == UpdateReason.NewBar || args.Reason == UpdateReason.HistoricalBar;
TValue result = _mgdi!.Update(input, isNew);
Series!.SetValue(result.Value);
Series!.SetMarker(0, Color.Transparent);
if (_warmupBarIndex < 0 && _mgdi.IsHot)
_warmupBarIndex = Count;
}
public override void OnPaintChart(PaintChartEventArgs args)
{
base.OnPaintChart(args);
int warmupPeriod = _warmupBarIndex > 0 ? _warmupBarIndex : Count;
this.PaintSmoothCurve(args, Series!, warmupPeriod, showColdValues: ShowColdValues, tension: 0.2);
bool isNew = args.IsNewBar();
var item = HistoricalData[Count - 1, SeekOriginHistory.Begin];
double value = _mgdi!.Update(new TValue(item.TimeLeft.Ticks, _priceSelector!(item)), isNew).Value;
_series!.SetValue(value, _mgdi.IsHot, ShowColdValues);
}
}