gavindiaz/QuanTAlib
1
0
Fork 0
mirror of https://github.com/mihakralj/QuanTAlib.git synced 2026-08-20 03:28:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor IndicatorExtensions: Remove unused methods and optimize price retrieval

Browse Source
This commit is contained in:
Miha Kralj
2025-12-24 13:50:19 -08:00
parent c47b106597
commit 8917575994
101 changed files with 1311 additions and 450292 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/trends/conv/Conv.Quantower.Tests.cs
+2 -12
View File
@@ -24,8 +24,8 @@ public class ConvIndicatorTests
var indicator = new ConvIndicator { WeightsInput = "1, 2, 3, 4, 5" };
indicator.Initialize(); // Initialize to parse weights
Assert.Equal(5, indicator.MinHistoryDepths);
Assert.Equal(5, ((IWatchlistIndicator)indicator).MinHistoryDepths);
Assert.Equal(0, ConvIndicator.MinHistoryDepths);
Assert.Equal(0, ((IWatchlistIndicator)indicator).MinHistoryDepths);
}
[Fact]
@@ -112,16 +112,6 @@ public class ConvIndicatorTests
Assert.True(double.IsFinite(secondValue));
}
[Fact]
public void ConvIndicator_OnPaintChart_DoesNotThrow()
{
var indicator = new ConvIndicator();
indicator.Initialize();
var method = indicator.GetType().GetMethod("OnPaintChart");
Assert.NotNull(method);
Assert.Equal(typeof(ConvIndicator), method.DeclaringType);
}
[Fact]
public void ConvIndicator_MultipleUpdates_ProducesCorrectSequence()
lib/trends/conv/Conv.Quantower.cs
+10 -17
View File
@@ -1,10 +1,10 @@
using System;
using System.Drawing;
using System.Linq;
using System.Runtime.CompilerServices;
using TradingPlatform.BusinessLayer;
namespace QuanTAlib;
[SkipLocalsInit]
public class ConvIndicator : Indicator, IWatchlistIndicator
{
[InputParameter("Weights (comma separated)", sortIndex: 1)]
@@ -17,11 +17,11 @@ public class ConvIndicator : Indicator, IWatchlistIndicator
public bool ShowColdValues { get; set; } = true;
private Conv? _conv;
private int _warmupBarIndex = -1;
protected LineSeries? Series;
protected string? SourceName;
private Func<IHistoryItem, double>? _priceSelector;
public int MinHistoryDepths => _conv != null ? WeightsInput.Split(',').Length : 0;
public static int MinHistoryDepths => 0;
int IWatchlistIndicator.MinHistoryDepths => MinHistoryDepths;
public override string ShortName => $"CONV:{SourceName}";
@@ -60,25 +60,18 @@ public class ConvIndicator : Indicator, IWatchlistIndicator
_conv = new Conv([1.0]);
}
_warmupBarIndex = -1;
SourceName = Source.ToString();
_priceSelector = Source.GetPriceSelector();
base.OnInit();
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
protected override void OnUpdate(UpdateArgs args)
{
TValue input = this.GetInputValue(args, Source);
bool isNew = args.Reason == UpdateReason.NewBar || args.Reason == UpdateReason.HistoricalBar;
TValue result = _conv!.Update(input, isNew);
if (_warmupBarIndex < 0 && _conv!.IsHot)
_warmupBarIndex = Count;
Series!.SetValue(result.Value);
Series!.SetMarker(0, Color.Transparent); //OnPaintChart draws the line, hidden here
}
var item = HistoricalData[Count - 1, SeekOriginHistory.Begin];
TValue result = _conv!.Update(new TValue(item.TimeLeft.Ticks, _priceSelector!(item)), isNew: args.IsNewBar());
public override void OnPaintChart(PaintChartEventArgs args)
{
base.OnPaintChart(args);
this.PaintSmoothCurve(args, Series!, _warmupBarIndex, showColdValues: ShowColdValues, tension: 0.2);
Series!.SetValue(result.Value, _conv.IsHot, ShowColdValues);
}
}