SIMD Refactor: Merge simd-dev into dev (#55)

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: aider (openrouter/anthropic/claude-sonnet-4) <aider@aider.chat>
Co-authored-by: Warp <agent@warp.dev>
This commit is contained in:
Miha Kralj
2026-01-18 19:02:03 -08:00
committed by GitHub
co-authored by Claude Opus 4.5 aider Warp
parent 5bcdf8d614
commit 86fe32a682
1750 changed files with 198235 additions and 80539 deletions
@@ -0,0 +1,88 @@
using TradingPlatform.BusinessLayer;
using QuanTAlib;
namespace QuanTAlib.Tests;
public class AroonIndicatorTests
{
[Fact]
public void AroonIndicator_Constructor_SetsDefaults()
{
var indicator = new AroonIndicator();
Assert.Equal(14, indicator.Period);
Assert.True(indicator.ShowColdValues);
Assert.Equal("Aroon", indicator.Name);
Assert.True(indicator.SeparateWindow);
Assert.True(indicator.OnBackGround);
}
[Fact]
public void AroonIndicator_MinHistoryDepths_EqualsZero()
{
var indicator = new AroonIndicator { Period = 20 };
Assert.Equal(0, AroonIndicator.MinHistoryDepths);
IWatchlistIndicator watchlistIndicator = indicator;
Assert.Equal(0, watchlistIndicator.MinHistoryDepths);
}
[Fact]
public void AroonIndicator_ShortName_IncludesParameters()
{
var indicator = new AroonIndicator { Period = 20 };
indicator.Initialize();
Assert.Contains("Aroon", indicator.ShortName, StringComparison.Ordinal);
Assert.Contains("20", indicator.ShortName, StringComparison.Ordinal);
}
[Fact]
public void AroonIndicator_SourceCodeLink_IsValid()
{
var indicator = new AroonIndicator();
Assert.Contains("github.com", indicator.SourceCodeLink, StringComparison.Ordinal);
Assert.Contains("Aroon.Quantower.cs", indicator.SourceCodeLink, StringComparison.Ordinal);
}
[Fact]
public void AroonIndicator_Initialize_CreatesInternalAroon()
{
var indicator = new AroonIndicator { Period = 14 };
// Initialize should not throw
indicator.Initialize();
// After init, line series should exist (Up, Down, Osc)
Assert.Equal(3, indicator.LinesSeries.Count);
}
[Fact]
public void AroonIndicator_ProcessUpdate_HistoricalBar_ComputesValue()
{
var indicator = new AroonIndicator { Period = 5 };
indicator.Initialize();
// Add historical data
var now = DateTime.UtcNow;
// Need enough bars for Period
for (int i = 0; i < 20; i++)
{
indicator.HistoricalData.AddBar(now.AddMinutes(i), 100 + i, 110 + i, 90 + i, 105 + i);
// Process update for each bar to simulate history loading
var args = new UpdateArgs(UpdateReason.HistoricalBar);
indicator.ProcessUpdate(args);
}
// Line series should have a value
double up = indicator.LinesSeries[0].GetValue(0);
double down = indicator.LinesSeries[1].GetValue(0);
double osc = indicator.LinesSeries[2].GetValue(0);
Assert.True(double.IsFinite(up));
Assert.True(double.IsFinite(down));
Assert.True(double.IsFinite(osc));
}
}
+59
View File
@@ -0,0 +1,59 @@
using System.Drawing;
using System.Runtime.CompilerServices;
using TradingPlatform.BusinessLayer;
namespace QuanTAlib;
[SkipLocalsInit]
public sealed class AroonIndicator : Indicator, IWatchlistIndicator
{
[InputParameter("Period", sortIndex: 1, 1, 1000, 1, 0)]
public int Period { get; set; } = 14;
[InputParameter("Show cold values", sortIndex: 21)]
public bool ShowColdValues { get; set; } = true;
private Aroon _aroon = null!;
private readonly LineSeries _upSeries;
private readonly LineSeries _downSeries;
private readonly LineSeries _oscSeries;
public static int MinHistoryDepths => 0;
int IWatchlistIndicator.MinHistoryDepths => MinHistoryDepths;
public override string ShortName => $"Aroon {Period}";
public override string SourceCodeLink => "https://github.com/mihakralj/QuanTAlib/blob/main/lib/momentum/aroon/Aroon.Quantower.cs";
public AroonIndicator()
{
OnBackGround = true;
SeparateWindow = true;
Name = "Aroon";
Description = "Identifies trend changes and strength";
_upSeries = new LineSeries(name: "Aroon Up", color: Color.Green, width: 1, style: LineStyle.Solid);
_downSeries = new LineSeries(name: "Aroon Down", color: Color.Red, width: 1, style: LineStyle.Solid);
_oscSeries = new LineSeries(name: "Aroon Osc", color: Color.Blue, width: 2, style: LineStyle.Solid);
AddLineSeries(_upSeries);
AddLineSeries(_downSeries);
AddLineSeries(_oscSeries);
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
protected override void OnInit()
{
_aroon = new Aroon(Period);
base.OnInit();
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
protected override void OnUpdate(UpdateArgs args)
{
TValue result = _aroon.Update(this.GetInputBar(args), args.IsNewBar());
_upSeries.SetValue(_aroon.Up.Value, _aroon.IsHot, ShowColdValues);
_downSeries.SetValue(_aroon.Down.Value, _aroon.IsHot, ShowColdValues);
_oscSeries.SetValue(result.Value, _aroon.IsHot, ShowColdValues);
}
}
+295
View File
@@ -0,0 +1,295 @@
namespace QuanTAlib;
public class AroonTests
{
[Fact]
public void BasicCalculation_DoesNotCrash()
{
var aroon = new Aroon(14);
var gbm = new GBM();
var bars = gbm.Fetch(1000, DateTime.UtcNow.Ticks, TimeSpan.FromMinutes(1));
for (int i = 0; i < bars.Count; i++)
{
aroon.Update(bars[i]);
}
Assert.True(double.IsFinite(aroon.Last.Value));
Assert.True(double.IsFinite(aroon.Up.Value));
Assert.True(double.IsFinite(aroon.Down.Value));
}
[Fact]
public void IsNew_Consistency()
{
var aroon = new Aroon(14);
var gbm = new GBM();
var bars = gbm.Fetch(100, DateTime.UtcNow.Ticks, TimeSpan.FromMinutes(1));
// Feed first 99
for (int i = 0; i < 99; i++)
{
aroon.Update(bars[i]);
}
// Update with 100th point (isNew=true)
aroon.Update(bars[99], true);
// Update with modified 100th point (isNew=false)
var modifiedBar = new TBar(bars[99].Time, bars[99].Open, bars[99].High + 10.0, bars[99].Low - 10.0, bars[99].Close, bars[99].Volume);
var val2 = aroon.Update(modifiedBar, false);
// Create new instance and feed up to modified
var aroon2 = new Aroon(14);
for (int i = 0; i < 99; i++)
{
aroon2.Update(bars[i]);
}
var val3 = aroon2.Update(modifiedBar, true);
Assert.Equal(val3.Value, val2.Value, 1e-9);
Assert.Equal(aroon2.Up.Value, aroon.Up.Value, 1e-9);
Assert.Equal(aroon2.Down.Value, aroon.Down.Value, 1e-9);
}
[Fact]
public void Reset_Works()
{
var aroon = new Aroon(14);
var gbm = new GBM();
var bars = gbm.Fetch(100, DateTime.UtcNow.Ticks, TimeSpan.FromMinutes(1));
for (int i = 0; i < bars.Count; i++)
{
aroon.Update(bars[i]);
}
aroon.Reset();
Assert.Equal(0, aroon.Last.Value);
Assert.False(aroon.IsHot);
// Feed again
for (int i = 0; i < bars.Count; i++)
{
aroon.Update(bars[i]);
}
Assert.True(double.IsFinite(aroon.Last.Value));
}
[Fact]
public void TBarSeries_Update_Matches_Streaming()
{
var aroon = new Aroon(14);
var gbm = new GBM();
var bars = gbm.Fetch(200, DateTime.UtcNow.Ticks, TimeSpan.FromMinutes(1));
var streamingResults = new List<double>();
for (int i = 0; i < bars.Count; i++)
{
streamingResults.Add(aroon.Update(bars[i]).Value);
}
var aroon2 = new Aroon(14);
var seriesResults = aroon2.Update(bars);
Assert.Equal(streamingResults.Count, seriesResults.Count);
for (int i = 0; i < seriesResults.Count; i++)
{
Assert.Equal(streamingResults[i], seriesResults.Values[i], 1e-9);
}
}
[Fact]
public void StaticCalculate_Matches_Streaming()
{
var gbm = new GBM();
var bars = gbm.Fetch(200, DateTime.UtcNow.Ticks, TimeSpan.FromMinutes(1));
var aroon = new Aroon(14);
var streamingResults = new List<double>();
for (int i = 0; i < bars.Count; i++)
{
streamingResults.Add(aroon.Update(bars[i]).Value);
}
var staticResults = Aroon.Batch(bars, 14);
Assert.Equal(streamingResults.Count, staticResults.Count);
for (int i = 0; i < staticResults.Count; i++)
{
Assert.Equal(streamingResults[i], staticResults.Values[i], 1e-9);
}
}
[Fact]
public void Constructor_InvalidParameters_ThrowsArgumentException()
{
Assert.Throws<ArgumentException>(() => new Aroon(0));
Assert.Throws<ArgumentException>(() => new Aroon(-1));
}
[Fact]
public void ManualCalculation_Verify()
{
// Simple manual test
// Period = 2
// Highs: 10, 12, 11
// Lows: 8, 9, 7
// T=0: H=10, L=8. Not enough data.
// T=1: H=12, L=9. Not enough data.
// T=2: H=11, L=7.
// Window Highs: [10, 12, 11]. Max is 12 at index 1 (1 day ago).
// Window Lows: [8, 9, 7]. Min is 7 at index 2 (0 days ago).
// Up = ((2 - 1) / 2) * 100 = 50
// Down = ((2 - 0) / 2) * 100 = 100
// Osc = 50 - 100 = -50
var aroon = new Aroon(2);
var time = DateTime.UtcNow;
aroon.Update(new TBar(time, 10, 10, 8, 9, 100));
aroon.Update(new TBar(time.AddMinutes(1), 11, 12, 9, 10, 100));
var result = aroon.Update(new TBar(time.AddMinutes(2), 10, 11, 7, 8, 100));
Assert.Equal(50.0, aroon.Up.Value, 1e-9);
Assert.Equal(100.0, aroon.Down.Value, 1e-9);
Assert.Equal(-50.0, result.Value, 1e-9);
}
[Fact]
public void IterativeCorrections_RestoreToOriginalState()
{
var aroon = new Aroon(5);
var gbm = new GBM(startPrice: 100.0, mu: 0.02, sigma: 0.1);
// Feed 20 new values
TBar twentiethInput = default;
for (int i = 0; i < 20; i++)
{
var bar = gbm.Next(isNew: true);
twentiethInput = bar;
aroon.Update(bar, isNew: true);
}
// Remember state after 20 values
double stateAfterTwenty = aroon.Last.Value;
double upAfterTwenty = aroon.Up.Value;
double downAfterTwenty = aroon.Down.Value;
// Generate 9 corrections with isNew=false (different values)
for (int i = 0; i < 9; i++)
{
var bar = gbm.Next(isNew: false);
aroon.Update(bar, isNew: false);
}
// Feed the remembered 20th input again with isNew=false
TValue finalResult = aroon.Update(twentiethInput, isNew: false);
// State should match the original state after 20 values
Assert.Equal(stateAfterTwenty, finalResult.Value, 1e-10);
Assert.Equal(upAfterTwenty, aroon.Up.Value, 1e-10);
Assert.Equal(downAfterTwenty, aroon.Down.Value, 1e-10);
}
[Fact]
public void IsHot_BecomesTrueWhenBufferFull()
{
var aroon = new Aroon(5);
var gbm = new GBM();
Assert.False(aroon.IsHot);
// Feed bars until IsHot becomes true
int count = 0;
while (!aroon.IsHot && count < 50)
{
var bar = gbm.Next(isNew: true);
aroon.Update(bar, isNew: true);
count++;
}
Assert.True(aroon.IsHot);
Assert.True(count >= 5); // Should take at least period bars
}
[Fact]
public void NaN_Input_UsesLastValidValue()
{
var aroon = new Aroon(5);
var gbm = new GBM();
var bars = gbm.Fetch(20, DateTime.UtcNow.Ticks, TimeSpan.FromMinutes(1));
// Feed some valid bars first
for (int i = 0; i < 15; i++)
{
aroon.Update(bars[i]);
}
// Create a bar with NaN values
var nanBar = new TBar(DateTime.UtcNow, double.NaN, double.NaN, double.NaN, double.NaN, double.NaN);
var result = aroon.Update(nanBar);
// Should not crash and should return a finite value
Assert.True(double.IsFinite(result.Value));
Assert.True(double.IsFinite(aroon.Up.Value));
Assert.True(double.IsFinite(aroon.Down.Value));
}
[Fact]
public void Infinity_Input_UsesLastValidValue()
{
var aroon = new Aroon(5);
var gbm = new GBM();
var bars = gbm.Fetch(20, DateTime.UtcNow.Ticks, TimeSpan.FromMinutes(1));
// Feed some valid bars first
for (int i = 0; i < 15; i++)
{
aroon.Update(bars[i]);
}
// Create a bar with Infinity values
var infBar = new TBar(DateTime.UtcNow, double.PositiveInfinity, double.PositiveInfinity, double.NegativeInfinity, double.PositiveInfinity, double.PositiveInfinity);
var result = aroon.Update(infBar);
// Should not crash and should return a finite value
Assert.True(double.IsFinite(result.Value));
Assert.True(double.IsFinite(aroon.Up.Value));
Assert.True(double.IsFinite(aroon.Down.Value));
}
[Fact]
public void AllModes_ProduceSameResult()
{
// Arrange
const int period = 14;
var gbm = new GBM(startPrice: 100, mu: 0.05, sigma: 0.2, seed: 123);
var bars = gbm.Fetch(100, DateTime.UtcNow.Ticks, TimeSpan.FromMinutes(1));
// 1. Batch Mode (static method)
var batchSeries = Aroon.Batch(bars, period);
double expected = batchSeries.Last.Value;
// 2. Streaming Mode (instance, one bar at a time)
var streamingInd = new Aroon(period);
for (int i = 0; i < bars.Count; i++)
{
streamingInd.Update(bars[i]);
}
double streamingResult = streamingInd.Last.Value;
// 3. Instance Update with TBarSeries
var instanceInd = new Aroon(period);
var instanceResult = instanceInd.Update(bars);
double instanceValue = instanceResult.Last.Value;
// Assert all modes produce identical results
Assert.Equal(expected, streamingResult, precision: 9);
Assert.Equal(expected, instanceValue, precision: 9);
}
}
@@ -0,0 +1,134 @@
using Skender.Stock.Indicators;
using TALib;
using QuanTAlib.Tests;
namespace QuanTAlib;
public sealed class AroonValidationTests : IDisposable
{
private readonly ValidationTestData _data;
public AroonValidationTests()
{
_data = new ValidationTestData();
}
public void Dispose()
{
_data.Dispose();
}
[Fact]
public void MatchesSkender()
{
var aroon = new Aroon(14);
var results = new List<double>();
var upResults = new List<double>();
var downResults = new List<double>();
for (int i = 0; i < _data.Bars.Count; i++)
{
var res = aroon.Update(_data.Bars[i]);
results.Add(res.Value);
upResults.Add(aroon.Up.Value);
downResults.Add(aroon.Down.Value);
}
var skenderResults = _data.SkenderQuotes.GetAroon(14).ToList();
// Verify Oscillator
ValidationHelper.VerifyData(results, skenderResults, x => x.Oscillator);
// Verify Up
ValidationHelper.VerifyData(upResults, skenderResults, x => x.AroonUp);
// Verify Down
ValidationHelper.VerifyData(downResults, skenderResults, x => x.AroonDown);
}
[Fact]
public void MatchesTalib()
{
var aroon = new Aroon(14);
var results = new List<double>();
var upResults = new List<double>();
var downResults = new List<double>();
for (int i = 0; i < _data.Bars.Count; i++)
{
var res = aroon.Update(_data.Bars[i]);
results.Add(res.Value);
upResults.Add(aroon.Up.Value);
downResults.Add(aroon.Down.Value);
}
double[] hData = _data.Bars.High.Select(x => x.Value).ToArray();
double[] lData = _data.Bars.Low.Select(x => x.Value).ToArray();
double[] outAroonUp = new double[_data.Bars.Count];
double[] outAroonDown = new double[_data.Bars.Count];
double[] outAroonOsc = new double[_data.Bars.Count];
// TA-Lib Aroon (Up/Down)
var retCode = TALib.Functions.Aroon(hData, lData, 0..^0, outAroonDown, outAroonUp, out var outRange, 14);
Assert.Equal(Core.RetCode.Success, retCode);
// TA-Lib AroonOsc
var retCodeOsc = TALib.Functions.AroonOsc(hData, lData, 0..^0, outAroonOsc, out var outRangeOsc, 14);
Assert.Equal(Core.RetCode.Success, retCodeOsc);
int lookback = TALib.Functions.AroonLookback(14);
// Verify Up
ValidationHelper.VerifyData(upResults, outAroonUp, outRange, lookback);
// Verify Down
ValidationHelper.VerifyData(downResults, outAroonDown, outRange, lookback);
// Verify Oscillator
ValidationHelper.VerifyData(results, outAroonOsc, outRangeOsc, lookback);
}
[Fact]
public void MatchesTulip()
{
var aroon = new Aroon(14);
var results = new List<double>();
var upResults = new List<double>();
var downResults = new List<double>();
for (int i = 0; i < _data.Bars.Count; i++)
{
var res = aroon.Update(_data.Bars[i]);
results.Add(res.Value);
upResults.Add(aroon.Up.Value);
downResults.Add(aroon.Down.Value);
}
double[] hData = _data.Bars.High.Select(x => x.Value).ToArray();
double[] lData = _data.Bars.Low.Select(x => x.Value).ToArray();
double[][] inputs = { hData, lData };
double[] options = { 14 };
// Tulip Aroon (Down, Up) - Note: Tulip returns Down then Up
var aroonInd = Tulip.Indicators.aroon;
double[][] outputs = { new double[hData.Length - 14], new double[hData.Length - 14] };
aroonInd.Run(inputs, options, outputs);
double[] tulipDown = outputs[0];
double[] tulipUp = outputs[1];
// Tulip AroonOsc
var aroonOscInd = Tulip.Indicators.aroonosc;
double[][] outputsOsc = { new double[hData.Length - 14] };
aroonOscInd.Run(inputs, options, outputsOsc);
double[] tulipOsc = outputsOsc[0];
// Verify Up
ValidationHelper.VerifyData(upResults, tulipUp, lookback: 14);
// Verify Down
ValidationHelper.VerifyData(downResults, tulipDown, lookback: 14);
// Verify Oscillator
ValidationHelper.VerifyData(results, tulipOsc, lookback: 14);
}
}
+307
View File
@@ -0,0 +1,307 @@
using System.Buffers;
using System.Runtime.CompilerServices;
namespace QuanTAlib;
/// <summary>
/// Aroon Indicator
/// </summary>
/// <remarks>
/// The Aroon indicator is used to identify trend changes in the price of an asset, as well as the strength of that trend.
/// It consists of two lines: Aroon Up and Aroon Down.
///
/// Calculation:
/// Aroon Up = ((Period - Days Since Period High) / Period) * 100
/// Aroon Down = ((Period - Days Since Period Low) / Period) * 100
/// Aroon Oscillator = Aroon Up - Aroon Down
///
/// The indicator requires Period + 1 samples to fully calculate "Period" days ago.
///
/// Sources:
/// https://www.investopedia.com/terms/a/aroon.asp
/// Tushar Chande (1995)
/// </remarks>
[SkipLocalsInit]
public sealed class Aroon : ITValuePublisher
{
private readonly int _period;
private readonly RingBuffer _highs;
private readonly RingBuffer _lows;
/// <summary>
/// Display name for the indicator.
/// </summary>
public string Name { get; }
public event TValuePublishedHandler? Pub;
/// <summary>
/// Current Aroon Oscillator value (Up - Down).
/// </summary>
public TValue Last { get; private set; }
/// <summary>
/// Current Aroon Up value.
/// </summary>
public TValue Up { get; private set; }
/// <summary>
/// Current Aroon Down value.
/// </summary>
public TValue Down { get; private set; }
/// <summary>
/// True if the indicator has enough data for a full period calculation.
/// </summary>
public bool IsHot => _highs.IsFull;
/// <summary>
/// The number of bars required for the indicator to warm up.
/// </summary>
public int WarmupPeriod { get; }
/// <summary>
/// Creates Aroon indicator with specified period.
/// </summary>
/// <param name="period">Lookback period (must be > 0)</param>
public Aroon(int period)
{
if (period <= 0)
throw new ArgumentException("Period must be greater than 0", nameof(period));
_period = period;
Name = $"Aroon({period})";
WarmupPeriod = period;
// We need Period + 1 samples to cover the range [0, Period] days ago.
_highs = new RingBuffer(period + 1);
_lows = new RingBuffer(period + 1);
}
/// <summary>
/// Resets the indicator state.
/// </summary>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public void Reset()
{
_highs.Clear();
_lows.Clear();
Last = default;
Up = default;
Down = default;
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public TValue Update(TBar input, bool isNew = true)
{
_highs.Add(input.High, isNew);
_lows.Add(input.Low, isNew);
if (_highs.Count == 0)
{
return default;
}
// Find max index in highs (Zero allocation)
var highsBuffer = _highs.InternalBuffer;
int count = _highs.Count;
int capacity = _highs.Capacity;
int start = _highs.StartIndex;
double maxVal = double.MinValue;
int maxIdxRelative = 0;
for (int i = 0; i < count; i++)
{
int idx = (start + i) % capacity;
double val = highsBuffer[idx];
// Use >= to find the most recent high if values are equal
if (val >= maxVal)
{
maxVal = val;
maxIdxRelative = i;
}
}
// Find min index in lows (Zero allocation)
var lowsBuffer = _lows.InternalBuffer;
double minVal = double.MaxValue;
int minIdxRelative = 0;
for (int i = 0; i < count; i++)
{
int idx = (start + i) % capacity;
double val = lowsBuffer[idx];
// Use <= to find the most recent low if values are equal
if (val <= minVal)
{
minVal = val;
minIdxRelative = i;
}
}
// Calculate days since (0 means current bar is the high/low)
int daysSinceHigh = count - 1 - maxIdxRelative;
int daysSinceLow = count - 1 - minIdxRelative;
double up = ((double)(_period - daysSinceHigh) / _period) * 100.0;
double down = ((double)(_period - daysSinceLow) / _period) * 100.0;
double osc = up - down;
Up = new TValue(input.Time, up);
Down = new TValue(input.Time, down);
Last = new TValue(input.Time, osc);
Pub?.Invoke(this, new TValueEventArgs { Value = Last, IsNew = isNew });
return Last;
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public TValue Update(TValue input, bool isNew = true)
{
return Update(new TBar(input.Time, input.Value, input.Value, input.Value, input.Value, 0), isNew);
}
public TSeries Update(TBarSeries source)
{
if (source.Count == 0) return new TSeries([], []);
int len = source.Count;
var v = new double[len];
Calculate(source.High.Values, source.Low.Values, _period, v);
var tList = new List<long>(len);
var vList = new List<double>(v);
var times = source.Open.Times;
for (int i = 0; i < len; i++)
{
tList.Add(times[i]);
}
Reset();
for (int i = 0; i < len; i++)
{
Update(source[i], isNew: true);
}
return new TSeries(tList, vList);
}
/// <summary>
/// Calculates Aroon oscillator values using O(n) monotonic deque algorithm.
/// </summary>
/// <param name="high">High prices</param>
/// <param name="low">Low prices</param>
/// <param name="period">Lookback period</param>
/// <param name="destination">Output oscillator values (Up - Down)</param>
[MethodImpl(MethodImplOptions.AggressiveOptimization)]
public static void Calculate(ReadOnlySpan<double> high, ReadOnlySpan<double> low, int period, Span<double> destination)
{
int len = high.Length;
if (len == 0 || len != low.Length || len != destination.Length || period <= 0)
{
if (destination.Length > 0)
{
destination.Clear();
}
return;
}
// Use monotonic deques for O(n) complexity
// Deque stores indices; front has the max/min index within the window
// Max deque size is bounded by window size (period + 1), but we use circular indexing
int windowSize = period + 1;
int[]? rented = ArrayPool<int>.Shared.Rent(windowSize * 2);
try
{
Span<int> buffer = rented.AsSpan(0, windowSize * 2);
Span<int> maxDeque = buffer.Slice(0, windowSize); // circular buffer for max indices
Span<int> minDeque = buffer.Slice(windowSize, windowSize); // circular buffer for min indices
int maxHead = 0, maxTail = 0, maxCount = 0; // circular deque for highs
int minHead = 0, minTail = 0, minCount = 0; // circular deque for lows
double invPeriod = 100.0 / period;
for (int i = 0; i < len; i++)
{
// Remove elements outside the window [i - period, i]
int windowStart = i - period;
// Remove old indices from front of max deque
while (maxCount > 0 && maxDeque[maxHead] < windowStart)
{
maxHead = (maxHead + 1) % windowSize;
maxCount--;
}
// Remove old indices from front of min deque
while (minCount > 0 && minDeque[minHead] < windowStart)
{
minHead = (minHead + 1) % windowSize;
minCount--;
}
// Add current index to max deque (maintain decreasing order)
// Use <= to keep most recent max when values equal
double h = high[i];
while (maxCount > 0 && high[maxDeque[(maxTail - 1 + windowSize) % windowSize]] <= h)
{
maxTail = (maxTail - 1 + windowSize) % windowSize;
maxCount--;
}
maxDeque[maxTail] = i;
maxTail = (maxTail + 1) % windowSize;
maxCount++;
// Add current index to min deque (maintain increasing order)
// Use >= to keep most recent min when values equal
double l = low[i];
while (minCount > 0 && low[minDeque[(minTail - 1 + windowSize) % windowSize]] >= l)
{
minTail = (minTail - 1 + windowSize) % windowSize;
minCount--;
}
minDeque[minTail] = i;
minTail = (minTail + 1) % windowSize;
minCount++;
// Calculate Aroon values
int maxIdx = maxDeque[maxHead];
int minIdx = minDeque[minHead];
int daysSinceHigh = i - maxIdx;
int daysSinceLow = i - minIdx;
double up = (period - daysSinceHigh) * invPeriod;
double down = (period - daysSinceLow) * invPeriod;
destination[i] = up - down;
}
}
finally
{
ArrayPool<int>.Shared.Return(rented);
}
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static TSeries Batch(TBarSeries source, int period)
{
if (source.Count == 0) return new TSeries([], []);
int len = source.Count;
var v = new double[len];
Calculate(source.High.Values, source.Low.Values, period, v);
var tList = new List<long>(len);
var times = source.Open.Times;
for (int i = 0; i < len; i++)
{
tList.Add(times[i]);
}
return new TSeries(tList, [.. v]);
}
}
+73
View File
@@ -0,0 +1,73 @@
# Aroon
> Price levels are irrelevant. The only thing that matters is *when* they happened. Aroon is a stopwatch for trends.
The Aroon indicator measures the temporal freshness of price extremes. Unlike oscillators that obsess over *how much* price has moved, Aroon asks *how long* it has been since a new high or low. It quantifies the "staleness" of a trend, providing an early warning system for consolidation and reversals.
## Historical Context
Tushar Chande introduced Aroon in *Beyond Technical Analysis* (1995). The name comes from the Sanskrit word for "Dawn's Early Light." Chande's insight was that trends don't just stop; they age. By measuring the time elapsed since the last extreme, Aroon attempts to spot the "dawn" of a new trend rather than just confirming an existing one.
## Architecture & Physics
Aroon is purely time-based. It normalizes the "days since" metric into a 0-100 oscillator.
1. **Time Tracking**: A sliding window of the last $N$ bars is maintained.
2. **Extremum Search**: The index of the highest high and lowest low within that window is located.
3. **Normalization**: The distance (in bars) is converted into a percentage.
### The Logic of Freshness
* **Aroon Up**: Quantifies the recency of the High.
* 100: New high today.
* 0: No new high for the entire period.
* **Aroon Down**: Quantifies the recency of the Low.
* 100: New low today.
* 0: No new low for the entire period.
* **Oscillator**: The net difference ($Up - Down$), showing the dominant temporal force.
## Mathematical Foundation
The math is a linear decay function based on time.
$$ \text{Aroon Up} = \frac{Period - \text{Days Since High}}{Period} \times 100 $$
$$ \text{Aroon Down} = \frac{Period - \text{Days Since Low}}{Period} \times 100 $$
$$ \text{Oscillator} = \text{Aroon Up} - \text{Aroon Down} $$
## Performance Profile
While memory is O(P), computational complexity is linear with respect to the period due to the min/max search.
### Zero-Allocation Design
The implementation uses a circular buffer (`RingBuffer`) to store historical highs and lows, ensuring O(1) access and zero heap allocations during the update cycle. The min/max search is performed in-place on the buffer.
| Metric | Score | Notes |
| :--- | :--- | :--- |
| **Throughput** | 10ns | 10ns / bar. |
| **Allocations** | 0 | Hot path is allocation-free. |
| **Complexity** | O(P) | Linear scan for extremes. |
| **Accuracy** | 10/10 | Matches standard implementations. |
| **Timeliness** | 10/10 | Reacts immediately to new extremes. |
| **Overshoot** | 0/10 | Bounded 0-100. |
| **Smoothness** | 2/10 | Step-function behavior. |
## Validation
Validation is performed against industry-standard libraries.
| Library | Status | Notes |
| :--- | :--- | :--- |
| **QuanTAlib** | ✅ | Validated. |
| **Skender** | ✅ | Matches `GetAroon`. |
| **TA-Lib** | ✅ | Matches `TA_AROON` and `TA_AROONOSC`. |
| **Tulip** | ✅ | Matches `ti.aroon` and `ti.aroonosc`. |
| **Ooples** | N/A | Not implemented. |
### Common Pitfalls
* **Single Value Updates**: If you feed Aroon only `Close` prices (instead of High/Low), it degrades into a "Time Since Highest Close" metric. It works, but it loses the nuance of intraday extremes.
* **The 70/30 Rule**: A common interpretation is that a trend is strong only if the primary line is > 70. Values between 30 and 70 often indicate noise or consolidation.
+41
View File
@@ -0,0 +1,41 @@
// The MIT License (MIT)
// © mihakralj
//@version=6
indicator("Aroon (AROON)", "AROON", overlay=false)
//@function Calculates Aroon Up and Down values
//@doc https://github.com/mihakralj/pinescript/blob/main/indicators/dynamics/aroon.md
//@param period Number of bars used in the calculation
//@returns tuple of Aroon Up and Aroon Down values
aroon(simple int period = 25) =>
if period <= 0
runtime.error("Period must be greater than 0")
// Find highest high and lowest low positions
float highest_pos = ta.highestbars(high, period)
float lowest_pos = ta.lowestbars(low, period)
// Calculate Aroon values
float aroon_up = 100 * (period + highest_pos) / period
float aroon_down = 100 * (period + lowest_pos) / period
[aroon_up, aroon_down]
// Inputs
i_period = input.int(25, "Period", minval=1, tooltip="Number of bars used in the calculation")
// Calculate Aroon
[aroon_up, aroon_down] = aroon(i_period)
// Plot
plot(aroon_up, "Aroon Up", color=color.yellow, linewidth=2)
plot(aroon_down, "Aroon Down", color=color.yellow, linewidth=2)
hline(50, "Mid Level", color.gray)
hline(70, "Upper Level", color.gray)
hline(30, "Lower Level", color.gray)
// Alert conditions
alertcondition(ta.crossover(aroon_up, aroon_down), "Aroon Up crosses above Down", "Bullish crossover on {{ticker}}")
alertcondition(ta.crossunder(aroon_up, aroon_down), "Aroon Down crosses above Up", "Bearish crossover on {{ticker}}")
alertcondition(aroon_up > 70 and aroon_down < 30, "Strong uptrend", "Strong uptrend detected on {{ticker}}")
alertcondition(aroon_down > 70 and aroon_up < 30, "Strong downtrend", "Strong downtrend detected on {{ticker}}")