mirror of
https://github.com/mihakralj/QuanTAlib.git
synced 2026-08-19 11:08:05 +00:00
Add Price Volume Trend (PVT) Indicator and Tests
- Implemented the PvtIndicator class for calculating Price Volume Trend in Quantower. - Created unit tests for the Pvt class to validate calculations and state management. - Added validation tests to ensure consistency with OoplesFinance's implementation. - Developed a comprehensive documentation (Pvt.md) explaining the PVT concept, calculations, and usage. - Included methods for batch calculations and streaming updates for PVT.
This commit is contained in:
@@ -0,0 +1,228 @@
|
||||
using TradingPlatform.BusinessLayer;
|
||||
|
||||
namespace QuanTAlib.Tests;
|
||||
|
||||
public class PvtIndicatorTests
|
||||
{
|
||||
[Fact]
|
||||
public void PvtIndicator_Constructor_SetsDefaults()
|
||||
{
|
||||
var indicator = new PvtIndicator();
|
||||
|
||||
Assert.Equal("PVT - Price Volume Trend", indicator.Name);
|
||||
Assert.True(indicator.SeparateWindow);
|
||||
Assert.True(indicator.OnBackGround);
|
||||
Assert.Equal(2, indicator.MinHistoryDepths);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void PvtIndicator_ShortName_IsConstant()
|
||||
{
|
||||
var indicator = new PvtIndicator();
|
||||
Assert.Equal("PVT", indicator.ShortName);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void PvtIndicator_MinHistoryDepths_EqualsTwo()
|
||||
{
|
||||
var indicator = new PvtIndicator();
|
||||
|
||||
Assert.Equal(2, indicator.MinHistoryDepths);
|
||||
Assert.Equal(2, ((IWatchlistIndicator)indicator).MinHistoryDepths);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void PvtIndicator_Initialize_CreatesInternalPvt()
|
||||
{
|
||||
var indicator = new PvtIndicator();
|
||||
|
||||
// Initialize should not throw
|
||||
indicator.Initialize();
|
||||
|
||||
// After init, line series should exist
|
||||
Assert.Single(indicator.LinesSeries);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void PvtIndicator_ProcessUpdate_HistoricalBar_ComputesValue()
|
||||
{
|
||||
var indicator = new PvtIndicator();
|
||||
indicator.Initialize();
|
||||
|
||||
// Add historical data
|
||||
var now = DateTime.UtcNow;
|
||||
for (int i = 0; i < 30; i++)
|
||||
{
|
||||
// Varying close prices to trigger PVT changes
|
||||
double close = 100 + (i % 2 == 0 ? i : -i / 2);
|
||||
indicator.HistoricalData.AddBar(now.AddMinutes(i), 100, 110, 90, close, 100000);
|
||||
|
||||
// Process update for each bar to simulate history loading
|
||||
var args = new UpdateArgs(UpdateReason.HistoricalBar);
|
||||
indicator.ProcessUpdate(args);
|
||||
}
|
||||
|
||||
// Line series should have a value
|
||||
double val = indicator.LinesSeries[0].GetValue(0);
|
||||
Assert.True(double.IsFinite(val));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void PvtIndicator_ProcessUpdate_NewBar_ComputesValue()
|
||||
{
|
||||
var indicator = new PvtIndicator();
|
||||
indicator.Initialize();
|
||||
|
||||
var now = DateTime.UtcNow;
|
||||
for (int i = 0; i < 30; i++)
|
||||
{
|
||||
indicator.HistoricalData.AddBar(now.AddMinutes(i), 100, 110, 90, 105, 100000);
|
||||
}
|
||||
|
||||
indicator.ProcessUpdate(new UpdateArgs(UpdateReason.HistoricalBar));
|
||||
|
||||
// Add new bar with higher close to increase PVT
|
||||
indicator.HistoricalData.AddBar(now.AddMinutes(30), 105, 115, 100, 112, 80000);
|
||||
indicator.ProcessUpdate(new UpdateArgs(UpdateReason.NewBar));
|
||||
|
||||
Assert.Equal(2, indicator.LinesSeries[0].Count);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void PvtIndicator_UpClose_IncreasesPvt()
|
||||
{
|
||||
var indicator = new PvtIndicator();
|
||||
indicator.Initialize();
|
||||
|
||||
var now = DateTime.UtcNow;
|
||||
|
||||
// First bar
|
||||
indicator.HistoricalData.AddBar(now, 100, 105, 95, 100, 100000);
|
||||
indicator.ProcessUpdate(new UpdateArgs(UpdateReason.HistoricalBar));
|
||||
|
||||
double firstVal = indicator.LinesSeries[0].GetValue(0);
|
||||
|
||||
// Second bar with higher close - PVT should increase
|
||||
// PVT += volume * (price_change / prev_price) = 50000 * (108-100)/100 = 4000
|
||||
indicator.HistoricalData.AddBar(now.AddMinutes(1), 100, 110, 98, 108, 50000);
|
||||
indicator.ProcessUpdate(new UpdateArgs(UpdateReason.NewBar));
|
||||
|
||||
double secondVal = indicator.LinesSeries[0].GetValue(0);
|
||||
|
||||
Assert.True(secondVal > firstVal, $"PVT should increase when close rises: {secondVal} vs {firstVal}");
|
||||
Assert.Equal(4000, secondVal - firstVal, 1); // Volume * (price_change / prev_price)
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void PvtIndicator_DownClose_DecreasesPvt()
|
||||
{
|
||||
var indicator = new PvtIndicator();
|
||||
indicator.Initialize();
|
||||
|
||||
var now = DateTime.UtcNow;
|
||||
|
||||
// First bar
|
||||
indicator.HistoricalData.AddBar(now, 100, 105, 95, 100, 100000);
|
||||
indicator.ProcessUpdate(new UpdateArgs(UpdateReason.HistoricalBar));
|
||||
|
||||
double firstVal = indicator.LinesSeries[0].GetValue(0);
|
||||
|
||||
// Second bar with lower close - PVT should decrease
|
||||
// PVT += volume * (price_change / prev_price) = 50000 * (92-100)/100 = -4000
|
||||
indicator.HistoricalData.AddBar(now.AddMinutes(1), 100, 102, 90, 92, 50000);
|
||||
indicator.ProcessUpdate(new UpdateArgs(UpdateReason.NewBar));
|
||||
|
||||
double secondVal = indicator.LinesSeries[0].GetValue(0);
|
||||
|
||||
Assert.True(secondVal < firstVal, $"PVT should decrease when close falls: {secondVal} vs {firstVal}");
|
||||
Assert.Equal(-4000, secondVal - firstVal, 1); // Volume * (price_change / prev_price)
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void PvtIndicator_EqualClose_PvtUnchanged()
|
||||
{
|
||||
var indicator = new PvtIndicator();
|
||||
indicator.Initialize();
|
||||
|
||||
var now = DateTime.UtcNow;
|
||||
|
||||
// First bar
|
||||
indicator.HistoricalData.AddBar(now, 100, 105, 95, 100, 100000);
|
||||
indicator.ProcessUpdate(new UpdateArgs(UpdateReason.HistoricalBar));
|
||||
|
||||
double firstVal = indicator.LinesSeries[0].GetValue(0);
|
||||
|
||||
// Second bar with same close - PVT should not change (price_change = 0)
|
||||
indicator.HistoricalData.AddBar(now.AddMinutes(1), 100, 110, 90, 100, 200000);
|
||||
indicator.ProcessUpdate(new UpdateArgs(UpdateReason.NewBar));
|
||||
|
||||
double secondVal = indicator.LinesSeries[0].GetValue(0);
|
||||
|
||||
Assert.Equal(firstVal, secondVal);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void PvtIndicator_Cumulative_CorrectAccumulation()
|
||||
{
|
||||
var indicator = new PvtIndicator();
|
||||
indicator.Initialize();
|
||||
|
||||
var now = DateTime.UtcNow;
|
||||
|
||||
// Bar 1: close=100, volume=10000 -> PVT=0 (first bar)
|
||||
indicator.HistoricalData.AddBar(now, 100, 105, 95, 100, 10000);
|
||||
indicator.ProcessUpdate(new UpdateArgs(UpdateReason.HistoricalBar));
|
||||
|
||||
// Bar 2: close=110 (up from 100), volume=20000 -> PVT += 20000 * (10/100) = 2000
|
||||
indicator.HistoricalData.AddBar(now.AddMinutes(1), 100, 115, 98, 110, 20000);
|
||||
indicator.ProcessUpdate(new UpdateArgs(UpdateReason.NewBar));
|
||||
|
||||
// Bar 3: close=105 (down from 110), volume=15000 -> PVT += 15000 * (-5/110) ≈ -681.82
|
||||
indicator.HistoricalData.AddBar(now.AddMinutes(2), 110, 112, 100, 105, 15000);
|
||||
indicator.ProcessUpdate(new UpdateArgs(UpdateReason.NewBar));
|
||||
|
||||
// Bar 4: close=108 (up from 105), volume=10000 -> PVT += 10000 * (3/105) ≈ 285.71
|
||||
indicator.HistoricalData.AddBar(now.AddMinutes(3), 105, 110, 104, 108, 10000);
|
||||
indicator.ProcessUpdate(new UpdateArgs(UpdateReason.NewBar));
|
||||
|
||||
// Expected: 0 + 2000 - 681.82 + 285.71 ≈ 1603.90
|
||||
double finalVal = indicator.LinesSeries[0].GetValue(0);
|
||||
Assert.InRange(finalVal, 1600, 1610);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void PvtIndicator_LargeVolume_HandlesCorrectly()
|
||||
{
|
||||
var indicator = new PvtIndicator();
|
||||
indicator.Initialize();
|
||||
|
||||
var now = DateTime.UtcNow;
|
||||
|
||||
// Test with large volume values
|
||||
indicator.HistoricalData.AddBar(now, 100, 105, 95, 100, 1_000_000_000);
|
||||
indicator.ProcessUpdate(new UpdateArgs(UpdateReason.HistoricalBar));
|
||||
|
||||
// PVT += 2_000_000_000 * (108-100)/100 = 160_000_000
|
||||
indicator.HistoricalData.AddBar(now.AddMinutes(1), 100, 110, 98, 108, 2_000_000_000);
|
||||
indicator.ProcessUpdate(new UpdateArgs(UpdateReason.NewBar));
|
||||
|
||||
double val = indicator.LinesSeries[0].GetValue(0);
|
||||
Assert.Equal(160_000_000, val, 1);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void PvtIndicator_StartsAtZero()
|
||||
{
|
||||
var indicator = new PvtIndicator();
|
||||
indicator.Initialize();
|
||||
|
||||
var now = DateTime.UtcNow;
|
||||
|
||||
// First bar - PVT should be 0
|
||||
indicator.HistoricalData.AddBar(now, 100, 105, 95, 100, 100000);
|
||||
indicator.ProcessUpdate(new UpdateArgs(UpdateReason.HistoricalBar));
|
||||
|
||||
double firstVal = indicator.LinesSeries[0].GetValue(0);
|
||||
Assert.Equal(0, firstVal);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,50 @@
|
||||
using System.Drawing;
|
||||
using System.Runtime.CompilerServices;
|
||||
using TradingPlatform.BusinessLayer;
|
||||
|
||||
namespace QuanTAlib;
|
||||
|
||||
[SkipLocalsInit]
|
||||
public sealed class PvtIndicator : Indicator, IWatchlistIndicator
|
||||
{
|
||||
[InputParameter("Show cold values", sortIndex: 21)]
|
||||
public bool ShowColdValues { get; set; } = true;
|
||||
|
||||
private Pvt _pvt = null!;
|
||||
private readonly LineSeries _series;
|
||||
|
||||
#pragma warning disable S2325 // Instance property required by Quantower indicator interface
|
||||
public int MinHistoryDepths => 2;
|
||||
#pragma warning restore S2325
|
||||
int IWatchlistIndicator.MinHistoryDepths => 2;
|
||||
|
||||
public override string ShortName => "PVT";
|
||||
public override string SourceCodeLink => "https://github.com/mihakralj/QuanTAlib/blob/main/lib/volume/pvt/Pvt.Quantower.cs";
|
||||
|
||||
public PvtIndicator()
|
||||
{
|
||||
OnBackGround = true;
|
||||
SeparateWindow = true;
|
||||
Name = "PVT - Price Volume Trend";
|
||||
Description = "Price Volume Trend tracks cumulative buying/selling pressure weighted by relative price changes";
|
||||
|
||||
_series = new LineSeries(name: "PVT", color: Color.DarkGreen, width: 2, style: LineStyle.Solid);
|
||||
AddLineSeries(_series);
|
||||
}
|
||||
|
||||
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
||||
protected override void OnInit()
|
||||
{
|
||||
_pvt = new Pvt();
|
||||
base.OnInit();
|
||||
}
|
||||
|
||||
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
||||
protected override void OnUpdate(UpdateArgs args)
|
||||
{
|
||||
TBar bar = this.GetInputBar(args);
|
||||
TValue result = _pvt.Update(bar, args.IsNewBar());
|
||||
|
||||
_series.SetValue(result.Value, _pvt.IsHot, ShowColdValues);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,461 @@
|
||||
using Xunit;
|
||||
|
||||
namespace QuanTAlib.Tests;
|
||||
|
||||
public class PvtTests
|
||||
{
|
||||
private const double Tolerance = 1e-10;
|
||||
|
||||
// ==================== Constructor Tests ====================
|
||||
|
||||
[Fact]
|
||||
public void Constructor_InitializesCorrectly()
|
||||
{
|
||||
var pvt = new Pvt();
|
||||
|
||||
Assert.Equal("Pvt", pvt.Name);
|
||||
Assert.Equal(0.0, pvt.Last.Value);
|
||||
Assert.False(pvt.IsHot);
|
||||
Assert.Equal(2, pvt.WarmupPeriod);
|
||||
}
|
||||
|
||||
// ==================== Basic Calculation Tests ====================
|
||||
|
||||
[Fact]
|
||||
public void Update_FirstBar_ReturnsZero()
|
||||
{
|
||||
var pvt = new Pvt();
|
||||
|
||||
var result = pvt.Update(new TBar(DateTime.UtcNow, 100, 105, 95, 100, 1000));
|
||||
|
||||
Assert.Equal(0.0, result.Value);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Update_SecondBar_PriceUp_ReturnsPositiveVolumeFraction()
|
||||
{
|
||||
var pvt = new Pvt();
|
||||
var time = DateTime.UtcNow;
|
||||
|
||||
pvt.Update(new TBar(time, 100, 105, 95, 100, 1000)); // First bar, close=100
|
||||
var result = pvt.Update(new TBar(time.AddMinutes(1), 100, 110, 100, 110, 2000)); // close=110, +10%
|
||||
|
||||
// PVT = volume * (price_change / prev_price) = 2000 * (10/100) = 200
|
||||
Assert.Equal(200.0, result.Value, Tolerance);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Update_SecondBar_PriceDown_ReturnsNegativeVolumeFraction()
|
||||
{
|
||||
var pvt = new Pvt();
|
||||
var time = DateTime.UtcNow;
|
||||
|
||||
pvt.Update(new TBar(time, 100, 105, 95, 100, 1000)); // First bar, close=100
|
||||
var result = pvt.Update(new TBar(time.AddMinutes(1), 100, 100, 85, 90, 2000)); // close=90, -10%
|
||||
|
||||
// PVT = volume * (price_change / prev_price) = 2000 * (-10/100) = -200
|
||||
Assert.Equal(-200.0, result.Value, Tolerance);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Update_PriceUnchanged_NoChange()
|
||||
{
|
||||
var pvt = new Pvt();
|
||||
var time = DateTime.UtcNow;
|
||||
|
||||
pvt.Update(new TBar(time, 100, 105, 95, 100, 1000)); // First bar
|
||||
var result = pvt.Update(new TBar(time.AddMinutes(1), 100, 110, 90, 100, 5000)); // Same close
|
||||
|
||||
// PVT = volume * (0/100) = 0
|
||||
Assert.Equal(0.0, result.Value, Tolerance);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Update_MultipleBars_AccumulatesCorrectly()
|
||||
{
|
||||
var pvt = new Pvt();
|
||||
var time = DateTime.UtcNow;
|
||||
|
||||
pvt.Update(new TBar(time, 100, 105, 95, 100, 1000)); // First bar
|
||||
pvt.Update(new TBar(time.AddMinutes(1), 100, 110, 100, 110, 2000)); // +10% -> +200
|
||||
pvt.Update(new TBar(time.AddMinutes(2), 110, 115, 105, 105, 1000)); // -4.545% from 110 -> ~-45.45
|
||||
var result = pvt.Update(new TBar(time.AddMinutes(3), 105, 120, 105, 120, 3000)); // +14.286% from 105 -> ~+428.57
|
||||
|
||||
// Expected PVT:
|
||||
// Bar 1: 0
|
||||
// Bar 2: 0 + 2000 * (10/100) = 200
|
||||
// Bar 3: 200 + 1000 * (-5/110) = 200 - 45.4545... = 154.5454...
|
||||
// Bar 4: 154.5454 + 3000 * (15/105) = 154.5454 + 428.5714... = 583.1168...
|
||||
Assert.True(result.Value > 500 && result.Value < 600); // Approximate check
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Update_SmallPriceChange_SmallPvtChange()
|
||||
{
|
||||
var pvt = new Pvt();
|
||||
var time = DateTime.UtcNow;
|
||||
|
||||
pvt.Update(new TBar(time, 100, 105, 95, 100, 1000)); // First bar
|
||||
var result = pvt.Update(new TBar(time.AddMinutes(1), 100, 101, 99, 100.5, 10000)); // +0.5%
|
||||
|
||||
// PVT = 10000 * (0.5/100) = 50
|
||||
Assert.Equal(50.0, result.Value, Tolerance);
|
||||
}
|
||||
|
||||
// ==================== State Management Tests ====================
|
||||
|
||||
[Fact]
|
||||
public void Update_IsNewTrue_AdvancesState()
|
||||
{
|
||||
var pvt = new Pvt();
|
||||
var time = DateTime.UtcNow;
|
||||
|
||||
pvt.Update(new TBar(time, 100, 105, 95, 100, 1000), isNew: true);
|
||||
var value1 = pvt.Last.Value;
|
||||
|
||||
pvt.Update(new TBar(time.AddMinutes(1), 100, 110, 100, 110, 2000), isNew: true);
|
||||
var value2 = pvt.Last.Value;
|
||||
|
||||
Assert.Equal(0.0, value1);
|
||||
Assert.Equal(200.0, value2, Tolerance);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Update_IsNewFalse_RollsBackState()
|
||||
{
|
||||
var pvt = new Pvt();
|
||||
var time = DateTime.UtcNow;
|
||||
|
||||
pvt.Update(new TBar(time, 100, 105, 95, 100, 1000), isNew: true); // First bar
|
||||
pvt.Update(new TBar(time.AddMinutes(1), 100, 110, 100, 110, 2000), isNew: true); // +10% -> +200
|
||||
|
||||
var valueAfterSecond = pvt.Last.Value; // Should be 200
|
||||
|
||||
// Now correct the bar (isNew=false) with different values
|
||||
pvt.Update(new TBar(time.AddMinutes(1), 100, 110, 100, 105, 2000), isNew: false); // +5% -> +100
|
||||
|
||||
Assert.Equal(200.0, valueAfterSecond, Tolerance);
|
||||
Assert.Equal(100.0, pvt.Last.Value, Tolerance); // Corrected to +5%
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Update_IterativeCorrections_RestoreProperly()
|
||||
{
|
||||
var pvt = new Pvt();
|
||||
var time = DateTime.UtcNow;
|
||||
|
||||
pvt.Update(new TBar(time, 100, 105, 95, 100, 1000), isNew: true);
|
||||
|
||||
// Process a bar as new
|
||||
pvt.Update(new TBar(time.AddMinutes(1), 100, 110, 100, 110, 2000), isNew: true);
|
||||
var originalValue = pvt.Last.Value; // 200
|
||||
|
||||
// Multiple corrections should all restore to same state
|
||||
pvt.Update(new TBar(time.AddMinutes(1), 100, 110, 100, 105, 2000), isNew: false); // +5%
|
||||
Assert.Equal(100.0, pvt.Last.Value, Tolerance);
|
||||
|
||||
pvt.Update(new TBar(time.AddMinutes(1), 100, 110, 100, 102, 2000), isNew: false); // +2%
|
||||
Assert.Equal(40.0, pvt.Last.Value, Tolerance);
|
||||
|
||||
pvt.Update(new TBar(time.AddMinutes(1), 100, 110, 100, 110, 2000), isNew: false); // Back to original +10%
|
||||
Assert.Equal(originalValue, pvt.Last.Value, Tolerance);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Reset_ClearsAllState()
|
||||
{
|
||||
var pvt = new Pvt();
|
||||
var time = DateTime.UtcNow;
|
||||
|
||||
pvt.Update(new TBar(time, 100, 105, 95, 100, 1000));
|
||||
pvt.Update(new TBar(time.AddMinutes(1), 100, 110, 100, 110, 2000));
|
||||
|
||||
Assert.NotEqual(0.0, pvt.Last.Value);
|
||||
Assert.True(pvt.IsHot);
|
||||
|
||||
pvt.Reset();
|
||||
|
||||
Assert.Equal(0.0, pvt.Last.Value);
|
||||
Assert.False(pvt.IsHot);
|
||||
}
|
||||
|
||||
// ==================== Warmup and IsHot Tests ====================
|
||||
|
||||
[Fact]
|
||||
public void IsHot_BecomesTrue_AfterWarmupPeriod()
|
||||
{
|
||||
var pvt = new Pvt();
|
||||
var time = DateTime.UtcNow;
|
||||
|
||||
Assert.False(pvt.IsHot);
|
||||
|
||||
pvt.Update(new TBar(time, 100, 105, 95, 100, 1000));
|
||||
Assert.False(pvt.IsHot);
|
||||
|
||||
pvt.Update(new TBar(time.AddMinutes(1), 100, 110, 100, 110, 2000));
|
||||
Assert.True(pvt.IsHot);
|
||||
}
|
||||
|
||||
// ==================== NaN/Infinity Handling Tests ====================
|
||||
|
||||
[Fact]
|
||||
public void Update_NaNClose_UsesLastValidClose()
|
||||
{
|
||||
var pvt = new Pvt();
|
||||
var time = DateTime.UtcNow;
|
||||
|
||||
pvt.Update(new TBar(time, 100, 105, 95, 100, 1000));
|
||||
pvt.Update(new TBar(time.AddMinutes(1), 100, 110, 100, 110, 2000)); // PVT = 200
|
||||
var valueBeforeNaN = pvt.Last.Value;
|
||||
|
||||
pvt.Update(new TBar(time.AddMinutes(2), double.NaN, double.NaN, double.NaN, double.NaN, 1000));
|
||||
|
||||
// Should use last valid close (110) for both prev and current -> 0% change
|
||||
Assert.Equal(valueBeforeNaN, pvt.Last.Value, Tolerance);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Update_NaNVolume_UsesLastValidVolume()
|
||||
{
|
||||
var pvt = new Pvt();
|
||||
var time = DateTime.UtcNow;
|
||||
|
||||
pvt.Update(new TBar(time, 100, 105, 95, 100, 1000));
|
||||
pvt.Update(new TBar(time.AddMinutes(1), 110, 115, 105, 110, 2000)); // PVT = 200
|
||||
pvt.Update(new TBar(time.AddMinutes(2), 110, 130, 110, 120, double.NaN)); // +9.09% with last valid vol
|
||||
|
||||
// Uses last valid volume (2000) * (10/110) = ~181.82 added to 200
|
||||
Assert.True(pvt.Last.Value > 350 && pvt.Last.Value < 400);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Update_InfinityClose_UsesLastValidClose()
|
||||
{
|
||||
var pvt = new Pvt();
|
||||
var time = DateTime.UtcNow;
|
||||
|
||||
pvt.Update(new TBar(time, 100, 105, 95, 100, 1000));
|
||||
pvt.Update(new TBar(time.AddMinutes(1), 100, 110, 100, 110, 2000));
|
||||
var valueBeforeInf = pvt.Last.Value;
|
||||
|
||||
pvt.Update(new TBar(time.AddMinutes(2), 110, double.PositiveInfinity, 110, double.PositiveInfinity, 1000));
|
||||
|
||||
// Should use last valid close
|
||||
Assert.Equal(valueBeforeInf, pvt.Last.Value, Tolerance);
|
||||
}
|
||||
|
||||
// ==================== Consistency Tests ====================
|
||||
|
||||
[Fact]
|
||||
public void BatchCalculate_MatchesStreamingUpdate()
|
||||
{
|
||||
var bars = new TBarSeries();
|
||||
var gbm = new GBM(seed: 42);
|
||||
|
||||
for (int i = 0; i < 50; i++)
|
||||
{
|
||||
bars.Add(gbm.Next());
|
||||
}
|
||||
|
||||
// Streaming
|
||||
var pvtStreaming = new Pvt();
|
||||
var streamingResults = new double[bars.Count];
|
||||
for (int i = 0; i < bars.Count; i++)
|
||||
{
|
||||
streamingResults[i] = pvtStreaming.Update(bars[i]).Value;
|
||||
}
|
||||
|
||||
var batchResult = Pvt.Calculate(bars);
|
||||
|
||||
// Compare last 45 values (after warmup)
|
||||
for (int i = 5; i < bars.Count; i++)
|
||||
{
|
||||
Assert.Equal(streamingResults[i], batchResult[i].Value, Tolerance);
|
||||
}
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SpanCalculate_MatchesStreamingUpdate()
|
||||
{
|
||||
var bars = new TBarSeries();
|
||||
var gbm = new GBM(seed: 42);
|
||||
|
||||
for (int i = 0; i < 50; i++)
|
||||
{
|
||||
bars.Add(gbm.Next());
|
||||
}
|
||||
|
||||
// Streaming
|
||||
var pvtStreaming = new Pvt();
|
||||
var streamingResults = new double[bars.Count];
|
||||
var close = new double[bars.Count];
|
||||
var volume = new double[bars.Count];
|
||||
|
||||
for (int i = 0; i < bars.Count; i++)
|
||||
{
|
||||
streamingResults[i] = pvtStreaming.Update(bars[i]).Value;
|
||||
close[i] = bars[i].Close;
|
||||
volume[i] = bars[i].Volume;
|
||||
}
|
||||
|
||||
var spanResult = new double[bars.Count];
|
||||
Pvt.Calculate(close, volume, spanResult);
|
||||
|
||||
// Compare values after first bar
|
||||
for (int i = 1; i < bars.Count; i++)
|
||||
{
|
||||
Assert.Equal(streamingResults[i], spanResult[i], Tolerance);
|
||||
}
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void EventPublishing_WorksCorrectly()
|
||||
{
|
||||
var pvt = new Pvt();
|
||||
var receivedValues = new List<TValue>();
|
||||
var receivedIsNew = new List<bool>();
|
||||
|
||||
pvt.Pub += (object? sender, in TValueEventArgs args) =>
|
||||
{
|
||||
receivedValues.Add(args.Value);
|
||||
receivedIsNew.Add(args.IsNew);
|
||||
};
|
||||
|
||||
var bar1 = new TBar(DateTime.UtcNow, 100, 105, 95, 100, 1000);
|
||||
var bar2 = new TBar(DateTime.UtcNow.AddMinutes(1), 100, 110, 100, 110, 2000);
|
||||
|
||||
pvt.Update(bar1, isNew: true);
|
||||
pvt.Update(bar2, isNew: true);
|
||||
pvt.Update(bar2 with { Close = 105 }, isNew: false);
|
||||
|
||||
Assert.Equal(3, receivedValues.Count);
|
||||
Assert.True(receivedIsNew[0]);
|
||||
Assert.True(receivedIsNew[1]);
|
||||
Assert.False(receivedIsNew[2]);
|
||||
}
|
||||
|
||||
// ==================== Span API Validation Tests ====================
|
||||
|
||||
[Fact]
|
||||
public void SpanCalculate_MismatchedLengths_Throws()
|
||||
{
|
||||
var close = new double[10];
|
||||
var volume = new double[8]; // Different length
|
||||
var output = new double[10];
|
||||
|
||||
Assert.Throws<ArgumentException>(() => Pvt.Calculate(close, volume, output));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SpanCalculate_OutputLengthMismatch_Throws()
|
||||
{
|
||||
var close = new double[10];
|
||||
var volume = new double[10];
|
||||
var output = new double[8]; // Wrong length
|
||||
|
||||
Assert.Throws<ArgumentException>(() => Pvt.Calculate(close, volume, output));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SpanCalculate_EmptyInput_Succeeds()
|
||||
{
|
||||
var close = Array.Empty<double>();
|
||||
var volume = Array.Empty<double>();
|
||||
var output = Array.Empty<double>();
|
||||
|
||||
Pvt.Calculate(close, volume, output); // Should not throw
|
||||
Assert.Empty(output);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SpanCalculate_SingleElement_ReturnsZero()
|
||||
{
|
||||
var close = new double[] { 100.0 };
|
||||
var volume = new double[] { 1000.0 };
|
||||
var output = new double[1];
|
||||
|
||||
Pvt.Calculate(close, volume, output);
|
||||
|
||||
Assert.Equal(0.0, output[0]);
|
||||
}
|
||||
|
||||
// ==================== Update with Price/Volume Direct ====================
|
||||
|
||||
[Fact]
|
||||
public void Update_WithPriceVolume_WorksCorrectly()
|
||||
{
|
||||
var pvt = new Pvt();
|
||||
var time = DateTime.UtcNow.Ticks;
|
||||
|
||||
pvt.Update(100, 1000, time, isNew: true); // First bar
|
||||
var result = pvt.Update(110, 2000, time + TimeSpan.TicksPerMinute, isNew: true); // +10%
|
||||
|
||||
Assert.Equal(200.0, result.Value, Tolerance);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Update_TValueWithoutVolume_ReturnsUnchanged()
|
||||
{
|
||||
var pvt = new Pvt();
|
||||
var time = DateTime.UtcNow;
|
||||
|
||||
pvt.Update(new TBar(time, 100, 105, 95, 100, 1000));
|
||||
pvt.Update(new TBar(time.AddMinutes(1), 100, 110, 100, 110, 2000));
|
||||
var pvtValue = pvt.Last.Value;
|
||||
|
||||
// Update with TValue (no volume)
|
||||
var result = pvt.Update(new TValue(time.AddMinutes(2), 120));
|
||||
|
||||
// Should remain unchanged since no volume
|
||||
Assert.Equal(pvtValue, result.Value);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LargeDataset_HandlesWithoutError()
|
||||
{
|
||||
var bars = new TBarSeries();
|
||||
var gbm = new GBM(seed: 42);
|
||||
|
||||
for (int i = 0; i < 10000; i++)
|
||||
{
|
||||
bars.Add(gbm.Next());
|
||||
}
|
||||
|
||||
var pvt = new Pvt();
|
||||
foreach (var bar in bars)
|
||||
{
|
||||
var result = pvt.Update(bar);
|
||||
Assert.True(double.IsFinite(result.Value));
|
||||
}
|
||||
|
||||
Assert.True(pvt.IsHot);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void FormulaVerification_ManualCalculation()
|
||||
{
|
||||
// Manual verification of PVT formula with known values
|
||||
var pvt = new Pvt();
|
||||
var time = DateTime.UtcNow;
|
||||
|
||||
// Bar 1: baseline (close = 100, volume = 10000)
|
||||
pvt.Update(new TBar(time, 100, 105, 95, 100, 10000));
|
||||
Assert.Equal(0, pvt.Last.Value); // First bar, PVT starts at 0
|
||||
|
||||
// Bar 2: price up 10% (110 vs 100)
|
||||
// Expected: PVT = 0 + 15000 * (10/100) = 1500
|
||||
pvt.Update(new TBar(time.AddMinutes(1), 100, 115, 95, 110, 15000));
|
||||
Assert.Equal(1500, pvt.Last.Value, Tolerance);
|
||||
|
||||
// Bar 3: price down (105 vs 110 = -4.545%)
|
||||
// Expected: PVT = 1500 + 12000 * (-5/110) = 1500 - 545.45... = 954.545...
|
||||
pvt.Update(new TBar(time.AddMinutes(2), 110, 112, 103, 105, 12000));
|
||||
Assert.True(pvt.Last.Value > 950 && pvt.Last.Value < 960);
|
||||
|
||||
// Bar 4: price unchanged (105 == 105)
|
||||
// Expected: PVT unchanged
|
||||
var prevPvt = pvt.Last.Value;
|
||||
pvt.Update(new TBar(time.AddMinutes(3), 105, 108, 102, 105, 20000));
|
||||
Assert.Equal(prevPvt, pvt.Last.Value, Tolerance);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,115 @@
|
||||
using OoplesFinance.StockIndicators;
|
||||
using OoplesFinance.StockIndicators.Models;
|
||||
|
||||
namespace QuanTAlib.Tests;
|
||||
|
||||
public class PvtValidationTests
|
||||
{
|
||||
private readonly ValidationTestData _data;
|
||||
|
||||
public PvtValidationTests()
|
||||
{
|
||||
_data = new ValidationTestData();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Pvt_Matches_Ooples()
|
||||
{
|
||||
// Ooples PVT
|
||||
var ooplesData = _data.SkenderQuotes.Select(q => new TickerData
|
||||
{
|
||||
Date = q.Date,
|
||||
Open = (double)q.Open,
|
||||
High = (double)q.High,
|
||||
Low = (double)q.Low,
|
||||
Close = (double)q.Close,
|
||||
Volume = (double)q.Volume
|
||||
}).ToList();
|
||||
|
||||
var stockData = new StockData(ooplesData);
|
||||
var oResult = stockData.CalculatePriceVolumeTrend();
|
||||
var oValues = oResult.OutputValues["Pvt"];
|
||||
|
||||
// QuanTAlib
|
||||
var pvt = new Pvt();
|
||||
var quantalibValues = new List<double>();
|
||||
foreach (var bar in _data.Bars)
|
||||
{
|
||||
quantalibValues.Add(pvt.Update(bar).Value);
|
||||
}
|
||||
|
||||
// Verify both produce finite values (implementation may differ in cumulative handling)
|
||||
Assert.True(quantalibValues.All(v => double.IsFinite(v)), "QuanTAlib PVT should produce finite values");
|
||||
Assert.True(oValues.All(v => double.IsFinite(v)), "Ooples PVT should produce finite values");
|
||||
|
||||
// Note: Ooples and QuanTAlib may diverge over long series due to different
|
||||
// cumulative calculation approaches or NaN handling.
|
||||
ValidationHelper.VerifyData(quantalibValues.ToArray(), oValues.ToArray(), 0, 100, ValidationHelper.OoplesTolerance);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Pvt_Streaming_Matches_Batch()
|
||||
{
|
||||
// Streaming
|
||||
var pvt = new Pvt();
|
||||
var streamingValues = new List<double>();
|
||||
foreach (var bar in _data.Bars)
|
||||
{
|
||||
streamingValues.Add(pvt.Update(bar).Value);
|
||||
}
|
||||
|
||||
// Batch
|
||||
var batchResult = Pvt.Calculate(_data.Bars);
|
||||
var batchValues = batchResult.Values.ToArray();
|
||||
|
||||
ValidationHelper.VerifyData(streamingValues.ToArray(), batchValues, 0, 100, 1e-9);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Pvt_Span_Matches_Streaming()
|
||||
{
|
||||
// Streaming
|
||||
var pvt = new Pvt();
|
||||
var streamingValues = new List<double>();
|
||||
foreach (var bar in _data.Bars)
|
||||
{
|
||||
streamingValues.Add(pvt.Update(bar).Value);
|
||||
}
|
||||
|
||||
// Span
|
||||
var close = _data.Bars.Close.Values.ToArray();
|
||||
var volume = _data.Bars.Volume.Values.ToArray();
|
||||
var spanOutput = new double[close.Length];
|
||||
|
||||
Pvt.Calculate(close, volume, spanOutput);
|
||||
|
||||
ValidationHelper.VerifyData(streamingValues.ToArray(), spanOutput, 0, 100, 1e-9);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Pvt_KnownValues_MatchExpected()
|
||||
{
|
||||
// Test with known values
|
||||
// Bar 0: close=100, volume=1000 -> PVT = 0 (first bar)
|
||||
// Bar 1: close=110, volume=2000 -> PVT = 2000 * (10/100) = 200
|
||||
// Bar 2: close=105, volume=1500 -> PVT = 200 + 1500 * (-5/110) = 200 - 68.18... = 131.818...
|
||||
// Bar 3: close=115, volume=2500 -> PVT = 131.818 + 2500 * (10/105) = 131.818 + 238.095... = 369.914...
|
||||
|
||||
var pvt = new Pvt();
|
||||
var time = DateTime.UtcNow;
|
||||
|
||||
var result0 = pvt.Update(new TBar(time, 100, 105, 95, 100, 1000));
|
||||
Assert.Equal(0.0, result0.Value, 1e-10);
|
||||
|
||||
var result1 = pvt.Update(new TBar(time.AddMinutes(1), 100, 115, 100, 110, 2000));
|
||||
Assert.Equal(200.0, result1.Value, 1e-10);
|
||||
|
||||
var result2 = pvt.Update(new TBar(time.AddMinutes(2), 110, 112, 103, 105, 1500));
|
||||
double expected2 = 200 + 1500 * (-5.0 / 110.0); // = 131.8181818...
|
||||
Assert.Equal(expected2, result2.Value, 1e-10);
|
||||
|
||||
var result3 = pvt.Update(new TBar(time.AddMinutes(3), 105, 118, 105, 115, 2500));
|
||||
double expected3 = expected2 + 2500 * (10.0 / 105.0); // = 369.9134...
|
||||
Assert.Equal(expected3, result3.Value, 1e-10);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,300 @@
|
||||
using System.Runtime.CompilerServices;
|
||||
using System.Runtime.InteropServices;
|
||||
|
||||
namespace QuanTAlib;
|
||||
|
||||
/// <summary>
|
||||
/// PVT: Price Volume Trend
|
||||
/// </summary>
|
||||
/// <remarks>
|
||||
/// Price Volume Trend is a cumulative volume-based indicator that measures buying
|
||||
/// and selling pressure by weighting volume by the relative price change. Unlike OBV
|
||||
/// which uses all-or-nothing volume assignment, PVT uses proportional volume based
|
||||
/// on how much price moved.
|
||||
///
|
||||
/// Calculation:
|
||||
/// PVT = Previous PVT + Volume * ((Close - Previous Close) / Previous Close)
|
||||
///
|
||||
/// Key differences from OBV:
|
||||
/// - OBV assigns entire volume to buyers or sellers
|
||||
/// - PVT assigns proportional volume based on price change magnitude
|
||||
/// - PVT is more sensitive to the size of price moves
|
||||
///
|
||||
/// Sources:
|
||||
/// https://www.investopedia.com/terms/p/pvtrend.asp
|
||||
/// https://school.stockcharts.com/doku.php?id=technical_indicators:price_volume_trend_pvt
|
||||
/// </remarks>
|
||||
[SkipLocalsInit]
|
||||
public sealed class Pvt : ITValuePublisher
|
||||
{
|
||||
[StructLayout(LayoutKind.Auto)]
|
||||
private record struct State(
|
||||
double PvtValue,
|
||||
double PrevClose,
|
||||
double LastValidClose,
|
||||
double LastValidVolume,
|
||||
int Index);
|
||||
|
||||
private State _s;
|
||||
private State _ps;
|
||||
|
||||
/// <summary>
|
||||
/// Display name for the indicator.
|
||||
/// </summary>
|
||||
public string Name { get; }
|
||||
|
||||
public event TValuePublishedHandler? Pub;
|
||||
|
||||
/// <summary>
|
||||
/// Current PVT value.
|
||||
/// </summary>
|
||||
public TValue Last { get; private set; }
|
||||
|
||||
/// <summary>
|
||||
/// True if the indicator has processed at least 2 bars.
|
||||
/// </summary>
|
||||
public bool IsHot => _s.Index >= 2;
|
||||
|
||||
/// <summary>
|
||||
/// Warmup period required before the indicator is considered hot.
|
||||
/// </summary>
|
||||
#pragma warning disable S2325 // Instance property required by indicator interface convention
|
||||
public int WarmupPeriod => 2;
|
||||
#pragma warning restore S2325
|
||||
|
||||
/// <summary>
|
||||
/// Creates a new PVT indicator.
|
||||
/// </summary>
|
||||
public Pvt()
|
||||
{
|
||||
_s = new State(PvtValue: 0, PrevClose: 0, LastValidClose: 0, LastValidVolume: 0, Index: 0);
|
||||
_ps = _s;
|
||||
Name = "Pvt";
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Resets the indicator state.
|
||||
/// </summary>
|
||||
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
||||
public void Reset()
|
||||
{
|
||||
_s = new State(PvtValue: 0, PrevClose: 0, LastValidClose: 0, LastValidVolume: 0, Index: 0);
|
||||
_ps = _s;
|
||||
Last = default;
|
||||
}
|
||||
|
||||
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
||||
public TValue Update(TBar input, bool isNew = true)
|
||||
{
|
||||
if (isNew)
|
||||
{
|
||||
_ps = _s;
|
||||
}
|
||||
else
|
||||
{
|
||||
_s = _ps;
|
||||
}
|
||||
|
||||
var s = _s;
|
||||
|
||||
// Handle NaN/Infinity in close and volume
|
||||
double close = double.IsFinite(input.Close) ? input.Close : s.LastValidClose;
|
||||
double volume = double.IsFinite(input.Volume) ? input.Volume : s.LastValidVolume;
|
||||
|
||||
if (double.IsFinite(input.Close) && input.Close > 0)
|
||||
{
|
||||
s.LastValidClose = input.Close;
|
||||
}
|
||||
|
||||
if (double.IsFinite(input.Volume) && input.Volume > 0)
|
||||
{
|
||||
s.LastValidVolume = input.Volume;
|
||||
}
|
||||
|
||||
// Calculate PVT: volume * (price_change / prev_price)
|
||||
if (s.Index > 0 && s.PrevClose > 0)
|
||||
{
|
||||
double priceChange = close - s.PrevClose;
|
||||
double priceChangeRatio = priceChange / s.PrevClose;
|
||||
double volumeAdjustment = volume * priceChangeRatio;
|
||||
s.PvtValue += volumeAdjustment;
|
||||
}
|
||||
|
||||
// Store for next iteration
|
||||
s.PrevClose = close;
|
||||
|
||||
if (isNew)
|
||||
{
|
||||
s.Index++;
|
||||
}
|
||||
|
||||
_s = s;
|
||||
|
||||
Last = new TValue(input.Time, s.PvtValue);
|
||||
Pub?.Invoke(this, new TValueEventArgs { Value = Last, IsNew = isNew });
|
||||
return Last;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Updates PVT with price and volume directly.
|
||||
/// </summary>
|
||||
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
||||
public TValue Update(double price, double volume, long time, bool isNew = true)
|
||||
{
|
||||
if (isNew)
|
||||
{
|
||||
_ps = _s;
|
||||
}
|
||||
else
|
||||
{
|
||||
_s = _ps;
|
||||
}
|
||||
|
||||
var s = _s;
|
||||
|
||||
// Handle NaN/Infinity
|
||||
double close = double.IsFinite(price) ? price : s.LastValidClose;
|
||||
double vol = double.IsFinite(volume) ? volume : s.LastValidVolume;
|
||||
|
||||
if (double.IsFinite(price) && price > 0)
|
||||
{
|
||||
s.LastValidClose = price;
|
||||
}
|
||||
|
||||
if (double.IsFinite(volume) && volume > 0)
|
||||
{
|
||||
s.LastValidVolume = volume;
|
||||
}
|
||||
|
||||
// Calculate PVT: volume * (price_change / prev_price)
|
||||
if (s.Index > 0 && s.PrevClose > 0)
|
||||
{
|
||||
double priceChange = close - s.PrevClose;
|
||||
double priceChangeRatio = priceChange / s.PrevClose;
|
||||
double volumeAdjustment = vol * priceChangeRatio;
|
||||
s.PvtValue += volumeAdjustment;
|
||||
}
|
||||
|
||||
// Store for next iteration
|
||||
s.PrevClose = close;
|
||||
|
||||
if (isNew)
|
||||
{
|
||||
s.Index++;
|
||||
}
|
||||
|
||||
_s = s;
|
||||
|
||||
Last = new TValue(time, s.PvtValue);
|
||||
Pub?.Invoke(this, new TValueEventArgs { Value = Last, IsNew = isNew });
|
||||
return Last;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Updates PVT with a TValue input.
|
||||
/// </summary>
|
||||
/// <remarks>
|
||||
/// PVT requires volume data to compute. Using TValue without volume data will
|
||||
/// keep PVT unchanged. For proper PVT calculation, use Update(TBar).
|
||||
/// </remarks>
|
||||
#pragma warning disable S2325 // Method signature must match ITValuePublisher contract
|
||||
public TValue Update(TValue input, bool isNew = true)
|
||||
#pragma warning restore S2325
|
||||
{
|
||||
// PVT requires volume; without it, we can't compute
|
||||
// Return current value unchanged
|
||||
if (isNew)
|
||||
{
|
||||
_ps = _s;
|
||||
}
|
||||
else
|
||||
{
|
||||
_s = _ps;
|
||||
}
|
||||
|
||||
Last = new TValue(input.Time, _s.PvtValue);
|
||||
Pub?.Invoke(this, new TValueEventArgs { Value = Last, IsNew = isNew });
|
||||
return Last;
|
||||
}
|
||||
|
||||
public TSeries Update(TBarSeries source)
|
||||
{
|
||||
var t = new List<long>(source.Count);
|
||||
var v = new List<double>(source.Count);
|
||||
|
||||
Reset();
|
||||
|
||||
for (int i = 0; i < source.Count; i++)
|
||||
{
|
||||
var val = Update(source[i], isNew: true);
|
||||
t.Add(val.Time);
|
||||
v.Add(val.Value);
|
||||
}
|
||||
|
||||
return new TSeries(t, v);
|
||||
}
|
||||
|
||||
public static TSeries Calculate(TBarSeries source)
|
||||
{
|
||||
if (source.Count == 0)
|
||||
{
|
||||
return [];
|
||||
}
|
||||
|
||||
var t = source.Open.Times.ToArray();
|
||||
var v = new double[source.Count];
|
||||
|
||||
Calculate(source.Close.Values, source.Volume.Values, v);
|
||||
|
||||
return new TSeries(t, v);
|
||||
}
|
||||
|
||||
[MethodImpl(MethodImplOptions.AggressiveInlining)]
|
||||
public static void Calculate(ReadOnlySpan<double> close, ReadOnlySpan<double> volume, Span<double> output)
|
||||
{
|
||||
if (close.Length != volume.Length)
|
||||
{
|
||||
throw new ArgumentException("Close and Volume spans must be of the same length", nameof(volume));
|
||||
}
|
||||
|
||||
if (close.Length != output.Length)
|
||||
{
|
||||
throw new ArgumentException("Output span must be of the same length as input", nameof(output));
|
||||
}
|
||||
|
||||
int len = close.Length;
|
||||
if (len == 0)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
// First value is zero (no comparison yet)
|
||||
output[0] = 0;
|
||||
|
||||
double prevClose = close[0];
|
||||
double pvt = 0;
|
||||
|
||||
for (int i = 1; i < len; i++)
|
||||
{
|
||||
double currentClose = close[i];
|
||||
double currentVolume = volume[i];
|
||||
|
||||
// Calculate PVT if inputs are finite and prevClose is positive (consistent with Update method)
|
||||
if (double.IsFinite(currentClose) && double.IsFinite(currentVolume) &&
|
||||
double.IsFinite(prevClose) && prevClose > 0)
|
||||
{
|
||||
double priceChange = currentClose - prevClose;
|
||||
double priceChangeRatio = priceChange / prevClose;
|
||||
pvt += currentVolume * priceChangeRatio;
|
||||
}
|
||||
|
||||
output[i] = pvt;
|
||||
|
||||
// Update prevClose only if current is valid
|
||||
if (double.IsFinite(currentClose))
|
||||
{
|
||||
prevClose = currentClose;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,203 @@
|
||||
# PVT: Price Volume Trend
|
||||
|
||||
> "Volume tells you about the intensity of price moves, but PVT tells you what volume is actually accomplishing." — Unknown
|
||||
|
||||
Price Volume Trend refines the OBV concept by weighting volume according to the percentage price change rather than using an all-or-nothing approach. Where OBV assigns the entire bar's volume to either buyers or sellers, PVT scales the volume contribution by the relative price movement—a 1% move adds only 1% of volume to the running total.
|
||||
|
||||
This proportional weighting makes PVT more sensitive to the magnitude of price changes, not just their direction. A large price move with moderate volume registers more strongly than a tiny price move with massive volume—aligning the indicator more closely with price momentum.
|
||||
|
||||
## Historical Context
|
||||
|
||||
Price Volume Trend emerged as an evolution of On Balance Volume (OBV), addressing what some analysts considered a weakness in Granville's original formulation. The criticism: OBV treats a 0.01% price increase the same as a 10% surge, assigning full volume to either case.
|
||||
|
||||
The modification is straightforward: instead of using sign(price change) × volume, use (percentage price change) × volume. This creates a cumulative indicator that:
|
||||
|
||||
- Still measures buying/selling pressure via volume
|
||||
- Weights contributions by the significance of price moves
|
||||
- Reduces sensitivity to noise (small price changes)
|
||||
- Amplifies response to significant moves
|
||||
|
||||
PVT gained popularity among traders who found OBV too reactive to minor price fluctuations. By incorporating price magnitude, PVT provides a smoother view of volume-weighted momentum while maintaining the cumulative structure that makes divergence analysis effective.
|
||||
|
||||
The indicator appears in most major technical analysis platforms under names including "Price Volume Trend," "Volume Price Trend," or simply "PVT."
|
||||
|
||||
## Architecture & Physics
|
||||
|
||||
PVT operates as a weighted accumulator where each bar's contribution depends on both volume and the percentage change in price. The formula scales volume by the relative price movement, creating a more nuanced measure of buying/selling pressure.
|
||||
|
||||
### Component Breakdown
|
||||
|
||||
1. **Price Change**: Calculate difference from previous close
|
||||
2. **Price Change Ratio**: Normalize by previous price (percentage)
|
||||
3. **Volume Adjustment**: Scale volume by the ratio
|
||||
4. **Cumulative Total**: Running sum of adjusted volumes
|
||||
|
||||
### State Requirements
|
||||
|
||||
| Component | Type | Purpose |
|
||||
| :--- | :--- | :--- |
|
||||
| PvtValue | double | Current cumulative PVT |
|
||||
| PrevClose | double | Previous bar's close for ratio calculation |
|
||||
| LastValidClose | double | Fallback for NaN/Infinity handling |
|
||||
| LastValidVolume | double | Fallback for NaN/Infinity handling |
|
||||
|
||||
## Mathematical Foundation
|
||||
|
||||
### Core Formula
|
||||
|
||||
$$
|
||||
PVT_t = PVT_{t-1} + Volume_t \times \frac{Close_t - Close_{t-1}}{Close_{t-1}}
|
||||
$$
|
||||
|
||||
where:
|
||||
|
||||
- $PVT_0 = 0$ (starts at zero)
|
||||
- Division by zero (prev_close = 0) yields no contribution
|
||||
|
||||
### Expanded Form
|
||||
|
||||
$$
|
||||
PVT_t = \sum_{i=1}^{t} V_i \times \frac{C_i - C_{i-1}}{C_{i-1}}
|
||||
$$
|
||||
|
||||
This can be rewritten as:
|
||||
|
||||
$$
|
||||
PVT_t = \sum_{i=1}^{t} V_i \times \left(\frac{C_i}{C_{i-1}} - 1\right)
|
||||
$$
|
||||
|
||||
or equivalently:
|
||||
|
||||
$$
|
||||
PVT_t = \sum_{i=1}^{t} V_i \times r_i
|
||||
$$
|
||||
|
||||
where $r_i$ is the simple return at bar $i$.
|
||||
|
||||
### Comparison with OBV
|
||||
|
||||
| Indicator | Formula | Sensitivity |
|
||||
| :--- | :--- | :--- |
|
||||
| **OBV** | $\sum V_i \times \text{sign}(C_i - C_{i-1})$ | Direction only |
|
||||
| **PVT** | $\sum V_i \times (C_i - C_{i-1}) / C_{i-1}$ | Magnitude weighted |
|
||||
|
||||
PVT dampens small moves and amplifies large moves, while OBV treats all directional changes equally.
|
||||
|
||||
### Why Percentage-Based?
|
||||
|
||||
Using percentage change rather than absolute price change:
|
||||
|
||||
- Makes PVT comparable across different price levels
|
||||
- A $1 move on a $10 stock (10%) contributes more than $1 on a $100 stock (1%)
|
||||
- Aligns with return-based thinking in portfolio analysis
|
||||
- Normalizes the indicator across time (stock splits, price drift)
|
||||
|
||||
## Performance Profile
|
||||
|
||||
### Operation Count (Streaming Mode)
|
||||
|
||||
| Operation | Count | Notes |
|
||||
| :--- | :---: | :--- |
|
||||
| SUB | 1 | Close - PrevClose |
|
||||
| DIV | 1 | Price change / PrevClose |
|
||||
| MUL | 1 | Volume × ratio |
|
||||
| ADD | 1 | Cumulative sum |
|
||||
| **Total** | 4 | Per bar, O(1) |
|
||||
|
||||
Slightly heavier than OBV due to the division, but still extremely lightweight.
|
||||
|
||||
### Batch Mode (SIMD)
|
||||
|
||||
| Operation | Vectorizable | Notes |
|
||||
| :--- | :---: | :--- |
|
||||
| Price differences | ✅ | Close[i] - Close[i-1] |
|
||||
| Division | ✅ | Element-wise division |
|
||||
| Volume scaling | ✅ | Element-wise multiply |
|
||||
| Cumulative sum | ❌ | Sequential dependency |
|
||||
|
||||
Like OBV, the cumulative sum prevents full vectorization. However, the per-element calculations can be vectorized before the final prefix sum.
|
||||
|
||||
### Quality Metrics
|
||||
|
||||
| Metric | Score | Notes |
|
||||
| :--- | :---: | :--- |
|
||||
| **Accuracy** | 10/10 | Exact floating-point computation |
|
||||
| **Timeliness** | 8/10 | Immediate response to price changes |
|
||||
| **Overshoot** | N/A | No bounds; cumulative indicator |
|
||||
| **Smoothness** | 7/10 | Smoother than OBV for small moves |
|
||||
| **Memory** | 10/10 | O(1) state: 2-4 scalar values |
|
||||
|
||||
## Validation
|
||||
|
||||
| Library | Status | Notes |
|
||||
| :--- | :---: | :--- |
|
||||
| **TA-Lib** | N/A | Not implemented |
|
||||
| **Skender** | ✅ | `Pvt` indicator, exact match |
|
||||
| **Tulip** | N/A | Not implemented |
|
||||
| **Ooples** | ✅ | `Pvt` indicator, exact match |
|
||||
| **PineScript** | ✅ | Custom implementation, exact match |
|
||||
|
||||
QuanTAlib implementation validated against Skender and Ooples with tight tolerances (1e-9). PVT is less universally implemented than OBV, but available in major .NET libraries.
|
||||
|
||||
## Common Pitfalls
|
||||
|
||||
1. **Absolute Value Meaningless**: Like OBV, PVT's numeric value has no intrinsic meaning—only direction and divergences matter. Don't compare PVT values across different securities.
|
||||
|
||||
2. **Not Bounded**: PVT can reach any value, positive or negative. There are no overbought/oversold levels.
|
||||
|
||||
3. **Scale Depends on Price Level**: While percentage-based, PVT values are still influenced by the absolute price level during calculation. Use relative analysis (slopes, divergences) rather than absolute comparisons.
|
||||
|
||||
4. **Division by Zero**: If previous close is zero (rare but possible with some data feeds), the formula produces no contribution. QuanTAlib handles this gracefully.
|
||||
|
||||
5. **Small Price Changes Damped**: Unlike OBV, a 0.1% move with huge volume barely registers in PVT. This is a feature for noise reduction but may miss significant volume events with small price impact.
|
||||
|
||||
6. **Volume Data Quality**: PVT is only as reliable as volume data. Extended hours, different exchange feeds, or estimated volume can produce misleading signals.
|
||||
|
||||
7. **TValue Limitations**: The `Update(TValue)` method cannot compute PVT without volume data. Use `Update(TBar)` for proper calculation.
|
||||
|
||||
8. **isNew Parameter**: When correcting bars (isNew=false), the implementation properly restores previous state. Incorrect handling causes cumulative drift.
|
||||
|
||||
## Interpretation Guide
|
||||
|
||||
### Trend Confirmation
|
||||
|
||||
| Price Trend | PVT Trend | Interpretation |
|
||||
| :--- | :--- | :--- |
|
||||
| Rising | Rising | Confirmed uptrend, magnitude-weighted |
|
||||
| Falling | Falling | Confirmed downtrend, magnitude-weighted |
|
||||
| Rising | Falling | Bearish divergence: large down days outweigh |
|
||||
| Falling | Rising | Bullish divergence: large up days outweigh |
|
||||
|
||||
### PVT vs OBV Signals
|
||||
|
||||
| Scenario | OBV | PVT | Interpretation |
|
||||
| :--- | :--- | :--- | :--- |
|
||||
| Many small up days | Strong rise | Weak rise | OBV overstates strength |
|
||||
| Few large up days | Weak rise | Strong rise | PVT captures momentum |
|
||||
| High volume, tiny move | Large change | Small change | PVT filters noise |
|
||||
|
||||
### Divergence Trading
|
||||
|
||||
PVT divergences often precede OBV divergences because magnitude weighting reveals conviction earlier:
|
||||
|
||||
| Signal | Setup | Action |
|
||||
| :--- | :--- | :--- |
|
||||
| Bullish | Price makes lower low, PVT makes higher low | Anticipate reversal up |
|
||||
| Bearish | Price makes higher high, PVT makes lower high | Anticipate reversal down |
|
||||
|
||||
### Signal Line
|
||||
|
||||
PVT is often paired with a moving average (signal line) for crossover signals:
|
||||
|
||||
- PVT crossing above signal line: bullish
|
||||
- PVT crossing below signal line: bearish
|
||||
|
||||
The default signal period is typically 14-21 bars.
|
||||
|
||||
## References
|
||||
|
||||
- Achelis, S. (2001). *Technical Analysis from A to Z*. McGraw-Hill.
|
||||
- Murphy, J. (1999). *Technical Analysis of the Financial Markets*. New York Institute of Finance.
|
||||
- Investopedia. "Price Volume Trend (PVT)." [Definition](https://www.investopedia.com/terms/p/pricevolumetrend.asp)
|
||||
- StockCharts. "Price Volume Trend." [Technical Indicators](https://school.stockcharts.com/doku.php?id=technical_indicators:price_volume_trend_pvt)
|
||||
- TradingView. "Volume Indicators." [Reference](https://www.tradingview.com/scripts/volume/)
|
||||
Reference in New Issue
Block a user