refactor: update validation test classes to be sealed and simplify Dispose methods

This commit is contained in:
Miha Kralj
2025-12-26 16:43:23 -08:00
parent bfb0f6a322
commit 4750c2b1e8
31 changed files with 238 additions and 228 deletions
+2 -11
View File
@@ -6,7 +6,7 @@ using Skender.Stock.Indicators;
namespace QuanTAlib.Tests;
public class BetaValidationTests : IDisposable
public sealed class BetaValidationTests : IDisposable
{
private readonly ValidationTestData _data;
@@ -17,16 +17,7 @@ public class BetaValidationTests : IDisposable
public void Dispose()
{
Dispose(true);
GC.SuppressFinalize(this);
}
protected virtual void Dispose(bool disposing)
{
if (disposing)
{
_data.Dispose();
}
_data.Dispose();
}
[Fact]
@@ -9,7 +9,7 @@ using System.Collections.Generic;
namespace QuanTAlib.Tests;
public class LinRegValidationTests : IDisposable
public sealed class LinRegValidationTests : IDisposable
{
private readonly ValidationTestData _data;
@@ -20,16 +20,7 @@ public class LinRegValidationTests : IDisposable
public void Dispose()
{
Dispose(true);
GC.SuppressFinalize(this);
}
protected virtual void Dispose(bool disposing)
{
if (disposing)
{
_data.Dispose();
}
_data.Dispose();
}
[SkipLocalsInit]
@@ -8,22 +8,13 @@ using MathNet.Numerics.Statistics;
namespace QuanTAlib.Validation;
public class MedianValidationTests : IDisposable
public sealed class MedianValidationTests : IDisposable
{
private readonly ValidationTestData _data = new();
public void Dispose()
{
Dispose(true);
GC.SuppressFinalize(this);
}
protected virtual void Dispose(bool disposing)
{
if (disposing)
{
_data.Dispose();
}
_data.Dispose();
}
// Note: Standard TA libraries (Skender, TA-Lib, Tulip, Ooples) do not provide a
+2 -11
View File
@@ -7,22 +7,13 @@ using MathNet.Numerics.Statistics;
namespace QuanTAlib.Validation;
public class SkewValidationTests : IDisposable
public sealed class SkewValidationTests : IDisposable
{
private readonly ValidationTestData _data = new();
public void Dispose()
{
Dispose(true);
GC.SuppressFinalize(this);
}
protected virtual void Dispose(bool disposing)
{
if (disposing)
{
_data.Dispose();
}
_data.Dispose();
}
[Fact]