From 19df6763a9e80aef8d909ec02202c8dfa8cd8fda Mon Sep 17 00:00:00 2001
From: Miha Kralj <miha.kralj@outlook.com>
Date: Sun, 1 Mar 2026 13:45:24 -0800
Subject: [PATCH] fix: guard SonarLint ruleset refs with Exists() condition

.sonarlint/ is gitignored so CI and fresh clones lack these files. Unconditional CodeAnalysisRuleSet reference caused MSB3884 error which with /warnaserror broke Release builds and froze JB InspectCode.
---
 Directory.Build.props | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Directory.Build.props b/Directory.Build.props
index ecaf7b60..7f7b9202 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -78,11 +78,13 @@
     <Exclude>[xunit.*]*,[*.Tests]*</Exclude>
   </PropertyGroup>
 
-  <!-- SonarLint local rule configuration -->
-  <PropertyGroup>
+  <!-- SonarLint local rule configuration (IDE-only, not committed to git)
+       The SonarLint VS/VSCode plugin manages .sonarlint/ locally.
+       SonarAnalyzer.CSharp NuGet provides build-time analysis; suppressions are in <NoWarn> above. -->
+  <PropertyGroup Condition="Exists('$(MSBuildThisFileDirectory).sonarlint\csharp.ruleset')">
     <CodeAnalysisRuleSet>$(MSBuildThisFileDirectory).sonarlint\csharp.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>
-  <ItemGroup>
+  <ItemGroup Condition="Exists('$(MSBuildThisFileDirectory).sonarlint\CSharp\SonarLint.xml')">
     <AdditionalFiles Include="$(MSBuildThisFileDirectory).sonarlint\CSharp\SonarLint.xml">
       <Link>Properties\SonarLint.xml</Link>
     </AdditionalFiles>