docs: remove C# Implementation Considerations sections, clean up temp scripts, reorganize test files

- Remove 'C# Implementation Considerations' sections from 34 indicator .md files - Delete 29 temp PowerShell scripts (_fix_mojibake.ps1, _hex_scan.ps1, etc.) - Move test files into tests/ subdirectories for consistent project structure - Add trader-focused bullet points to indicator documentation
2026-08-23 21:18:04 +00:00 · 2026-03-12 12:34:16 -07:00
parent 8937b0c0fa
commit 060649192f
1149 changed files with 1780 additions and 3316 deletions
@@ -0,0 +1,127 @@
+using TradingPlatform.BusinessLayer;
+using QuanTAlib;
+
+namespace QuanTAlib.Tests;
+
+public sealed class PivotfibIndicatorTests
+{
+    [Fact]
+    public void PivotfibIndicator_Constructor_SetsDefaults()
+    {
+        var indicator = new PivotfibIndicator();
+
+        Assert.True(indicator.ShowColdValues);
+        Assert.Contains("PIVOTFIB", indicator.Name, StringComparison.Ordinal);
+        Assert.False(indicator.SeparateWindow);
+        Assert.True(indicator.OnBackGround);
+    }
+
+    [Fact]
+    public void PivotfibIndicator_MinHistoryDepths_EqualsZero()
+    {
+        var indicator = new PivotfibIndicator();
+
+        Assert.Equal(0, PivotfibIndicator.MinHistoryDepths);
+        IWatchlistIndicator watchlistIndicator = indicator;
+        Assert.Equal(0, watchlistIndicator.MinHistoryDepths);
+    }
+
+    [Fact]
+    public void PivotfibIndicator_ShortName_IsPivotfib()
+    {
+        var indicator = new PivotfibIndicator();
+        indicator.Initialize();
+
+        Assert.Contains("PIVOTFIB", indicator.ShortName, StringComparison.Ordinal);
+    }
+
+    [Fact]
+    public void PivotfibIndicator_SourceCodeLink_IsValid()
+    {
+        var indicator = new PivotfibIndicator();
+
+        Assert.Contains("github.com", indicator.SourceCodeLink, StringComparison.Ordinal);
+        Assert.Contains("Pivotfib", indicator.SourceCodeLink, StringComparison.Ordinal);
+    }
+
+    [Fact]
+    public void PivotfibIndicator_Initialize_CreatesInternalIndicator()
+    {
+        var indicator = new PivotfibIndicator();
+
+        indicator.Initialize();
+
+        // 7 line series: PP, R1, R2, R3, S1, S2, S3
+        Assert.Equal(7, indicator.LinesSeries.Count);
+    }
+
+    [Fact]
+    public void PivotfibIndicator_ProcessUpdate_HistoricalBar_ComputesValue()
+    {
+        var indicator = new PivotfibIndicator();
+        indicator.Initialize();
+
+        var now = DateTime.UtcNow;
+        for (int i = 0; i < 10; i++)
+        {
+            double basePrice = 100 + i * 2;
+            indicator.HistoricalData.AddBar(now.AddMinutes(i), basePrice, basePrice + 5, basePrice - 5, basePrice + 2);
+
+            var args = new UpdateArgs(UpdateReason.HistoricalBar);
+            indicator.ProcessUpdate(args);
+        }
+
+        // PP is index 0
+        double pp = indicator.LinesSeries[0].GetValue(0);
+        Assert.True(double.IsFinite(pp) || double.IsNaN(pp));
+    }
+
+    [Fact]
+    public void PivotfibIndicator_ProcessUpdate_NewBar_ComputesValue()
+    {
+        var indicator = new PivotfibIndicator();
+        indicator.Initialize();
+
+        var now = DateTime.UtcNow;
+        for (int i = 0; i < 5; i++)
+        {
+            indicator.HistoricalData.AddBar(now.AddMinutes(i), 100 + i, 110 + i, 90 + i, 105 + i);
+            var args = new UpdateArgs(UpdateReason.HistoricalBar);
+            indicator.ProcessUpdate(args);
+        }
+
+        // Simulate a new bar
+        indicator.HistoricalData.AddBar(now.AddMinutes(5), 110, 120, 100, 115);
+        var newArgs = new UpdateArgs(UpdateReason.NewBar);
+        indicator.ProcessUpdate(newArgs);
+
+        double pp = indicator.LinesSeries[0].GetValue(0);
+        Assert.True(double.IsFinite(pp) || double.IsNaN(pp));
+    }
+
+    [Fact]
+    public void PivotfibIndicator_SevenLineSeries_ArePresent()
+    {
+        var indicator = new PivotfibIndicator();
+        indicator.Initialize();
+
+        // PP=0, R1=1, R2=2, R3=3, S1=4, S2=5, S3=6
+        Assert.Equal(7, indicator.LinesSeries.Count);
+        Assert.Contains("PP", indicator.LinesSeries[0].Name, StringComparison.OrdinalIgnoreCase);
+        Assert.Contains("R1", indicator.LinesSeries[1].Name, StringComparison.OrdinalIgnoreCase);
+        Assert.Contains("S1", indicator.LinesSeries[4].Name, StringComparison.OrdinalIgnoreCase);
+        // Verify Fibonacci ratios in series names
+        Assert.Contains("38.2", indicator.LinesSeries[1].Name, StringComparison.Ordinal);
+        Assert.Contains("61.8", indicator.LinesSeries[2].Name, StringComparison.Ordinal);
+    }
+
+    [Fact]
+    public void PivotfibIndicator_Description_IsSet()
+    {
+        var indicator = new PivotfibIndicator();
+
+        Assert.NotNull(indicator.Description);
+        Assert.NotEmpty(indicator.Description);
+        Assert.Contains("Fibonacci", indicator.Description, StringComparison.OrdinalIgnoreCase);
+    }
+}