docs: remove C# Implementation Considerations sections, clean up temp scripts, reorganize test files

- Remove 'C# Implementation Considerations' sections from 34 indicator .md files
- Delete 29 temp PowerShell scripts (_fix_mojibake.ps1, _hex_scan.ps1, etc.)
- Move test files into tests/ subdirectories for consistent project structure
- Add trader-focused bullet points to indicator documentation
This commit is contained in:
Miha Kralj
2026-03-12 12:34:16 -07:00
parent 8937b0c0fa
commit 060649192f
1149 changed files with 1780 additions and 3316 deletions
+298
View File
@@ -0,0 +1,298 @@
using Xunit;
namespace QuanTAlib.Tests;
public class LowestTests
{
private const double Tolerance = 1e-10;
[Fact]
public void Constructor_InvalidPeriod_ThrowsArgumentException()
{
Assert.Throws<ArgumentException>(() => new Lowest(0));
Assert.Throws<ArgumentException>(() => new Lowest(-1));
}
[Fact]
public void Constructor_ValidPeriod_SetsProperties()
{
var indicator = new Lowest(14);
Assert.Equal("Lowest(14)", indicator.Name);
Assert.Equal(14, indicator.WarmupPeriod);
Assert.False(indicator.IsHot);
}
[Fact]
public void Update_ReturnsLowestInWindow()
{
var indicator = new Lowest(3);
var time = DateTime.UtcNow;
indicator.Update(new TValue(time, 5.0));
Assert.Equal(5.0, indicator.Last.Value, Tolerance);
indicator.Update(new TValue(time.AddMinutes(1), 3.0));
Assert.Equal(3.0, indicator.Last.Value, Tolerance);
indicator.Update(new TValue(time.AddMinutes(2), 8.0));
Assert.Equal(3.0, indicator.Last.Value, Tolerance);
// 5 drops out of window
indicator.Update(new TValue(time.AddMinutes(3), 10.0));
Assert.Equal(3.0, indicator.Last.Value, Tolerance);
// 3 drops out of window
indicator.Update(new TValue(time.AddMinutes(4), 7.0));
Assert.Equal(7.0, indicator.Last.Value, Tolerance);
}
[Fact]
public void Update_Period1_ReturnsSameValue()
{
var indicator = new Lowest(1);
var time = DateTime.UtcNow;
for (int i = 0; i < 10; i++)
{
double value = i * 2.5;
indicator.Update(new TValue(time.AddMinutes(i), value));
Assert.Equal(value, indicator.Last.Value, Tolerance);
}
}
[Fact]
public void Update_IsNewFalse_CorrectsPreviousValue()
{
var indicator = new Lowest(5);
var time = DateTime.UtcNow;
indicator.Update(new TValue(time, 10.0));
indicator.Update(new TValue(time.AddMinutes(1), 5.0));
indicator.Update(new TValue(time.AddMinutes(2), 15.0));
Assert.Equal(5.0, indicator.Last.Value, Tolerance);
// Correct last value to be the new min
indicator.Update(new TValue(time.AddMinutes(2), 2.0), isNew: false);
Assert.Equal(2.0, indicator.Last.Value, Tolerance);
}
[Fact]
public void Update_IterativeCorrection_RestoresState()
{
var indicator = new Lowest(5);
var time = DateTime.UtcNow;
double[] values = { 15.0, 10.0, 12.0, 8.0, 13.0, 5.0, 11.0 };
// Process all values
foreach (var v in values)
{
indicator.Update(new TValue(time, v));
time = time.AddMinutes(1);
}
double finalResult = indicator.Last.Value;
// Reset and process with corrections
indicator.Reset();
time = DateTime.UtcNow;
foreach (var v in values)
{
// Submit wrong value first
indicator.Update(new TValue(time, 100.0));
// Correct it
indicator.Update(new TValue(time, v), isNew: false);
time = time.AddMinutes(1);
}
Assert.Equal(finalResult, indicator.Last.Value, Tolerance);
}
[Fact]
public void Update_NaN_UsesLastValidValue()
{
var indicator = new Lowest(5);
var time = DateTime.UtcNow;
indicator.Update(new TValue(time, 10.0));
indicator.Update(new TValue(time.AddMinutes(1), 5.0));
double beforeNaN = indicator.Last.Value;
indicator.Update(new TValue(time.AddMinutes(2), double.NaN));
Assert.Equal(beforeNaN, indicator.Last.Value, Tolerance);
}
[Fact]
public void Update_Infinity_UsesLastValidValue()
{
var indicator = new Lowest(5);
var time = DateTime.UtcNow;
indicator.Update(new TValue(time, 15.0));
indicator.Update(new TValue(time.AddMinutes(1), double.NegativeInfinity));
Assert.True(double.IsFinite(indicator.Last.Value));
}
[Fact]
public void IsHot_BecomesTrueAfterWarmup()
{
var indicator = new Lowest(5);
var time = DateTime.UtcNow;
for (int i = 0; i < 4; i++)
{
indicator.Update(new TValue(time.AddMinutes(i), i));
Assert.False(indicator.IsHot);
}
indicator.Update(new TValue(time.AddMinutes(4), 4));
Assert.True(indicator.IsHot);
}
[Fact]
public void Reset_ClearsState()
{
var indicator = new Lowest(5);
var time = DateTime.UtcNow;
for (int i = 0; i < 10; i++)
{
indicator.Update(new TValue(time.AddMinutes(i), i * 2));
}
Assert.True(indicator.IsHot);
indicator.Reset();
Assert.False(indicator.IsHot);
Assert.Equal(default, indicator.Last);
}
[Fact]
public void Pub_EventFires()
{
var indicator = new Lowest(5);
int eventCount = 0;
indicator.Pub += (object? sender, in TValueEventArgs args) => eventCount++;
indicator.Update(new TValue(DateTime.UtcNow, 10.0));
Assert.Equal(1, eventCount);
}
[Fact]
public void Chaining_Constructor_Works()
{
var source = new TSeries();
var indicator = new Lowest(source, 5);
source.Add(new TValue(DateTime.UtcNow, 10.0), true);
Assert.Equal(10.0, indicator.Last.Value, Tolerance);
source.Add(new TValue(DateTime.UtcNow.AddMinutes(1), 5.0), true);
Assert.Equal(5.0, indicator.Last.Value, Tolerance);
}
[Fact]
public void Calculate_TSeries_MatchesStreaming()
{
int period = 5;
int count = 50;
var gbm = new GBM(startPrice: 100, mu: 0.05, sigma: 0.2, seed: 10002);
var bars = gbm.Fetch(count, DateTime.UtcNow.Ticks, TimeSpan.FromMinutes(1));
var source = bars.Close;
// Streaming
var streaming = new Lowest(period);
var streamingResults = new List<double>();
for (int i = 0; i < source.Count; i++)
{
streaming.Update(source[i]);
streamingResults.Add(streaming.Last.Value);
}
// Batch
var batch = Lowest.Batch(source, period);
// Compare last values (after warmup)
for (int i = period; i < source.Count; i++)
{
Assert.Equal(streamingResults[i], batch[i].Value, Tolerance);
}
}
[Fact]
public void Calculate_Span_MatchesTSeries()
{
int period = 5;
int count = 50;
var gbm = new GBM(startPrice: 100, mu: 0.05, sigma: 0.2, seed: 10003);
var bars = gbm.Fetch(count, DateTime.UtcNow.Ticks, TimeSpan.FromMinutes(1));
var source = bars.Close;
// TSeries batch
var batchResult = Lowest.Batch(source, period);
// Span calculation
var values = source.Values.ToArray();
var output = new double[count];
Lowest.Batch(values, output, period);
for (int i = 0; i < source.Count; i++)
{
Assert.Equal(batchResult[i].Value, output[i], Tolerance);
}
}
[Fact]
public void Calculate_Span_ValidatesArguments()
{
Assert.Throws<ArgumentException>(() =>
{
Span<double> output = stackalloc double[10];
Lowest.Batch(ReadOnlySpan<double>.Empty, output, 5);
});
Assert.Throws<ArgumentException>(() =>
{
ReadOnlySpan<double> source = stackalloc double[10];
Span<double> output = stackalloc double[5];
Lowest.Batch(source, output, 5);
});
Assert.Throws<ArgumentException>(() =>
{
ReadOnlySpan<double> source = stackalloc double[10];
Span<double> output = stackalloc double[10];
Lowest.Batch(source, output, 0);
});
}
[Fact]
public void MonotonicSequence_Descending_ReturnsLatest()
{
var indicator = new Lowest(5);
var time = DateTime.UtcNow;
for (int i = 10; i >= 1; i--)
{
indicator.Update(new TValue(time.AddMinutes(10 - i), i));
Assert.Equal(i, indicator.Last.Value, Tolerance);
}
}
[Fact]
public void MonotonicSequence_Ascending_ReturnsFirst()
{
var indicator = new Lowest(5);
var time = DateTime.UtcNow;
indicator.Update(new TValue(time, 1.0));
Assert.Equal(1.0, indicator.Last.Value, Tolerance);
for (int i = 1; i < 5; i++)
{
indicator.Update(new TValue(time.AddMinutes(i), 1.0 + i));
Assert.Equal(1.0, indicator.Last.Value, Tolerance);
}
// After 5 values, 1.0 drops out
indicator.Update(new TValue(time.AddMinutes(5), 6.0));
Assert.Equal(2.0, indicator.Last.Value, Tolerance);
}
}
@@ -0,0 +1,210 @@
using TALib;
using Xunit.Abstractions;
namespace QuanTAlib.Tests;
public sealed class LowestValidationTests : IDisposable
{
private readonly ValidationTestData _testData;
private readonly ITestOutputHelper _output;
private bool _disposed;
public LowestValidationTests(ITestOutputHelper output)
{
_output = output;
_testData = new ValidationTestData();
}
public void Dispose()
{
Dispose(true);
}
private void Dispose(bool disposing)
{
if (_disposed)
{
return;
}
_disposed = true;
if (disposing)
{
_testData?.Dispose();
}
}
[Fact]
public void Validate_Talib_Batch()
{
int[] periods = { 5, 10, 14, 20, 50 };
double[] tData = _testData.RawData.ToArray();
double[] output = new double[tData.Length];
foreach (var period in periods)
{
// Calculate QuanTAlib Lowest (batch TSeries)
var lowest = new Lowest(period);
var qResult = lowest.Update(_testData.Data);
// Calculate TA-Lib MIN
var retCode = TALib.Functions.Min<double>(tData, 0..^0, output, out var outRange, period);
Assert.Equal(TALib.Core.RetCode.Success, retCode);
int lookback = TALib.Functions.MinLookback(period);
// Compare last 100 records
ValidationHelper.VerifyData(qResult, output, outRange, lookback);
}
_output.WriteLine("Lowest Batch(TSeries) validated successfully against TA-Lib MIN");
}
[Fact]
public void Validate_Talib_Streaming()
{
int[] periods = { 5, 10, 14, 20, 50 };
double[] tData = _testData.RawData.ToArray();
double[] output = new double[tData.Length];
foreach (var period in periods)
{
// Calculate QuanTAlib Lowest (streaming)
var lowest = new Lowest(period);
var qResults = new List<double>();
foreach (var item in _testData.Data)
{
qResults.Add(lowest.Update(item).Value);
}
// Calculate TA-Lib MIN
var retCode = TALib.Functions.Min<double>(tData, 0..^0, output, out var outRange, period);
Assert.Equal(TALib.Core.RetCode.Success, retCode);
int lookback = TALib.Functions.MinLookback(period);
// Compare last 100 records
ValidationHelper.VerifyData(qResults, output, outRange, lookback);
}
_output.WriteLine("Lowest Streaming validated successfully against TA-Lib MIN");
}
[Fact]
public void Validate_Talib_Span()
{
int[] periods = { 5, 10, 14, 20, 50 };
double[] sourceData = _testData.RawData.ToArray();
double[] talibOutput = new double[sourceData.Length];
foreach (var period in periods)
{
// Calculate QuanTAlib Lowest (Span API)
double[] qOutput = new double[sourceData.Length];
Lowest.Batch(sourceData.AsSpan(), qOutput.AsSpan(), period);
// Calculate TA-Lib MIN
var retCode = TALib.Functions.Min<double>(sourceData, 0..^0, talibOutput, out var outRange, period);
Assert.Equal(TALib.Core.RetCode.Success, retCode);
int lookback = TALib.Functions.MinLookback(period);
// Compare last 100 records
ValidationHelper.VerifyData(qOutput, talibOutput, outRange, lookback);
}
_output.WriteLine("Lowest Span validated successfully against TA-Lib MIN");
}
[Fact]
public void Validate_Tulip_Batch()
{
int[] periods = { 5, 10, 14, 20, 50 };
double[] tData = _testData.RawData.ToArray();
foreach (var period in periods)
{
// Calculate QuanTAlib Lowest (batch TSeries)
var lowest = new Lowest(period);
var qResult = lowest.Update(_testData.Data);
// Calculate Tulip min
var minIndicator = Tulip.Indicators.min;
double[][] inputs = { tData };
double[] options = { period };
int lookback = period - 1;
double[][] outputs = { new double[tData.Length - lookback] };
minIndicator.Run(inputs, options, outputs);
var tResult = outputs[0];
// Compare last 100 records
ValidationHelper.VerifyData(qResult, tResult, lookback);
}
_output.WriteLine("Lowest Batch(TSeries) validated successfully against Tulip min");
}
[Fact]
public void Validate_Tulip_Streaming()
{
int[] periods = { 5, 10, 14, 20, 50 };
double[] tData = _testData.RawData.ToArray();
foreach (var period in periods)
{
// Calculate QuanTAlib Lowest (streaming)
var lowest = new Lowest(period);
var qResults = new List<double>();
foreach (var item in _testData.Data)
{
qResults.Add(lowest.Update(item).Value);
}
// Calculate Tulip min
var minIndicator = Tulip.Indicators.min;
double[][] inputs = { tData };
double[] options = { period };
int lookback = period - 1;
double[][] outputs = { new double[tData.Length - lookback] };
minIndicator.Run(inputs, options, outputs);
var tResult = outputs[0];
// Compare last 100 records
ValidationHelper.VerifyData(qResults, tResult, lookback);
}
_output.WriteLine("Lowest Streaming validated successfully against Tulip min");
}
[Fact]
public void Validate_KnownValues()
{
// Test with simple known sequence
double[] data = { 10, 5, 8, 2, 9, 1, 7, 4, 6, 3 };
int period = 3;
// Expected: first=10, second=min(10,5)=5, then sliding min of last 3
// [10] -> 10
// [10,5] -> 5
// [10,5,8] -> 5
// [5,8,2] -> 2
// [8,2,9] -> 2
// [2,9,1] -> 1
// [9,1,7] -> 1
// [1,7,4] -> 1
// [7,4,6] -> 4
// [4,6,3] -> 3
double[] expected = { 10, 5, 5, 2, 2, 1, 1, 1, 4, 3 };
var lowest = new Lowest(period);
for (int i = 0; i < data.Length; i++)
{
var result = lowest.Update(new TValue(DateTime.UtcNow, data[i]));
Assert.Equal(expected[i], result.Value, precision: 10);
}
_output.WriteLine("Lowest validated with known values");
}
}