569f3eef97
Proxy routes now share one upstream-error adapter so client-actionable statuses such as auth, entitlement, validation, and rate limits survive the BFF instead of becoming opaque 502s. The scan terminal mobile overrides also load last and remove desktop rail constraints so phones get a single readable column. Constraint: Mobile users reported the dashboard was unreadable, and BFF proxy errors were masking expected client states. Rejected: Let every route keep bespoke error JSON | continued inconsistent status codes and production detail leakage. Confidence: high Scope-risk: moderate Directive: Keep ScanTerminalMobile.module.css imported after desktop scan-terminal CSS so mobile breakpoints win. Tested: npx tsc --noEmit --pretty false --project frontend/tsconfig.json Tested: npm run build Tested: npm run test:business Tested: Chrome mobile smoke test at 390px with no horizontal overflow Not-tested: Real device Safari/Android manual QA
73 lines
1.5 KiB
TypeScript
73 lines
1.5 KiB
TypeScript
import { NextResponse } from "next/server";
|
|
|
|
const PASSTHROUGH_UPSTREAM_STATUSES = new Set([
|
|
400,
|
|
401,
|
|
402,
|
|
403,
|
|
404,
|
|
409,
|
|
422,
|
|
429,
|
|
]);
|
|
|
|
function shouldExposeProxyErrorDetail() {
|
|
return (
|
|
process.env.NODE_ENV !== "production" ||
|
|
process.env.POLYWEATHER_EXPOSE_PROXY_ERROR_DETAIL === "true"
|
|
);
|
|
}
|
|
|
|
export function clientStatusFromUpstream(status: number) {
|
|
if (PASSTHROUGH_UPSTREAM_STATUSES.has(status)) {
|
|
return status;
|
|
}
|
|
return 502;
|
|
}
|
|
|
|
export function buildUpstreamErrorResponse(
|
|
upstreamStatus: number,
|
|
rawDetail: string,
|
|
options?: {
|
|
detailLimit?: number;
|
|
error?: string;
|
|
extraDebug?: Record<string, unknown>;
|
|
},
|
|
) {
|
|
const body: Record<string, unknown> = {
|
|
error: options?.error || "Upstream request failed",
|
|
upstream_status: upstreamStatus,
|
|
};
|
|
|
|
if (shouldExposeProxyErrorDetail()) {
|
|
body.detail = String(rawDetail || "").slice(0, options?.detailLimit ?? 300);
|
|
if (options?.extraDebug) {
|
|
body.proxy_debug = options.extraDebug;
|
|
}
|
|
}
|
|
|
|
return NextResponse.json(body, {
|
|
status: clientStatusFromUpstream(upstreamStatus),
|
|
});
|
|
}
|
|
|
|
export function buildProxyExceptionResponse(
|
|
error: unknown,
|
|
options: {
|
|
status?: number;
|
|
publicMessage: string;
|
|
extra?: Record<string, unknown>;
|
|
},
|
|
) {
|
|
const body: Record<string, unknown> = {
|
|
error: options.publicMessage,
|
|
...(options.extra || {}),
|
|
};
|
|
|
|
if (shouldExposeProxyErrorDetail()) {
|
|
body.detail = String(error);
|
|
}
|
|
|
|
return NextResponse.json(body, { status: options.status ?? 500 });
|
|
}
|