Disable default Wunderground fetching

src/data_collection/weather_sources.py

@@ -1792,7 +1792,6 @@ class WeatherDataCollector(OpenMeteoCacheMixin, SettlementSourceMixin, MetarSour
             )
         self._log_temperature_unit(city, use_fahrenheit)
         self._attach_settlement_sources(results, city_lower)
-        self._attach_wunderground_historical(results, city_lower, use_fahrenheit)
 
         if lat and lon:
             forecast_bundle = fetch_open_meteo_forecast_bundle(

tests/test_wunderground_historical.py

@@ -229,32 +229,69 @@ def test_fetch_wunderground_historical_negative_caches_client_errors(monkeypatch
     assert len(calls) == 4
 
 
-def test_fetch_all_sources_attaches_wunderground_historical(monkeypatch, tmp_path):
+def test_fetch_all_sources_skips_wunderground_historical_by_default(monkeypatch, tmp_path):
     collector = _collector(monkeypatch, tmp_path)
-    called = {}
 
     monkeypatch.setattr(collector, "fetch_settlement_current", lambda _city: None)
     monkeypatch.setattr(collector, "_supports_aviationweather", lambda _city: False)
+    calls = []
 
-    def fake_fetch(city: str, *, use_fahrenheit: bool, utc_offset: int, local_date=None):
+    def fail_fetch(*args, **kwargs):
-        called["city"] = city
+        calls.append((args, kwargs))
-        called["use_fahrenheit"] = use_fahrenheit
+        raise AssertionError("fetch_all_sources must not fetch Wunderground by default")
-        called["utc_offset"] = utc_offset
-        called["local_date"] = local_date
-        return {
-            "source": "wunderground_historical",
-            "location_id": "ZSPD:9:CN",
-            "max_so_far": 26,
-        }
 
-    monkeypatch.setattr(collector, "fetch_wunderground_historical", fake_fetch)
+    monkeypatch.setattr(collector, "fetch_wunderground_historical", fail_fetch)
 
     payload = collector.fetch_all_sources("shanghai")
 
-    assert payload["wunderground_current"]["max_so_far"] == 26
+    assert "wunderground_current" not in payload
-    assert called == {
+    assert calls == []
-        "city": "shanghai",
+
-        "use_fahrenheit": False,
+
-        "utc_offset": 28800,
+def test_analyze_summary_skips_wunderground_historical_by_default(monkeypatch):
-        "local_date": None,
+    import web.analysis_service as analysis_service
-    }
+
+    class FakeWeather:
+        TURKISH_PROVINCES = {}
+        wunderground_calls = 0
+
+        def fetch_settlement_current(self, _city):
+            return {}
+
+        def fetch_wunderground_historical(self, *_args, **_kwargs):
+            self.wunderground_calls += 1
+            raise AssertionError("_analyze_summary must not fetch Wunderground by default")
+
+        def fetch_from_open_meteo(self, *_args, **_kwargs):
+            return {
+                "utc_offset": 28800,
+                "daily": {
+                    "time": ["2026-06-14"],
+                    "temperature_2m_max": [30.0],
+                },
+                "hourly": {
+                    "time": [],
+                    "temperature_2m": [],
+                },
+            }
+
+        def fetch_multi_model(self, *_args, **_kwargs):
+            return {"forecasts": {"Open-Meteo": 30.0}, "daily_forecasts": {}}
+
+        def _supports_aviationweather(self, _city):
+            return False
+
+        def fetch_nws(self, *_args, **_kwargs):
+            return {}
+
+    fake_weather = FakeWeather()
+    monkeypatch.setattr(analysis_service, "_weather", fake_weather)
+    monkeypatch.setattr(analysis_service, "_get_cached_analysis", lambda *_args, **_kwargs: None)
+    monkeypatch.setattr(analysis_service, "_get_cached_summary", lambda *_args, **_kwargs: None)
+    monkeypatch.setattr(analysis_service, "calculate_deb_prediction", lambda *_args, **_kwargs: {"prediction": 30.0})
+    monkeypatch.setattr(analysis_service, "_archive_intraday_path_snapshot", lambda *_args, **_kwargs: None)
+
+    payload = analysis_service._analyze_summary("shanghai", force_refresh=False)
+
+    assert payload["wunderground_current"] == {}
+    assert fake_weather.wunderground_calls == 0

web/analysis_service.py

@@ -2017,11 +2017,6 @@ def _analyze_summary(city: str, force_refresh: bool = False) -> Dict[str, Any]:
 
     jobs: Dict[str, Any] = {
         "settlement_current": lambda: _weather.fetch_settlement_current(city) or {},
-        "wunderground_current": lambda: _weather.fetch_wunderground_historical(
-            city,
-            use_fahrenheit=is_f,
-            utc_offset=default_utc_offset,
-        ) or {},
         "open_meteo": lambda: _weather.fetch_from_open_meteo(lat, lon, use_fahrenheit=is_f) or {},
         "multi_model": lambda: _weather.fetch_multi_model(lat, lon, city=city, use_fahrenheit=is_f) or {},
     }