From e0ba3b0eee6bbeeefe91a8a6c2d9b7a8082cbfe9 Mon Sep 17 00:00:00 2001 From: you-n-g Date: Tue, 8 Jul 2025 20:24:31 +0800 Subject: [PATCH] refactor: add string validation for feedback attrs and remove unused var (#1035) --- rdagent/components/coder/CoSTEER/evaluators.py | 4 ++++ rdagent/components/coder/data_science/pipeline/eval.py | 1 - 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/rdagent/components/coder/CoSTEER/evaluators.py b/rdagent/components/coder/CoSTEER/evaluators.py index 24ee8c31..faa528b1 100644 --- a/rdagent/components/coder/CoSTEER/evaluators.py +++ b/rdagent/components/coder/CoSTEER/evaluators.py @@ -70,6 +70,10 @@ class CoSTEERSingleFeedback(Feedback): if not isinstance(data["final_decision"], bool): raise ValueError(f"'final_decision' must be a boolean, not {type(data['final_decision'])}") + + for attr in "execution", "return_checking", "code": + if data[attr] is not None and not isinstance(data[attr], str): + raise ValueError(f"'{attr}' must be a string, not {type(data[attr])}") return data def __str__(self) -> str: diff --git a/rdagent/components/coder/data_science/pipeline/eval.py b/rdagent/components/coder/data_science/pipeline/eval.py index 713295f9..b3f0466c 100644 --- a/rdagent/components/coder/data_science/pipeline/eval.py +++ b/rdagent/components/coder/data_science/pipeline/eval.py @@ -62,7 +62,6 @@ class PipelineCoSTEEREvaluator(CoSTEEREvaluator): result = implementation.run(env=env, entry=f"python -m coverage run main.py --debug") else: result = implementation.run(env=env, entry=f"python -m coverage run main.py") - execute_ret_code = result.exit_code result.stdout = remove_eda_part(result.stdout) if result.exit_code != 0: stdout += f"Code failed to run. Please check the stdout:\n Following the stdout of the debug mode run:\n{result.stdout.strip()}\n"