From 95d81fa71bed68daf4992fcdda9a5bc2d2be0431 Mon Sep 17 00:00:00 2001
From: Haoran Pan <167847254+TPLin22@users.noreply.github.com>
Date: Tue, 3 Dec 2024 13:55:28 +0800
Subject: [PATCH] fix bug in model evaluator final feedback ignoring shape
 feedback (#501)

---
 rdagent/components/coder/model_coder/eva_utils.py  | 2 ++
 rdagent/components/coder/model_coder/evaluators.py | 1 +
 rdagent/components/coder/model_coder/prompts.yaml  | 2 ++
 3 files changed, 5 insertions(+)

diff --git a/rdagent/components/coder/model_coder/eva_utils.py b/rdagent/components/coder/model_coder/eva_utils.py
index 8b2869d8..0a78d8a2 100644
--- a/rdagent/components/coder/model_coder/eva_utils.py
+++ b/rdagent/components/coder/model_coder/eva_utils.py
@@ -123,6 +123,7 @@ class ModelFinalEvaluator(Evaluator):
         implementation: Workspace,
         gt_implementation: Workspace,
         model_execution_feedback: str,
+        model_shape_feedback: str,
         model_value_feedback: str,
         model_code_feedback: str,
     ):
@@ -154,6 +155,7 @@ class ModelFinalEvaluator(Evaluator):
                 .render(
                     model_information=target_task.get_task_information(),
                     model_execution_feedback=execution_feedback_to_render,
+                    model_shape_feedback=model_shape_feedback,
                     model_code_feedback=model_code_feedback,
                     model_value_feedback=model_value_feedback,
                 )
diff --git a/rdagent/components/coder/model_coder/evaluators.py b/rdagent/components/coder/model_coder/evaluators.py
index 926c2e6a..a311ded8 100644
--- a/rdagent/components/coder/model_coder/evaluators.py
+++ b/rdagent/components/coder/model_coder/evaluators.py
@@ -87,6 +87,7 @@ class ModelCoSTEEREvaluator(CoSTEEREvaluator):
             implementation=implementation,
             gt_implementation=gt_implementation,
             model_execution_feedback=model_execution_feedback,
+            model_shape_feedback=shape_feedback,
             model_value_feedback=value_feedback,
             model_code_feedback=code_feedback,
         )
diff --git a/rdagent/components/coder/model_coder/prompts.yaml b/rdagent/components/coder/model_coder/prompts.yaml
index fa6d0212..8742bd26 100644
--- a/rdagent/components/coder/model_coder/prompts.yaml
+++ b/rdagent/components/coder/model_coder/prompts.yaml
@@ -160,6 +160,8 @@ evaluator_final_feedback:
         {{ model_information }}
         --------------Model Execution feedback:---------------
         {{ model_execution_feedback }}
+        --------------Model shape feedback:---------------
+        {{ model_shape_feedback }}
         --------------Model Code feedback:---------------
         {{ model_code_feedback }}
         --------------Model value feedback:---------------