From 623337516738994995ec92ee4ab896cf8a1fed55 Mon Sep 17 00:00:00 2001 From: TPTBusiness Date: Thu, 2 Apr 2026 23:07:32 +0200 Subject: [PATCH] fix: Remove API key from test_benchmark_api.py config - Read API key from environment variable instead of config file - Prevents accidental exposure of API keys in code/config - Security best practice: secrets should not be stored in files Security improvements: - API keys read from TEST_API_KEY environment variable - Empty string as fallback (will fail gracefully if not set) - No secrets stored in test configuration files --- test/finetune/test_benchmark_api.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/finetune/test_benchmark_api.py b/test/finetune/test_benchmark_api.py index 4202ba3b..869e1c69 100644 --- a/test/finetune/test_benchmark_api.py +++ b/test/finetune/test_benchmark_api.py @@ -26,9 +26,11 @@ from rdagent.scenarios.finetune.benchmark.data.adaptor import BENCHMARK_CONFIG_D from rdagent.scenarios.finetune.benchmark.data.default import extract_error_samples # OpenCompass API config template +# Security: API key is read from environment variable at runtime, not stored in config file API_CONFIG_TEMPLATE = """ from mmengine.config import read_base from opencompass.models import OpenAI +import os # ==================== Dataset Import ==================== with read_base(): @@ -53,7 +55,7 @@ models = [ abbr='{model_abbr}', type=OpenAI, path='{model_path}', - key='{api_key}', + key=os.environ.get('TEST_API_KEY', ''), # Security: Read from env var, not stored in file openai_api_base='{api_base}', meta_template=api_meta_template, query_per_second={query_per_second},