last commit

Experts/MAGrid.mq5

@@ -9,7 +9,7 @@
 
 // Moving Average grid strategy
 /*
-Set pending orders x poinst above and below price.
+Set pending orders x point above and below price.
 If price above SMA, buy and set buy orders x time the ATR above and below price.
 If price below SMA, sell and set sell orders x time the ATR above and below price.
 Close all position at the close of the first candle crossing the moving average.
@@ -25,13 +25,13 @@ CiATR* atr;
 //#include <DL_ErrorHandling.mqh> // Error library
 //#include <Nkanven\MAGrid\PreChecks.mqh> // Prechecks
 //#include <Nkanven\MAGrid\TradingHour.mqh> //
-//#include <Trade\Trade.mqh>
+#include <Trade\Trade.mqh>
 #include <Nkanven\MAGrid\ScanPositions.mqh>    // Scan for opened positions
 //#include <Nkanven\MAGrid\CheckHistory.mqh> //Check transaction history
 //#include <Nkanven\MAGrid\TradeManager.mqh> //Manage trade dynamic open and close conditions
 #include <Nkanven\MAGrid\EntriesManager.mqh> // Check buy and sell entries signals and execute them
 #include <Nkanven\MAGrid\LotSizeCal.mqh>   // Lot size calculate
-//#include <Nkanven\MAGrid\ClosePositions.mqh>   // Close opened positions
+#include <Nkanven\MAGrid\CloseTransactions.mqh>   // Close opened positions
 
 
 //+------------------------------------------------------------------+
@@ -63,37 +63,86 @@ void OnTick()
   {
 //---
    SymbolInfoTick(_Symbol,last_tick);
+
+//Get technical indicators values
    ma.Refresh(-1);
    gMa = ma.Main(1);
 
    atr.Refresh(-1);
    gAtr = atr.Main(1);
+
+//Initial position scanning
    ScanPositions();
-   
-   Print("Total transaction ", gTotalTransactions);
-   if(gTotalTransactions>0)
-      return;
 
-   CheckSpread();
-   EvaluateEntry();
-   ExecuteEntry();
-  }
-//+------------------------------------------------------------------+
+   Print("Price is below SMA. Price = ", iClose(gSymbol, PERIOD_CURRENT, 1), " SMA = ", gMa, " Total buy ", gTotalBuyPositions);
 
-//Check and return if the spread is not too high
-void CheckSpread()
-  {
-//Get the current spread in points, the (int) transforms the double coming from MarketInfo into an integer to avoid a warning when compiling
-   long SpreadCurr=SymbolInfoInteger(gSymbol, SYMBOL_SPREAD);
-   Print("Spread ", SpreadCurr);
-   if(SpreadCurr<=InpMaxSpread)
+//Check closing signal
+
+//Close all buy position and orders if price is below MA
+   if(iClose(gSymbol, PERIOD_CURRENT, 1) < gMa && gTotalTransactions > 0)
      {
-      gIsSpreadOK=true;
+      Print("Price is below SMA. Price = ", iClose(gSymbol, PERIOD_CURRENT, 1), " SMA = ", gMa);
+      CloseTransactions(SIGNAL_EXIT_BUY);
      }
    else
      {
-      gIsSpreadOK=false;
+      //Close all sell positions and orders if price is above MA
+      if(iClose(gSymbol, PERIOD_CURRENT, 1) > gMa && gTotalTransactions > 0)
+        {
+         Print("Price is above SMA. Price = ", iClose(gSymbol, PERIOD_CURRENT, 1), " SMA = ", gMa);
+         CloseTransactions(SIGNAL_EXIT_SELL);
+        }
+     }
+
+//Rescan positions
+   ScanPositions();
+
+   Print("Total transaction ", gTotalTransactions, " gTotalBuyPositions ", gTotalBuyPositions);
+//Do not open positions if there are positions or orders pending
+   if(gTotalTransactions>0)
+     {
+      //If there's no position, close all pending orders
+      if(gTotalBuyPositions == 0 && gTotalTransactions > 0)
+        {
+         Print("Delete all");
+         CloseTransactions(SIGNAL_EXIT_ALL);
+        }
+      else
+        {
+         if(gTotalSellPositions==0 && gTotalTransactions >0)
+           {
+            CloseTransactions(SIGNAL_EXIT_ALL);
+           }
+         else
+           {
+            return;
+           }
+        }
+     }
+//+------------------------------------------------------------------+
+//|                                                                  |
+//+------------------------------------------------------------------+
+   CheckSpread();
+   EvaluateEntry();
+   ExecuteEntry();
+}
+//+------------------------------------------------------------------+
+
+//Check and return if the spread is not too high
+   void CheckSpread()
+     {
+      //Get the current spread in points, the (int) transforms the double coming from MarketInfo into an integer to avoid a warning when compiling
+      long SpreadCurr=SymbolInfoInteger(gSymbol, SYMBOL_SPREAD);
+      Print("Spread ", SpreadCurr);
+      if(SpreadCurr<=InpMaxSpread)
+        {
+         gIsSpreadOK=true;
+        }
+      else
+        {
+         gIsSpreadOK=false;
+        }
      }
-  }
 //+------------------------------------------------------------------+
 //+------------------------------------------------------------------+
+