fix: 6 workflow flaws detected via full system test

1. CRITICAL FIX - Reports 500 Internal Server Error:
   Root cause: {{}} in onclick was Jinja2 template expression
   Fix: Changed to single {} in reports_index.html onclick

2. Score history chart always empty:
   Root cause: score_update only emitted inside wfv.passed block
   Fix: Emit score_update after every hypothesis run with {promoted:false}
   Fix: Baseline run also pushes to chart via run_complete handler

3. IS gate too strict - optimizer produces 0 candidates forever:
   Root cause: min_calmar=0.35 but best EA has calmar=0.165
   Fix: Two-tier IS check - passes if composite_score improves vs baseline
   (absolute thresholds still apply as alternative pass condition)

4. Findings emitted twice (double UI display):
   Root cause: baseline analyzed once after run, then re-analyzed in iter 1
   Fix: Cache baseline findings, reuse in iteration 1 without re-emitting

5. Chart labels improved:
   'Baseline' for first point, 'It1·h1' for hypothesis runs
   Calmar normalized -0.5..2.0 -> 0..1 for chart display

6. Best score header only updates on actual promotion (not per-hypothesis)
This commit is contained in:
LEGSTECH Optimizer
2026-04-13 03:45:14 +00:00
parent cf8613eb49
commit b70a6760ae
4 changed files with 67 additions and 17 deletions
+21 -6
View File
@@ -146,6 +146,7 @@ class OptimizerLoop:
self.best_score = baseline_metrics.composite_score
current_params = default_params.copy()
current_metrics = baseline_metrics
current_findings = findings # reuse in iter 1, avoid double-emit
no_improve_count = 0
max_iter = cfg["optimization"]["max_iterations"]
@@ -168,11 +169,14 @@ class OptimizerLoop:
if trades_df.empty and not baseline_trades.empty:
trades_df = baseline_trades
# Analysis
self.phase = "analyze"
findings = self._run_analysis(
current_metrics.run_id, trades_df, current_metrics, analyzers, store
)
# Analysis — reuse cached findings when re-analyzing same run_id
if current_findings is not None and trades_df.empty:
findings = current_findings
else:
findings = self._run_analysis(
current_metrics.run_id, trades_df, current_metrics, analyzers, store
)
current_findings = None # only reuse once
if not findings:
self._emit("log", {"level": "warn", "msg": "No actionable findings. Stopping."})
@@ -251,6 +255,17 @@ class OptimizerLoop:
store.update_hypothesis_status(hyp.hypothesis_id, "tested", run_id)
self.session_tested_deltas.append(hyp.param_delta) # track for session dedup
# Emit score update for every run so chart populates
self._emit("score_update", {
"iteration": self.iteration,
"run_id": run_id,
"score": round(test_metrics.composite_score, 4),
"calmar": round(test_metrics.calmar_ratio, 4),
"pf": round(test_metrics.profit_factor, 4),
"ts": datetime.utcnow().isoformat(),
"promoted": False,
})
if iteration_best is None or test_metrics.composite_score > iteration_best.composite_score:
iteration_best = test_metrics
iteration_best_params = test_params
@@ -262,7 +277,7 @@ class OptimizerLoop:
# Validation gate
self.phase = "validate"
gate_result = gate.run_is_check(iteration_best)
gate_result = gate.run_is_check(iteration_best, baseline_score=current_metrics.composite_score)
if not gate_result.passed:
self._emit("log", {"level": "error", "msg": f"IS gate failed: {gate_result.reason}"})
store.update_hypothesis_status(iteration_best_hyp.hypothesis_id, "rejected")